From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 252E53871030 for ; Wed, 26 Jun 2024 15:34:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 252E53871030 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 252E53871030 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719416080; cv=none; b=oPkFL7hZBThsMQ5Oc4iPdK4viQ1jQFP4wJAVXcIMTL6OmEtz3ULSazs03KJ7oGO2QtqCMC7AMzsvc1YtGxSiT2KNNRl6X4eE6Sh89pxOzEj9F72lKPUmJ0JwOZkrCF+1WsQkupbTaGe3ZLtcikn7YdMdSWPkpIkegMprlx+lbzE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719416080; c=relaxed/simple; bh=tVRghQxmXTbA29QEqDt5LhGHh/hv9RA6TZWpWnk8ZCA=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=iydvNq7MHApULXdCkVMsmomSbZxU8K5bNwXJPVIRw9/kilrTLp0uMDA5Y/pOkD6Lw2GgxmerRahQC34f+jzmFVNXO/q2dnsn0SmU109ksMk33IIQkvRwTelKNpQ7csFvR5jbk53b+ZEu6HFBecwq9BnaCyHxTNdYyghvWDRhHK4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719416077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tVRghQxmXTbA29QEqDt5LhGHh/hv9RA6TZWpWnk8ZCA=; b=bnwwkBd6DSNDTPRpBOElPqs4zAy4f+MARnpa1TmQ5UbFFg7A9Kqizpcnu5sP+gLHWzNMe7 7Xoq99QtwCDOlFI209RiDteNx1IYz1tgnfexqWmYUK6/Uosdr2AP0yPEE80Omr0ZD84qdt IqTSDK8483LYLHlcdKPbP0sG1PXQvvU= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-277-cwmFJ_xONhqiWbdT9qdVuw-1; Wed, 26 Jun 2024 11:34:35 -0400 X-MC-Unique: cwmFJ_xONhqiWbdT9qdVuw-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6b508715363so107773116d6.3 for ; Wed, 26 Jun 2024 08:34:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719416075; x=1720020875; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tVRghQxmXTbA29QEqDt5LhGHh/hv9RA6TZWpWnk8ZCA=; b=PnNUNe7lcO5RFpDBqd594RKio9GodXT3XloJlIfciwnKXz0p/0lRABV2uCiOM9R9bf bks22961002G/6QpiH7lWusD5H/n/9LrWwpcJJMH89KQPTSqH2hWGJkxtiCOZWYrvVT9 eZjEUhi7jNNfBuxuG9UTN5Y6uips4oxR0vq1ka3yYxfBZ2md2wL04fyrQQrSfB+tlAVv Sx9k2Pl80YkQocKkGIn7p27ITv1w/oLC00XM5BYZfa1SzJLmfugf9sy64I3HX1XbgqUF g3KLfTh5Rux3ybS8G5OS3PHrE42qPuWROumcAV/0g35AMT+DsN9BKQH64LPpTbIvYmy/ SGmA== X-Forwarded-Encrypted: i=1; AJvYcCWzn0kowLwbCTV3/m+qE3P3i73/Bn3EtxjBar5TgHD3TrHV4lKotXA+KTsPRlgjKuk/r/VHK/rgt6ySGTltcWU= X-Gm-Message-State: AOJu0Yx4usVl5z9PlZ4i+pCEKtIdENCBz+eqw5pNcsLVSVNket6bmqNe 7riw7efIL/N5+Rsv2B5aylL7cxPWREQjG/6gvbYuPFAnT5Bc2v/SjdB3L1r3cNvuzG32BTSGnmj zfa+IySwNifcaRjOpMIThrG8NAKMwYG3XVSz3ZzqahF+w X-Received: by 2002:a0c:c390:0:b0:6b5:48cd:b567 with SMTP id 6a1803df08f44-6b548cdb681mr87156896d6.24.1719416075356; Wed, 26 Jun 2024 08:34:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHtiECKPtvbiWqnv8FU6VRdZPdoNTweZ0tiM7hDqh5gmQGXq82OYyOWeaNgzltHhONji49E0g== X-Received: by 2002:a0c:c390:0:b0:6b5:48cd:b567 with SMTP id 6a1803df08f44-6b548cdb681mr87156686d6.24.1719416075014; Wed, 26 Jun 2024 08:34:35 -0700 (PDT) Received: from t14s.localdomain (c-76-28-97-5.hsd1.ma.comcast.net. [76.28.97.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b51ef72e7fsm54385356d6.142.2024.06.26.08.34.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jun 2024 08:34:34 -0700 (PDT) Message-ID: <8d6aef3dac729d75ace67d369ef059a21958b3f6.camel@redhat.com> Subject: Re: [PATCH] libgccjit: Make new_array_type take unsigned long From: David Malcolm To: Antoni Boucher , jit@gcc.gnu.org, gcc-patches@gcc.gnu.org Date: Wed, 26 Jun 2024 11:34:33 -0400 In-Reply-To: <4ecf6c4be38aa5aa019d74e249457197e1d79337.camel@zoho.com> References: <2660ad377160743a11f73345771fae8fdb7880ac.camel@zoho.com> <04836ac8aa62ee9e67e4a40bb074d55f54d23402.camel@redhat.com> <19b40a98bc66aadb7f52f369d82b06d7f6f08802.camel@zoho.com> <4ecf6c4be38aa5aa019d74e249457197e1d79337.camel@zoho.com> User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 2024-02-23 at 09:55 -0500, Antoni Boucher wrote: > I had forgotten to add the doc since there is now a new API. > Here it is. Sorry for the delay; the updated patch looks good to me (but may need usual ABI tag changes when pushing). Thanks Dave >=20 > On Wed, 2024-02-21 at 19:45 -0500, Antoni Boucher wrote: > > Thanks for the review. > >=20 > > Here's the updated patch. > >=20 > > On Thu, 2023-12-07 at 20:04 -0500, David Malcolm wrote: > > > On Thu, 2023-12-07 at 17:29 -0500, Antoni Boucher wrote: > > > > Hi. > > > > This patches update gcc_jit_context_new_array_type to take the > > > > size > > > > as > > > > an unsigned long instead of a int, to allow creating bigger > > > > array > > > > types. > > > >=20 > > > > I haven't written the ChangeLog yet because I wasn't sure it's > > > > allowed > > > > to change the type of a function like that. > > > > If it isn't, what would you suggest? > > >=20 > > > We've kept ABI compatibility all the way back to the version in > > > GCC > > > 5, > > > so it seems a shame to break ABI. > > >=20 > > > How about a new API entrypoint: > > > =C2=A0 gcc_jit_context_new_array_type_unsigned_long > > > whilst keeping the old one. > > >=20 > > > Then everything internally can use "unsigned long"; we just keep > > > the > > > old entrypoint accepting int (which internally promotes the arg > > > to > > > unsigned long, if positive, sharing all the implementation). > > >=20 > > > Alternatively, I think there may be a way to do this with symbol > > > versioning: > > > =C2=A0 https://gcc.gnu.org/wiki/SymbolVersioning > > > see e.g. Section 3.7 of Ulrich Drepper's "How To Write Shared > > > Libraries", but I'm a bit wary of cross-platform compatibility > > > with > > > that. > > >=20 > > > Dave > > >=20 > > >=20 > >=20 >=20