public inbox for jit@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: "Marc Nieper-Wißkirchen" <marc@nieper-wisskirchen.de>
Cc: "David Malcolm" <dmalcolm@redhat.com>,
	gcc-patches@gcc.gnu.org,
	"Marc Nieper-Wißkirchen via Jit" <jit@gcc.gnu.org>
Subject: Re: [PATCH] gcc: pass-manager: Fix memory leak. [PR jit/63854]
Date: Sat, 19 Mar 2022 11:43:54 -0600	[thread overview]
Message-ID: <9892054a-466f-9f3b-210a-6a56b17c09b7@gmail.com> (raw)
In-Reply-To: <CAEYrNrSRd9V=6pb_N4hyyiT14XV3CPzrzes32XceZHwT8zgi3g@mail.gmail.com>



On 1/31/2022 4:42 AM, Marc Nieper-Wißkirchen wrote:
> Before the patch, compiling the hello world example of libgccjit with
> the external driver under Valgrind shows a loss of 12,611 (48 direct)
> bytes.  After the patch, no memory leaks are reported anymore.
> (Memory leaks occurring when using the internal driver are mostly in
> the driver code in gcc/gcc.c and have to be fixed separately.)
>
> The patch has been tested by fully bootstrapping the compiler with the
> frontends C, C++, Fortran, LTO, ObjC, JIT and running the test suite
> under a x86_64-pc-linux-gnu host.
>
> gcc/ChangeLog:
>
> 	PR jit/63854
> 	* hash-traits.h (struct typed_const_free_remove): New.
> 	(struct free_string_hash): New.
> 	* pass_manager.h: Use free_string_hash.
> 	* passes.cc (pass_manager::register_pass_name): Use free_string_hash.
>          (pass_manager::~pass_manager): Delete allocated m_name_to_pass_map
I'd hoped David would handle this and I've been insanely busy. 
Regardless, I've pushed this to the trunk.  Thanks and sorry for the 
long delays.

jeff


      parent reply	other threads:[~2022-03-19 17:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-19 21:30 Marc Nieper-Wißkirchen
2022-01-06 13:53 ` David Malcolm
2022-01-06 13:57   ` David Malcolm
2022-01-08  9:26     ` Marc Nieper-Wißkirchen
2022-01-08 10:07   ` Marc Nieper-Wißkirchen
2022-01-08 16:32   ` Jeff Law
2022-01-15 13:56     ` Marc Nieper-Wißkirchen
2022-01-23 13:18       ` Marc Nieper-Wißkirchen
2022-01-31 11:42         ` Marc Nieper-Wißkirchen
2022-03-11 16:31           ` Marc Nieper-Wißkirchen
2022-03-19 17:43           ` Jeff Law [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9892054a-466f-9f3b-210a-6a56b17c09b7@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=dmalcolm@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jit@gcc.gnu.org \
    --cc=marc@nieper-wisskirchen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).