From: David Malcolm <dmalcolm@redhat.com>
To: Eric Gallager <egall@gwmail.gwu.edu>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
jit@gcc.gnu.org, Petter Tomner <tomner@kth.se>
Subject: [committed] jit: fix location of .png files for "make jit.pdf" [PR102824]
Date: Wed, 06 Apr 2022 16:29:12 -0400 [thread overview]
Message-ID: <9c59a2ceb8827d92b645c67bdcb59997c1a02919.camel@redhat.com> (raw)
In-Reply-To: <CAMfHzOtzJ9KmppUo+jtt+ROmK70wYH5OqHfQXx1s6xzVAgY+pQ@mail.gmail.com>
On Fri, 2022-04-01 at 12:26 -0400, Eric Gallager wrote:
> On Fri, Apr 1, 2022 at 9:28 AM David Malcolm via Gcc-patches
> <gcc-patches@gcc.gnu.org> wrote:
> >
> > Further jit doc fixes, which fix links to
> > gcc_jit_function_type_get_param_type and gcc_jit_struct_get_field.
> >
> > I also regenerated libgccjit.texi (not included in the diff below).
> >
> > Tested with "make html" and with a bootstrap.
>
> Could you test with `make pdf` and `make dvi` too, to see if this
> fixes 102824?
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102824
The following seems to fix "make pdf"
"make jit.dvi" is still failing after this; it seems to be looking for
.eps files for the images.
From c9a22b67954f4cd46a739bfe1ddedd544dbfc133 Mon Sep 17 00:00:00 2001
From: David Malcolm <dmalcolm@redhat.com>
Date: Thu, 31 Mar 2022 12:04:54 -0400
Subject: [committed] jit: fix location of .png files for "make jit.pdf" [PR102824]
"make jit.pdf" seems to be looking in
gcc/jit/docs/_build/texinfo/libgccjit-figures
for the .png files, but they were in the source tree in:
gcc/jit/docs/_build/texinfo
Fix "make jit.pdf" via:
git mv \
gcc/jit/docs/_build/texinfo/*.png \
gcc/jit/docs/_build/texinfo/libgccjit-figures
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Manually verified that it fixes "make jit.pdf"; the generated
libgccjit.pdf seems to correctly contain the images.
Pushed to trunk as r12-8031-g790e9814454662.
gcc/jit/ChangeLog:
PR jit/102824
* docs/_build/texinfo/factorial.png: Move to...
* docs/_build/texinfo/libgccjit-figures/factorial.png: ...here.
* docs/_build/texinfo/factorial1.png: Move to...
* docs/_build/texinfo/libgccjit-figures/factorial1.png: ...here.
* docs/_build/texinfo/sum-of-squares.png: Move to...
* docs/_build/texinfo/libgccjit-figures/sum-of-squares.png: ...here.
* docs/_build/texinfo/sum-of-squares1.png: Move to...
* docs/_build/texinfo/libgccjit-figures/sum-of-squares1.png: ...here.
Signed-off-by: David Malcolm <dmalcolm@redhat.com>
---
.../texinfo/{ => libgccjit-figures}/factorial.png | Bin
.../texinfo/{ => libgccjit-figures}/factorial1.png | Bin
.../{ => libgccjit-figures}/sum-of-squares.png | Bin
.../{ => libgccjit-figures}/sum-of-squares1.png | Bin
4 files changed, 0 insertions(+), 0 deletions(-)
rename gcc/jit/docs/_build/texinfo/{ => libgccjit-figures}/factorial.png (100%)
rename gcc/jit/docs/_build/texinfo/{ => libgccjit-figures}/factorial1.png (100%)
rename gcc/jit/docs/_build/texinfo/{ => libgccjit-figures}/sum-of-squares.png (100%)
rename gcc/jit/docs/_build/texinfo/{ => libgccjit-figures}/sum-of-squares1.png (100%)
diff --git a/gcc/jit/docs/_build/texinfo/factorial.png b/gcc/jit/docs/_build/texinfo/libgccjit-figures/factorial.png
similarity index 100%
rename from gcc/jit/docs/_build/texinfo/factorial.png
rename to gcc/jit/docs/_build/texinfo/libgccjit-figures/factorial.png
diff --git a/gcc/jit/docs/_build/texinfo/factorial1.png b/gcc/jit/docs/_build/texinfo/libgccjit-figures/factorial1.png
similarity index 100%
rename from gcc/jit/docs/_build/texinfo/factorial1.png
rename to gcc/jit/docs/_build/texinfo/libgccjit-figures/factorial1.png
diff --git a/gcc/jit/docs/_build/texinfo/sum-of-squares.png b/gcc/jit/docs/_build/texinfo/libgccjit-figures/sum-of-squares.png
similarity index 100%
rename from gcc/jit/docs/_build/texinfo/sum-of-squares.png
rename to gcc/jit/docs/_build/texinfo/libgccjit-figures/sum-of-squares.png
diff --git a/gcc/jit/docs/_build/texinfo/sum-of-squares1.png b/gcc/jit/docs/_build/texinfo/libgccjit-figures/sum-of-squares1.png
similarity index 100%
rename from gcc/jit/docs/_build/texinfo/sum-of-squares1.png
rename to gcc/jit/docs/_build/texinfo/libgccjit-figures/sum-of-squares1.png
--
2.26.3
prev parent reply other threads:[~2022-04-06 20:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-19 15:34 [PATCH] JIT: Update docs v2 Petter Tomner
2022-04-01 13:24 ` David Malcolm
2022-04-01 13:27 ` [committed] jit: further doc fixes David Malcolm
2022-04-01 16:26 ` Eric Gallager
2022-04-01 22:55 ` David Malcolm
2022-04-06 20:29 ` David Malcolm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c59a2ceb8827d92b645c67bdcb59997c1a02919.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=egall@gwmail.gwu.edu \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
--cc=tomner@kth.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).