From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13674 invoked by alias); 2 Feb 2019 07:26:34 -0000 Mailing-List: contact jit-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: jit-owner@gcc.gnu.org Received: (qmail 13651 invoked by uid 89); 2 Feb 2019 07:26:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_SHORT,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_SHORT,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 02 Feb 2019 07:26:32 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id BF1E4ABE6; Sat, 2 Feb 2019 07:26:29 +0000 (UTC) Date: Tue, 01 Jan 2019 00:00:00 -0000 User-Agent: K-9 Mail for Android In-Reply-To: <1549055472.29992.9.camel@redhat.com> References: <1549055472.29992.9.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: Late-breaking jit features (was Re: [PATCH][gcc] libgccjit: introduce gcc_jit_context_add_driver_option) To: David Malcolm ,Jakub Jelinek CC: nd ,Andrea Corallo ,"gcc-patches@gcc.gnu.org" ,"jit@gcc.gnu.org" From: Richard Biener Message-ID: X-SW-Source: 2019-q1/txt/msg00053.txt.bz2 On February 1, 2019 10:11:12 PM GMT+01:00, David Malcolm wrote: >On Mon, 2019-01-21 at 08:40 +0000, Andrea Corallo wrote: >> Hi all, >> Second version of the patch addressing David's comment about all-non- >> failing-tests.h >>=20 >> Adds gcc_jit_context_add_driver_option to the libgccjit ABI and a >> testcase for it. >>=20 >> Using this interface is now possible to pass options affecting >> assembler and linker. >>=20 >> Does not introduce regressions running make check-jit > >Thanks; the patch looks good. > >[CCing the release managers] > >Given that gcc development is now in stage 4, we really shouldn't be >adding new features, but I'm wondering if an exception can be made for >libgccjit? (this patch purely touches the jit subdirectories). > >There's one other late-breaking change, here: > [PATCH][jit] Add thread-local globals to the libgccjit frontend > https://gcc.gnu.org/ml/gcc-patches/2019-01/msg00227.html >which is nearly ready, but is awaiting copyright assignment paperwork. > >Alternatively, should these patches go into a branch of queued jit >changes for gcc 10? Is there anything like an ABI involved? If so we should avoid breaking it a= ll the time. Otherwise JIT is not release critical and thus if you break it= in the wrong moment it's your own fault.=20 Richard.=20 >Thanks >Dave > > >> Bests >>=20 >> Andrea >>=20 >>=20 >> gcc/jit/ChangeLog >> 2019-01-16 Andrea Corallo andrea.corallo@arm.com >>=20 >> * docs/topics/compatibility.rst (LIBGCCJIT_ABI_11): New ABI tag. >> * docs/topics/contexts.rst (Additional driver options): New >> section. >> * jit-playback.c (invoke_driver): Add call to append_driver_options. >> * jit-recording.c: Within namespace gcc::jit... >> (recording::context::~context): Free the optnames within >> m_driver_options. >> (recording::context::add_driver_option): New method. >> (recording::context::append_driver_options): New method. >> (recording::context::dump_reproducer_to_file): Add driver >> options. >> * jit-recording.h: Within namespace gcc::jit... >> (recording::context::add_driver_option): New method. >> (recording::context::append_driver_options): New method. >> (recording::context::m_driver_options): New field. >> * libgccjit++.h (gccjit::context::add_driver_option): New >> method. >> * libgccjit.c (gcc_jit_context_add_driver_option): New API >> entrypoint. >> * libgccjit.h (gcc_jit_context_add_driver_option): New API >> entrypoint. >> (LIBGCCJIT_HAVE_gcc_jit_context_add_driver_option): New >> macro. >> * libgccjit.map (LIBGCCJIT_ABI_11): New ABI tag. >>=20 >>=20 >>=20 >> gcc/testsuite/ChangeLog >> 2019-01-16 Andrea Corallo andrea.corallo@arm.com >>=20 >> * jit.dg/add-driver-options-testlib.c: Add support file for >> test-add-driver-options.c testcase. >> * jit.dg/all-non-failing-tests.h: Add note about >> test-add-driver-options.c >> * jit.dg/jit.exp (jit-dg-test): Update to support >> add-driver-options-testlib.c compilation. >> * jit.dg/test-add-driver-options.c: New testcase. >>=20