From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vibhavp@gmail.com>
Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com
 [IPv6:2a00:1450:4864:20::62b])
 by sourceware.org (Postfix) with ESMTPS id D901E3858C33;
 Sat, 30 Jul 2022 13:48:29 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D901E3858C33
Received: by mail-ej1-x62b.google.com with SMTP id l23so12873395ejr.5;
 Sat, 30 Jul 2022 06:48:29 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=fLTTMSR/iYiIJJ+7O9k1nUOissqt42HYKylbsilBSEc=;
 b=OSDa4myU2v1+oJ+BQX1XUlpPimoFnkzlZAGd1HAJxFEFuUTQEVoqH8DmZZ38UJSCXi
 LAC5LoT8cOcwechl6Y2D/qhio97gkFe4yNnL1PzGsXD2In6VAYU76Tm5WNf/rZyuuBpP
 NXM1ESBWeOIb+eij2RZDDsft8EsZ2TakabsAg9hrw7G01Mz1mv6a/nS8CbVMRUvElAdT
 QaKeXAygqHBpP/vlVm1W4f/b77m8tuaZnRllZjTAvBl9klaH6tnqeCQRd/8E+nb5aFeY
 akawJ0WLyn8nuhuK+qR9pbQBsrlshRcGvp3qu1LbeCbhsN/+jPYv996RfrN2ndldZX14
 Vevw==
X-Gm-Message-State: ACgBeo3ZP+gKAzYR4MZarwE0Z2fo9v8HEIQvCMEAk+sTmhywk3Sgr+qH
 yWCRWiuuOe50YsX57jxo2A9qjjg8QcfpP0FAjrE=
X-Google-Smtp-Source: AA6agR7B8UfuIXy0A2o5rh4kL859vfxtOiW4P7tUhQeTNcEQO0tlC6U0gMdnS8UFMCsVPQ/151eu51NjemHjvbghiww=
X-Received: by 2002:a17:906:98c8:b0:730:59dd:f370 with SMTP id
 zd8-20020a17090698c800b0073059ddf370mr954771ejb.672.1659188907549; Sat, 30
 Jul 2022 06:48:27 -0700 (PDT)
MIME-Version: 1.0
References: <8ce556135d6366aeb434794e7247e8ca806ea736.camel@gmail.com>
 <56d23606ae0212b3077bd617797ab14c465c6cc1.camel@redhat.com>
In-Reply-To: <56d23606ae0212b3077bd617797ab14c465c6cc1.camel@redhat.com>
From: Vibhav Pant <vibhavp@gmail.com>
Date: Sat, 30 Jul 2022 19:18:16 +0530
Message-ID: <CA+T2Sh3+Fr0visv9nxzB_VwfDAUF5VVCYj7Go94tLqwJ=5tS+w@mail.gmail.com>
Subject: Re: [PATCH] libgccjit.h: Make the macro definition for testing
 gcc_jit_context_new_bitcast correctly available.
To: David Malcolm <dmalcolm@redhat.com>
Cc: jit@gcc.gnu.org, gcc-patches@gcc.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: jit@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Jit mailing list <jit.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/jit>,
 <mailto:jit-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/jit/>
List-Help: <mailto:jit-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/jit>,
 <mailto:jit-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 30 Jul 2022 13:48:31 -0000

I don't have push rights to the repo, so this would need to be applied manually.


Thanks,
Vibhav

On Tue, Jul 26, 2022 at 4:48 AM David Malcolm <dmalcolm@redhat.com> wrote:
>
> On Sat, 2022-07-23 at 13:31 +0530, Vibhav Pant via Jit wrote:
> > The macro definition for LIBGCCJIT_HAVE_gcc-jit_context_new_bitcast
> > was earlier located in the documentation comment for
> > gcc_jit_context_new_bitcast, making it unavailable to code that
> > consumed libgccjit.h. This patch moves the definition out of the
> > comment, making it effective.
>
> Good catch!
>
> Do you have push rights to the git repo, or should I push this?
>
> Thanks
> Dave
>


-- 
Vibhav Pant
vibhavp@gmail.com
GPG: 7ED1 D48C 513C A024 BE3A  785F E3FB 28CB 6AB5 9598