From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id 5046F3858D37; Thu, 2 Mar 2023 22:20:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5046F3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-x435.google.com with SMTP id v16so621089wrn.0; Thu, 02 Mar 2023 14:20:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677795605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=DyzGs9SMrtID7eH4U3P2FtQchSvcXgzuk6SDs3krtzI=; b=aT6OD0oClBUVuLkRI1DpPQmxHFDEzKDtZvwGIUR12WqPvwN9VJESBorZGTB9idkxvn 2ZCLWNo12kQ7bFGcsVUisnhwU3NNi77OfBLKnhveQGTdRLEJ/iUnC21Xr9Zgy/1Z+c3I 0UC2zH3tICnEpzdR2mKxQWSaR1uk3/DVSNJs3olseziRjQsB8tFCRCE4urv3pEO5BxTm vW2eIyCaPNDqSh0B8oou0S+0KiW6no+bX68M8uTnckIar5eUEIV9aTY5nMG7M5j/6JKd lVerdk9itwLLGNe7K0Oe9f7Ij/ONF0enUqKAR7QhmDDSV5gF0c2jvinYDLikSI64nYbC 3Pog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677795605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DyzGs9SMrtID7eH4U3P2FtQchSvcXgzuk6SDs3krtzI=; b=InkBfYObsb5txiJ5WawvrAtPtHwX7MxMZyCV+bxB+pOquunVyzx5hiw0Vhy6vui+7R aSbpJ0m1WVuU3TPkPRoD6oRITry9V/ECqKzCSmlasXVyuqFUm2Ryt08VAyAPlCGx+NTg M/2Da+36ZqYb9Sxwl+qIq1xZ5NXJYwWJ4+nNmhbMS0CRNppJ9KdSXFfL9lXrBE8a6OiF umoF61l/42vMV5LueGqQQsJkSjgjW2f4WBeqVGo5AeTLEZr68VRUaikbVU0HJsuUCpd7 XUjOzYwqZrGSkTxmSQQ1uEuFW6aOgWE6IhUFq8G/nm1wn8mGprQhJ9u41yuoOAgZwoLe Etug== X-Gm-Message-State: AO0yUKU5VLbC1loes3OCRjAX8Pi29LcoDPey6vCVGkxk4K8i1GEOGrh+ /7u7YAW3dkORXpLgnLW7AaZ/CZhagpC1cTX45iE= X-Google-Smtp-Source: AK7set8lod99BY5xIqE4ZdDSN6G6SWhDz2Qv2Y8TX4pFndWRULyPY3SJ9tAy0WkHcTQUzsjDRM6g0QWdU6GiBbUwyb8= X-Received: by 2002:a5d:56cb:0:b0:2c7:3bed:481d with SMTP id m11-20020a5d56cb000000b002c73bed481dmr2331536wrw.9.1677795604905; Thu, 02 Mar 2023 14:20:04 -0800 (PST) MIME-Version: 1.0 References: <817e1aaf5f61ebeb2f607d9a7411ca0570e8213f.camel@zoho.com> In-Reply-To: From: Guillaume Gomez Date: Thu, 2 Mar 2023 23:19:53 +0100 Message-ID: Subject: Re: [PATCH] libgccjit: Fix a failing test To: David Malcolm Cc: Antoni Boucher , gcc-patches@gcc.gnu.org, jit@gcc.gnu.org Content-Type: multipart/mixed; boundary="00000000000009568f05f5f23bae" X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000009568f05f5f23bae Content-Type: multipart/alternative; boundary="00000000000009568d05f5f23bac" --00000000000009568d05f5f23bac Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable No problem, thanks for the explanations. I joined the patch with the fixed commit message. Le jeu. 2 mars 2023 =C3=A0 22:58, David Malcolm a =C3= =A9crit : > On Thu, 2022-12-15 at 08:34 +0100, Guillaume Gomez via Jit wrote: > > Forgot it indeed, thanks for notifying me! > > > > I modified the commit message to add it and added it into this email. > > Sorry about the delay in reviewing this; for some reason I didn't see > the mail. > > The patch looks good for trunk, but please add a reference to > PR jit/107999 > to the subject line and ChangeLog message. > > Dave > > > > > Le mer. 14 d=C3=A9c. 2022 =C3=A0 16:12, Antoni Boucher a > > =C3=A9crit : > > > > > Thanks! > > > > > > In your patch, you're missing this line at the end of the commit > > > message: > > > > > > Signed-off-by: Guillaume Gomez > > > > > > On Wed, 2022-12-14 at 14:39 +0100, Guillaume Gomez via Jit wrote: > > > > Hi, > > > > > > > > This fixes bug 107999. > > > > > > > > Thanks in advance for the review. > > > > > > > > --00000000000009568d05f5f23bac-- --00000000000009568f05f5f23bae Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-a-failing-test-by-updating-its-error-string.patch" Content-Disposition: attachment; filename="0001-Fix-a-failing-test-by-updating-its-error-string.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lero66ll0 RnJvbSA5ODUyMjhhNzZmZWVjZjE2NjU4Yjk1YTAxMmUwYjUzMWU3ZTVjNzUw IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBHdWlsbGF1bWUgR29t ZXogPGd1aWxsYXVtZTEuZ29tZXpAZ21haWwuY29tPgpEYXRlOiBXZWQsIDE0 IERlYyAyMDIyIDE0OjI4OjIyICswMTAwClN1YmplY3Q6IFtQQVRDSF0gW1BB VENIXSBGaXggYSBmYWlsaW5nIHRlc3QgYnkgdXBkYXRpbmcgaXRzIGVycm9y IHN0cmluZwogW1BSMTA3OTk5XQoKZ2NjL3Rlc3RzdWl0ZS9DaGFuZ2VMb2c6 CiAgICAgICAgUFIgaml0LzEwNzk5OQoJKiBqaXQuZGcvdGVzdC1lcnJvci1h cnJheS1ib3VuZHMuYzogVXBkYXRlIHRlc3QuCgpTaWduZWQtb2ZmLWJ5OiBH dWlsbGF1bWUgR29tZXogPGd1aWxsYXVtZTEuZ29tZXpAZ21haWwuY29tPgot LS0KIGdjYy90ZXN0c3VpdGUvaml0LmRnL3Rlc3QtZXJyb3ItYXJyYXktYm91 bmRzLmMgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyks IDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9nY2MvdGVzdHN1aXRlL2pp dC5kZy90ZXN0LWVycm9yLWFycmF5LWJvdW5kcy5jIGIvZ2NjL3Rlc3RzdWl0 ZS9qaXQuZGcvdGVzdC1lcnJvci1hcnJheS1ib3VuZHMuYwppbmRleCBiNmMw ZWU1MjZkNC4uYTBkZWFkMTNjYjcgMTAwNjQ0Ci0tLSBhL2djYy90ZXN0c3Vp dGUvaml0LmRnL3Rlc3QtZXJyb3ItYXJyYXktYm91bmRzLmMKKysrIGIvZ2Nj L3Rlc3RzdWl0ZS9qaXQuZGcvdGVzdC1lcnJvci1hcnJheS1ib3VuZHMuYwpA QCAtNzAsNSArNzAsNSBAQCB2ZXJpZnlfY29kZSAoZ2NjX2ppdF9jb250ZXh0 ICpjdHh0LCBnY2Nfaml0X3Jlc3VsdCAqcmVzdWx0KQogICAvKiAuLi5hbmQg dGhhdCB0aGUgbWVzc2FnZSB3YXMgY2FwdHVyZWQgYnkgdGhlIEFQSS4gICov CiAgIENIRUNLX1NUUklOR19WQUxVRSAoZ2NjX2ppdF9jb250ZXh0X2dldF9m aXJzdF9lcnJvciAoY3R4dCksCiAJCSAgICAgICJhcnJheSBzdWJzY3JpcHQg MTAgaXMgYWJvdmUgYXJyYXkgYm91bmRzIG9mIgotCQkgICAgICAiICdjaGFy WzEwXScgWy1XYXJyYXktYm91bmRzXSIpOworCQkgICAgICAiICdjaGFyWzEw XScgWy1XYXJyYXktYm91bmRzPV0iKTsKIH0KLS0gCjIuMzQuMQoK --00000000000009568f05f5f23bae--