From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id 315F93858D38; Thu, 9 Nov 2023 20:51:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 315F93858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 315F93858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::42a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699563102; cv=none; b=jUfV1Ccqnouj55ANfLdET1BEv1zyydiZIL+G64tWG+V1okqgko8yDBRBUaQhnQy8AD0vmwIsEGDB6HqizU+RcfPYsQP0snO8GeW51IWBYf2ll8O0oBpXaYz/+8LilyC+a5Zae1J7G0kVy0U3VwbW0lRbsZMAJd7k2S/Vp29RYS0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699563102; c=relaxed/simple; bh=8rOFipEQpkrfaHtK0Vr7srw4nsQq/zMPVTgDqFOCgMs=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=oGBvdwySXgjddQWdaY2tLk5qZZP1uwnJyqjCetOte7BcsgXDdi0BdoWz1k0xpl8aiOAwgilAClMU1SE7ma+HCjHUReouo3IXZsabvPM2LoSspljH6uM0CgXSE1LIIsVkCY9b0QI4/So9Q9gomKTNa7WiewWG3PKujTxbPj9+AEE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-32deb2809daso728696f8f.3; Thu, 09 Nov 2023 12:51:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699563098; x=1700167898; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8rOFipEQpkrfaHtK0Vr7srw4nsQq/zMPVTgDqFOCgMs=; b=Iacnsyer72ydSDAJgYXaOmRsgEbfH6J1dPNsgqB6s+hszdsGteE1C2xaBU7m5TvXMa fIxfyp0had6uDjjyoey09TLvG3fvpOSSFn2FTgasNr8QhhG/+jmEGWQiSav511VYm/S0 NNbAIr+6hE9J4XcLArI+4X0ouY0/OgDoqhTeBXXMJx6hbdHtXTCxWYa1f0M2i8NfvOxq g97EXwsyNx7oNgjpkYyYS02+eP4iPxk/Mqo/WJxRVt+UlXH+ja3FPTeEYVQfilJtYIjn zuUX12Jry5GLyx2tcmAIvEY/+R8PT0pzc4xZ+tw/4eKh/gX2Ai6TC46b5Dogq1N/PoTx 4Dlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699563098; x=1700167898; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8rOFipEQpkrfaHtK0Vr7srw4nsQq/zMPVTgDqFOCgMs=; b=MzEfW37LpjL+SqhqsTdK53hij6QD4lFkSwmHElv+jO9RW+o2n20f4MssJWCuEMgKqM RBb6xgalBROswyf7asYS6XdvfaibLH+548bdOB8r9opZLRDeCl8FuzPtFVFzgRCPQb3u gBG7sTq1pdZWd5LsbMT3xW1Vkz+ijYs+wAhVbbJh2O3YAKf/lle71SruAxZGlvK4r6Ss FGCwtCn88xITzVtMQxK4vw2UnuEs2e4DAHqy725og2XrtPpNAS9RBUih3TF9aU9sLMwX I9QYrTQ0WMbJnNXTcdUcfuJf8TSjSSOZ8Tq9O02p6VnPuCIhxdzdQcC3qfk8t0/mVYHZ Mknw== X-Gm-Message-State: AOJu0YycjOusM0cKkdnPPxakkbSd1osflHrorQzg4FBkC/pUA4tOf6NV sMgad1HnF/QdEp9qxruohKNiAznA7/lymgDkbHE= X-Google-Smtp-Source: AGHT+IGOPKp6Lq/7gYNDaE9ECh6t3C7u8uV3LylFzuj2pcqDGXO8yqTQfvhC4n8hg6YOp6I5/woBAX/I0VP0b032ZMg= X-Received: by 2002:adf:d1cf:0:b0:323:2d01:f043 with SMTP id b15-20020adfd1cf000000b003232d01f043mr6633530wrd.3.1699563097677; Thu, 09 Nov 2023 12:51:37 -0800 (PST) MIME-Version: 1.0 References: <8cd36a7829ceb78c8e98d1d268403f9eed121128.camel@redhat.com> In-Reply-To: <8cd36a7829ceb78c8e98d1d268403f9eed121128.camel@redhat.com> From: Guillaume Gomez Date: Thu, 9 Nov 2023 21:51:26 +0100 Message-ID: Subject: Re: [PATCH] Add missing declaration of get_restrict in C++ interface To: David Malcolm Cc: gcc-patches@gcc.gnu.org, jit@gcc.gnu.org, Antoni Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I confirm it does. I realized it when finalizing our patch for attributes support. Le jeu. 9 nov. 2023 =C3=A0 21:49, David Malcolm a =C3= =A9crit : > > On Thu, 2023-11-09 at 21:03 +0100, Guillaume Gomez wrote: > > Hi, > > > > This patch adds the `get_restrict` method declaration for > > the C++ interface as it was forgotten. > > > > Thanks in advance for the review. > > Looking at my jit.sum results, it looks like the .cc files are indeed > FAILing on initial compilation, with errors such as: > > In file included from gcc/testsuite/jit.dg/test-alignment.cc:4: > gcc/testsuite/../jit/libgccjit++.h:1414:1: error: no declaration matches = 'gccjit::type gccjit::type::get_restrict()' > gcc/testsuite/../jit/libgccjit++.h:1414:1: note: no functions named 'gccj= it::type gccjit::type::get_restrict()' > gcc/testsuite/../jit/libgccjit++.h:350:9: note: 'class gccjit::type' defi= ned here > > which presumably started with r14-3552-g29763b002459cb. > > Hence the patch looks good to me - thanks! > > Does this patch fix those test cases? > > Dave >