From: Guillaume Gomez <guillaume1.gomez@gmail.com>
To: gcc-patches@gcc.gnu.org, jit@gcc.gnu.org,
David Malcolm <dmalcolm@redhat.com>, Antoni <bouanto@zoho.com>
Subject: [PATCH] Allow `gcc_jit_type_get_size` to work with pointers
Date: Thu, 28 Mar 2024 23:47:22 +0100 [thread overview]
Message-ID: <CAAOQCfRP5n1d+LCx-HsWMqd5DtpJ1c=SN-F2K0upxKVYYeS9=Q@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 117 bytes --]
Hi,
Here's a little fix to allow the `gcc_jit_type_get_size` function to
work on pointer types as well.
Cordially.
[-- Attachment #2: 0001-PATH-Allow-gcc_jit_type_get_size-to-work-with-pointe.patch --]
[-- Type: text/x-patch, Size: 2214 bytes --]
From 21e6e2d5ea897fc74d0e3194973093c58157e6fa Mon Sep 17 00:00:00 2001
From: Guillaume Gomez <guillaume1.gomez@gmail.com>
Date: Tue, 26 Mar 2024 17:56:36 +0100
Subject: [PATCH] [PATH] Allow `gcc_jit_type_get_size` to work with pointers
gcc/jit/ChangeLog:
* libgccjit.cc (gcc_jit_type_get_size): Add pointer support
---
gcc/jit/libgccjit.cc | 4 ++--
gcc/testsuite/jit.dg/test-pointer_size.c | 27 ++++++++++++++++++++++++
2 files changed, 29 insertions(+), 2 deletions(-)
create mode 100644 gcc/testsuite/jit.dg/test-pointer_size.c
diff --git a/gcc/jit/libgccjit.cc b/gcc/jit/libgccjit.cc
index a2cdc01a3a4..58d47723e38 100644
--- a/gcc/jit/libgccjit.cc
+++ b/gcc/jit/libgccjit.cc
@@ -575,8 +575,8 @@ gcc_jit_type_get_size (gcc_jit_type *type)
{
RETURN_VAL_IF_FAIL (type, -1, NULL, NULL, "NULL type");
RETURN_VAL_IF_FAIL
- (type->is_int () || type->is_float (), -1, NULL, NULL,
- "only getting the size of integer or floating-point types is supported for now");
+ (type->is_int () || type->is_float () || type->is_pointer (), -1, NULL, NULL,
+ "only getting the size of integer or floating-point or pointer types is supported for now");
return type->get_size ();
}
diff --git a/gcc/testsuite/jit.dg/test-pointer_size.c b/gcc/testsuite/jit.dg/test-pointer_size.c
new file mode 100644
index 00000000000..337796acc2a
--- /dev/null
+++ b/gcc/testsuite/jit.dg/test-pointer_size.c
@@ -0,0 +1,27 @@
+/* { dg-do compile { target x86_64-*-* } } */
+
+#include <assert.h>
+#include "libgccjit.h"
+
+#include "harness.h"
+
+void
+create_code (gcc_jit_context *ctxt, void *user_data)
+{}
+
+void
+verify_code (gcc_jit_context *ctxt, gcc_jit_result *result)
+{
+ gcc_jit_type *int_type =
+ gcc_jit_context_get_type (ctxt, GCC_JIT_TYPE_INT);
+ gcc_jit_type *int_ptr_type = gcc_jit_type_get_pointer (int_type);
+
+ int int_ptr_size = gcc_jit_type_get_size (int_ptr_type);
+ CHECK_VALUE (int_ptr_size, 8);
+
+ gcc_jit_type *void_type =
+ gcc_jit_context_get_type (ctxt, GCC_JIT_TYPE_VOID);
+ gcc_jit_type *void_ptr_type = gcc_jit_type_get_pointer (void_type);
+
+ CHECK_VALUE (int_ptr_size, gcc_jit_type_get_size (void_ptr_type));
+}
--
2.24.1.2762.gfe2e4819b8
next reply other threads:[~2024-03-28 22:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 22:47 Guillaume Gomez [this message]
2024-03-29 17:48 ` David Malcolm
2024-03-29 17:50 ` Guillaume Gomez
2024-03-29 19:10 ` Guillaume Gomez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAOQCfRP5n1d+LCx-HsWMqd5DtpJ1c=SN-F2K0upxKVYYeS9=Q@mail.gmail.com' \
--to=guillaume1.gomez@gmail.com \
--cc=bouanto@zoho.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).