From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id EA0F43858D37; Thu, 2 Mar 2023 22:29:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EA0F43858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-x334.google.com with SMTP id az36so569700wmb.1; Thu, 02 Mar 2023 14:29:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677796172; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kCjqBxOrDNRu9+P+OatZu/rsxsdKk5pYYv0A9RCMyb0=; b=fjr3Ru/6ZlRss+sXFF9aCbF5BOU6TjSqCY2xBnDHAkFmJCr4mYCNI3cMm2IOWWLch2 hiwdwa0PgNBTE4ngv8aUhBADykJ7igkgPssVa4EO4Y5FqD0OhM8+Uc31/BqhK0cX9HbS 3a4kqIK0XGq0nKgjmDbnODrc7ZvnjsVTZSidINQCpuKwimVdOoKXa+lkA4KqkOscV7nE XbGPfGmYhHj0gaQjeJ772A7/2A0sqF/VB1qJ3Z1KlTi+DOrPsZ1GMZP78eOxkLi6Ib5O K3OT1r7X9TSy4Fo/RqfJN9enaWZoHyjGtWYjw1x5dGbIJbXQiAGnIGg9Et9ueWnL62q8 T38w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677796172; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kCjqBxOrDNRu9+P+OatZu/rsxsdKk5pYYv0A9RCMyb0=; b=ks4LAV/Q8hPXQ/3PCD37kpbbbZmDxRY84VOreDLDra0qtYEA0zvt6JK6ujYrY9QAVN XMreHj8kamkCnXuvVMQtfkJ7ofv0aFIoHg5vlpYFOCo0hvuCdyk6oB1YxaV4spavpr3M NPHqOT3MSpZS4fE0dLWCCpIduACntuE/jarbEYuiN7/m4oIjKXxGyK/7sZ/X5aehdHtR d0IQIwPqtGAh6rd630pcWULzZc4zMfPpwil3Mg1NMiB82Ax21suW+CCurAN6ggSwAL4E TcQ0/d2JilBVapMNiNxo0OeFtBWNvnEKNGtKUHlomERdy3ozhpmZRjypxjGTjZUFFF3v d2tA== X-Gm-Message-State: AO0yUKVJEDgP3aESPABqF8HPo+Jt7yRlVnKINjGLreniZVhgXjkFc1vN d/J38dhZmsgJ0+S+iO7pXyrdENJMAHnV+1GB9SU= X-Google-Smtp-Source: AK7set8yU3VW+k7/tkIDY4NiB/Oks8S1WxazVG9mST+XH4rBsPnGF4Fo/6vryV1rMpM+PkMd04mdGaRe6q3xQ8Bry/0= X-Received: by 2002:a05:600c:a:b0:3df:97b0:ba00 with SMTP id g10-20020a05600c000a00b003df97b0ba00mr3440602wmc.1.1677796172694; Thu, 02 Mar 2023 14:29:32 -0800 (PST) MIME-Version: 1.0 References: <817e1aaf5f61ebeb2f607d9a7411ca0570e8213f.camel@zoho.com> In-Reply-To: From: Guillaume Gomez Date: Thu, 2 Mar 2023 23:29:21 +0100 Message-ID: Subject: Re: [PATCH] libgccjit: Fix a failing test To: David Malcolm Cc: Antoni Boucher , gcc-patches@gcc.gnu.org, jit@gcc.gnu.org Content-Type: multipart/mixed; boundary="000000000000e1389405f5f25cbd" X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000e1389405f5f25cbd Content-Type: multipart/alternative; boundary="000000000000e1389205f5f25cbb" --000000000000e1389205f5f25cbb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Just realized I used whitespace and not a tab. Sorry about that. Here's the fixed version... Le jeu. 2 mars 2023 =C3=A0 23:19, Guillaume Gomez a =C3=A9crit : > No problem, thanks for the explanations. > > I joined the patch with the fixed commit message. > > Le jeu. 2 mars 2023 =C3=A0 22:58, David Malcolm a = =C3=A9crit : > >> On Thu, 2022-12-15 at 08:34 +0100, Guillaume Gomez via Jit wrote: >> > Forgot it indeed, thanks for notifying me! >> > >> > I modified the commit message to add it and added it into this email. >> >> Sorry about the delay in reviewing this; for some reason I didn't see >> the mail. >> >> The patch looks good for trunk, but please add a reference to >> PR jit/107999 >> to the subject line and ChangeLog message. >> >> Dave >> >> > >> > Le mer. 14 d=C3=A9c. 2022 =C3=A0 16:12, Antoni Boucher a >> > =C3=A9crit : >> > >> > > Thanks! >> > > >> > > In your patch, you're missing this line at the end of the commit >> > > message: >> > > >> > > Signed-off-by: Guillaume Gomez >> > > >> > > On Wed, 2022-12-14 at 14:39 +0100, Guillaume Gomez via Jit wrote: >> > > > Hi, >> > > > >> > > > This fixes bug 107999. >> > > > >> > > > Thanks in advance for the review. >> > > >> > > >> >> --000000000000e1389205f5f25cbb-- --000000000000e1389405f5f25cbd Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-a-failing-test-by-updating-its-error-string.patch" Content-Disposition: attachment; filename="0001-Fix-a-failing-test-by-updating-its-error-string.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_leroiiar0 RnJvbSAwODM1YzdiYThiZGY0MDkwYzdmYjEwMjIwNmU3MGMxZWQyMzU4MDhl IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBHdWlsbGF1bWUgR29t ZXogPGd1aWxsYXVtZTEuZ29tZXpAZ21haWwuY29tPgpEYXRlOiBXZWQsIDE0 IERlYyAyMDIyIDE0OjI4OjIyICswMTAwClN1YmplY3Q6IFtQQVRDSF0gW1BB VENIXSBGaXggYSBmYWlsaW5nIHRlc3QgYnkgdXBkYXRpbmcgaXRzIGVycm9y IHN0cmluZwogW1BSMTA3OTk5XQoKZ2NjL3Rlc3RzdWl0ZS9DaGFuZ2VMb2c6 CglQUiBqaXQvMTA3OTk5CgkqIGppdC5kZy90ZXN0LWVycm9yLWFycmF5LWJv dW5kcy5jOiBVcGRhdGUgdGVzdC4KClNpZ25lZC1vZmYtYnk6IEd1aWxsYXVt ZSBHb21leiA8Z3VpbGxhdW1lMS5nb21lekBnbWFpbC5jb20+Ci0tLQogZ2Nj L3Rlc3RzdWl0ZS9qaXQuZGcvdGVzdC1lcnJvci1hcnJheS1ib3VuZHMuYyB8 IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxl dGlvbigtKQoKZGlmZiAtLWdpdCBhL2djYy90ZXN0c3VpdGUvaml0LmRnL3Rl c3QtZXJyb3ItYXJyYXktYm91bmRzLmMgYi9nY2MvdGVzdHN1aXRlL2ppdC5k Zy90ZXN0LWVycm9yLWFycmF5LWJvdW5kcy5jCmluZGV4IGI2YzBlZTUyNmQ0 Li5hMGRlYWQxM2NiNyAxMDA2NDQKLS0tIGEvZ2NjL3Rlc3RzdWl0ZS9qaXQu ZGcvdGVzdC1lcnJvci1hcnJheS1ib3VuZHMuYworKysgYi9nY2MvdGVzdHN1 aXRlL2ppdC5kZy90ZXN0LWVycm9yLWFycmF5LWJvdW5kcy5jCkBAIC03MCw1 ICs3MCw1IEBAIHZlcmlmeV9jb2RlIChnY2Nfaml0X2NvbnRleHQgKmN0eHQs IGdjY19qaXRfcmVzdWx0ICpyZXN1bHQpCiAgIC8qIC4uLmFuZCB0aGF0IHRo ZSBtZXNzYWdlIHdhcyBjYXB0dXJlZCBieSB0aGUgQVBJLiAgKi8KICAgQ0hF Q0tfU1RSSU5HX1ZBTFVFIChnY2Nfaml0X2NvbnRleHRfZ2V0X2ZpcnN0X2Vy cm9yIChjdHh0KSwKIAkJICAgICAgImFycmF5IHN1YnNjcmlwdCAxMCBpcyBh Ym92ZSBhcnJheSBib3VuZHMgb2YiCi0JCSAgICAgICIgJ2NoYXJbMTBdJyBb LVdhcnJheS1ib3VuZHNdIik7CisJCSAgICAgICIgJ2NoYXJbMTBdJyBbLVdh cnJheS1ib3VuZHM9XSIpOwogfQotLSAKMi4zNC4xCgo= --000000000000e1389405f5f25cbd--