From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by sourceware.org (Postfix) with ESMTPS id BA57A3858D1E; Thu, 23 Nov 2023 21:53:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BA57A3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BA57A3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::42e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700776393; cv=none; b=G3fIoVO86d2MyOyTotuyZRQVOCkTpoakeyssQx9sxcyjyh0fPQP4Z8g0lubXvTI1NcwmMsszy7B8bz86mKMNgaAQFTxybgXYSAaDZTx4FXcDuAh8HFpfu5EA4xMQe0Tg9BAcLqDitBLkA2vVPzcGtw+7LFUpSd+LarSK+xjg8cc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700776393; c=relaxed/simple; bh=AfVMllw1rKUiH7mCUG2UjYDHThPJcngt8ut0EjuRsNc=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=txBPz0aUqa3vuJEWB5IPZW+dJKS0wfpeMM8qc18iMLeo6BCQTMBAiBcybJRm/I+6G+B37m/7/xN8pW1fMNfPavatbVKqmnQxvwJEKzC4f8UCFoU+yy1Xce4asJp5+TNmQye3Uvewgn2JgSFfJ1r/A6M9TYnKEUgXHa2E7JP0LnE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-332e42469f0so581257f8f.1; Thu, 23 Nov 2023 13:53:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700776390; x=1701381190; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=AfVMllw1rKUiH7mCUG2UjYDHThPJcngt8ut0EjuRsNc=; b=MtOpJ0JjIqR4ZSJktW0cvbdE3nPt6fcLR1aVITSTgRflAzbBd7BgQ5xZ882MUfS8cg V5tbWHU/zYNJOmhIL7g+HLSlFYX1qUYogY3nfzynR3dCvrKwPbNcKEDNoBLInIS4u1eY 8jlpnE+RH9OX+fks5nssTXO9cnSfXDz6fnk9xwD9Sjh/PA+Gu72/ZneunfCuivgOEJ8U 1qOw14kt5Lg6bgV1LMI5C5R62MK15R/uExwvSBSUqwOzhxan/1maDMARd7EZMTfbr4hK +FOjbhVZj68TgjiVEzn6LUkUYiphucqHUjTqvsSrfnfKzLNzN7h6uW/e3aDMD5d/SdCT jM8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700776390; x=1701381190; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AfVMllw1rKUiH7mCUG2UjYDHThPJcngt8ut0EjuRsNc=; b=GMo7qENXgGX2UhqnGbkmuWS6ySxlyFi2NO5V8vXYR01plvqaOrRkkIlaeJR1ieQ+2K J0vRZ4e6va8g/SDWa57xtSo3CzkDrcG1sFrAs0eSowgCNfQBmlUPPaeuxiUJOuZApNcv L2NMmM2OWzLxnEL1UJIr858jxrwxBq9ochdvPjbgvtOiO+gJuY/cAt9wi9sUi9poC/WG oaoGTwDz4UmMRppGsoFs+XGPExivHIQGEQLpQxzOmMwQjav0ITRQfCpo+UmrkuwmvKxW 5Ut7bAV/3d5L7NIBuJ0mg9FGfV6sril170ntCxB+uX3lsZkZF8QgvPHfTrBmOhzqio+N CELg== X-Gm-Message-State: AOJu0Yzxg5u0qp1OJ+SznWxAY2DuNjqcbhoRUTvhnbKsY015iuKIAdz9 0fQJ+ST6dH41SFrKrO4CEowGT+3RlKq07iu0zf0= X-Google-Smtp-Source: AGHT+IGWtW3zQK5Dkzu8D0IHzJANWfve1Z5ZauFGqeqUoT7kNYu46If3pAJ4sqrJ2TZHSOpOv5dgKh7mAkYHWbYC0ZA= X-Received: by 2002:a5d:4645:0:b0:332:ce52:6388 with SMTP id j5-20020a5d4645000000b00332ce526388mr612593wrs.14.1700776390227; Thu, 23 Nov 2023 13:53:10 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Guillaume Gomez Date: Thu, 23 Nov 2023 22:52:59 +0100 Message-ID: Subject: Re: [PATCH] Add support for function attributes and variable attributes To: Antoni Boucher Cc: jit@gcc.gnu.org, gcc-patches@gcc.gnu.org, David Malcolm Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ping David. :) Le mer. 15 nov. 2023 =C3=A0 17:56, Antoni Boucher a =C3= =A9crit : > > David: another thing I remember you mentioned when you reviewed an > earlier version of this patch is the usage of `std::pair`. > I can't find where you said that, but I remember you mentioned that we > should use a struct instead. > Can you please elaborate again? > Thanks. > > On Wed, 2023-11-15 at 17:53 +0100, Guillaume Gomez wrote: > > Hi, > > > > This patch adds the (incomplete) support for function and variable > > attributes. The added attributes are the ones we're using in > > rustc_codegen_gcc but all the groundwork is done to add more (and we > > will very likely add more as we didn't add all the ones we use in > > rustc_codegen_gcc yet). > > > > The only big question with this patch is about `inline`. We currently > > handle it as an attribute because it is more convenient for us but is > > it ok or should we create a separate function to mark a function as > > inlined? > > > > Thanks in advance for the review. >