I don't have push rights so if you could push it, it'd be super appreciated! Le jeu. 2 mars 2023 à 23:33, David Malcolm a écrit : > On Thu, 2023-03-02 at 23:29 +0100, Guillaume Gomez wrote: > > Just realized I used whitespace and not a tab. Sorry about that. > > Here's the > > fixed version... > > Looks great. Do you have push rights, or do you want me to push this? > > Thanks > Dave > > > > > Le jeu. 2 mars 2023 à 23:19, Guillaume Gomez > > a > > écrit : > > > > > No problem, thanks for the explanations. > > > > > > I joined the patch with the fixed commit message. > > > > > > Le jeu. 2 mars 2023 à 22:58, David Malcolm a > > > écrit : > > > > > > > On Thu, 2022-12-15 at 08:34 +0100, Guillaume Gomez via Jit wrote: > > > > > Forgot it indeed, thanks for notifying me! > > > > > > > > > > I modified the commit message to add it and added it into this > > > > > email. > > > > > > > > Sorry about the delay in reviewing this; for some reason I didn't > > > > see > > > > the mail. > > > > > > > > The patch looks good for trunk, but please add a reference to > > > > PR jit/107999 > > > > to the subject line and ChangeLog message. > > > > > > > > Dave > > > > > > > > > > > > > > Le mer. 14 déc. 2022 à 16:12, Antoni Boucher > > > > > a > > > > > écrit : > > > > > > > > > > > Thanks! > > > > > > > > > > > > In your patch, you're missing this line at the end of the > > > > > > commit > > > > > > message: > > > > > > > > > > > > Signed-off-by: Guillaume Gomez > > > > > > > > > > > > > > > > > > On Wed, 2022-12-14 at 14:39 +0100, Guillaume Gomez via Jit > > > > > > wrote: > > > > > > > Hi, > > > > > > > > > > > > > > This fixes bug 107999. > > > > > > > > > > > > > > Thanks in advance for the review. > > > > > > > > > > > > > > > > > > > > > >