From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id 12206385843E; Thu, 2 Mar 2023 22:35:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 12206385843E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-x32e.google.com with SMTP id p16so552585wmq.5; Thu, 02 Mar 2023 14:35:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677796557; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Z75Q/LkuZmWPXNhrkGBIjgZLdVCECD0/9VpZ5zZ6cNk=; b=RX/niTGjuOPF9epaNFPBCfPToZEYJBcbUN+VOyE3IBkxXKwQ0I23SYqWVaL7rBBvDK jy8algATm9eISEwJuwGfbRBFK4uNRR6krQ0sTbgba2Fana6CR4ID47Zhvu/tcLF09rIJ TcWuJX9flsIRZtwhwzylQLf4b6lDuqD1+DoD4rmZ/1PKvKl7HB7p6zRPz852GOQ+zEzq rGaxg3sj8tJFtvVAmtJJLWuQtplQBV9EfE9tmb23Y9UCupVsK0/jKNEf517i2rlXGF3q WBhZvoUhVJfJxMa0dK4sirhPpcxt4VB7N9DodAuXOlGzQkEhrRyxoXMIh0e8SYJDpFvK vGAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677796557; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z75Q/LkuZmWPXNhrkGBIjgZLdVCECD0/9VpZ5zZ6cNk=; b=QZ2Q43FGTitUe+FlWjXIiRDxZtE6y39r0gh0tvMahNei+bkliDXWJ8+2omBSlGmAmr 34YnnUSzyaKAm8UsHwSSJzENLRCaxL0yW4jLlB8z4qbcOx20SSdcwclYZGfMSj1kvvIR NLZRHCZ/zhfqwggiqNfv1EPP9kvayIfXKQkiPcYsL2zvOFJvbKc/EJfWIM/u4u/tKBN+ kr18cnWn5JhegQPCNP+TDLlrg/rEevdgiQId9ptmqmGK/BorrUmKy426AO1zQlVhJB4H 7hlNbTZ7s0BclB2KFBtbb5iHKTgnF+HZDTBCH0JtO4NF4uikb3PifbM3I+nMai+1YcJz 4MvA== X-Gm-Message-State: AO0yUKW6JmL7xiuPtbcSzrC6pgpwt1l++SS9gxkJq8gz0fkbkDKYYaab TBM7RDjKoEYR7sCC7kUEEdZxOBEATRoteOVOKnI= X-Google-Smtp-Source: AK7set9ydS5QHN03TxQMOyx0wZ6NDUSXdKfnYwdVYSA1U0a0cI0lRIhEDxUqzWiEyCN5Vz7SF+cy/PBOGnBSyBLCjMk= X-Received: by 2002:a05:600c:a:b0:3df:97b0:bab5 with SMTP id g10-20020a05600c000a00b003df97b0bab5mr3318179wmc.1.1677796557688; Thu, 02 Mar 2023 14:35:57 -0800 (PST) MIME-Version: 1.0 References: <817e1aaf5f61ebeb2f607d9a7411ca0570e8213f.camel@zoho.com> <232081fba9a447be10b80abede13127d4cea213c.camel@redhat.com> In-Reply-To: <232081fba9a447be10b80abede13127d4cea213c.camel@redhat.com> From: Guillaume Gomez Date: Thu, 2 Mar 2023 23:35:46 +0100 Message-ID: Subject: Re: [PATCH] libgccjit: Fix a failing test To: David Malcolm Cc: Antoni Boucher , gcc-patches@gcc.gnu.org, jit@gcc.gnu.org Content-Type: multipart/alternative; boundary="000000000000d3941f05f5f273ab" X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000d3941f05f5f273ab Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I don't have push rights so if you could push it, it'd be super appreciated! Le jeu. 2 mars 2023 =C3=A0 23:33, David Malcolm a =C3= =A9crit : > On Thu, 2023-03-02 at 23:29 +0100, Guillaume Gomez wrote: > > Just realized I used whitespace and not a tab. Sorry about that. > > Here's the > > fixed version... > > Looks great. Do you have push rights, or do you want me to push this? > > Thanks > Dave > > > > > Le jeu. 2 mars 2023 =C3=A0 23:19, Guillaume Gomez > > a > > =C3=A9crit : > > > > > No problem, thanks for the explanations. > > > > > > I joined the patch with the fixed commit message. > > > > > > Le jeu. 2 mars 2023 =C3=A0 22:58, David Malcolm = a > > > =C3=A9crit : > > > > > > > On Thu, 2022-12-15 at 08:34 +0100, Guillaume Gomez via Jit wrote: > > > > > Forgot it indeed, thanks for notifying me! > > > > > > > > > > I modified the commit message to add it and added it into this > > > > > email. > > > > > > > > Sorry about the delay in reviewing this; for some reason I didn't > > > > see > > > > the mail. > > > > > > > > The patch looks good for trunk, but please add a reference to > > > > PR jit/107999 > > > > to the subject line and ChangeLog message. > > > > > > > > Dave > > > > > > > > > > > > > > Le mer. 14 d=C3=A9c. 2022 =C3=A0 16:12, Antoni Boucher > > > > > a > > > > > =C3=A9crit : > > > > > > > > > > > Thanks! > > > > > > > > > > > > In your patch, you're missing this line at the end of the > > > > > > commit > > > > > > message: > > > > > > > > > > > > Signed-off-by: Guillaume Gomez > > > > > > > > > > > > > > > > > > On Wed, 2022-12-14 at 14:39 +0100, Guillaume Gomez via Jit > > > > > > wrote: > > > > > > > Hi, > > > > > > > > > > > > > > This fixes bug 107999. > > > > > > > > > > > > > > Thanks in advance for the review. > > > > > > > > > > > > > > > > > > > > > > --000000000000d3941f05f5f273ab--