From: Bartosz Szreder <bartosz.szreder@huuugegames.com>
To: David Malcolm <dmalcolm@redhat.com>
Cc: jit@gcc.gnu.org
Subject: Re: Function pointer handling
Date: Sun, 01 Jan 2017 00:00:00 -0000 [thread overview]
Message-ID: <CACDdPnvvjxiyk4xaVHYKm_D4hkc-kcvwcSRv30oEYOnHV4WmMg@mail.gmail.com> (raw)
In-Reply-To: <1506018592.10251.23.camel@redhat.com>
Hello David,
>> 1. The documentation doesn't mention existence of
>> gcc_jit_context_new_function_ptr_type() as a mechanism of handling
>> function pointers, yet contains
>> gcc_jit_context_new_call_through_ptr().
>
> [...]
>
> It's just missing documentation. I'm working on fixing it.
> Have a look at gcc/testsuite/jit.dg/test-calling-function-ptr.c
Thanks, this is very helpful!
>> - What is the proper way of obtaining a function pointer to be passed
>> to gcc_jit_context_new_call_through_ptr()? There doesn't seem to be
>> any counterpart to gcc_jit_lvalue_get_address() for functions. As the
>> name suggests, gcc_jit_lvalue_get_address() works on an L-value and
>> gcc_jit_function type isn't an ancestor of gcc_jit_lvalue in the
>> internal type system, therefore upcasting is impossible.
>
> [...]
>
> If it's a function that's being compiled as part of the same
> gcc_jit_context, then I think you've identified a weakness in the
> current API. As you say, one fix would be to make gcc_jit_function be
> a subclass of gcc_jit_lvalue (and add casting functions); I don't yet
> know how easy that would be to implement.
Yes, this is the exact use case I'm thinking of.
From an user's point of view, I believe making gcc_jit_function a
subclass of gcc_jit_lvalue makes for an awkward design. Maybe
something like this would be easier to implement without upending the
current hierarchy:
gcc_jit_rvalue *gcc_jit_context_function_get_address(gcc_jit_context
*ctxt, gcc_jit_function *fun);
Thanks,
Bartosz Szreder
next prev parent reply other threads:[~2017-09-22 9:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-01 0:00 Bartosz Szreder
2017-01-01 0:00 ` David Malcolm
2017-01-01 0:00 ` Bartosz Szreder [this message]
2017-01-01 0:00 ` [committed] jit: implement gcc_jit_function_get_address David Malcolm
2017-01-01 0:00 ` [committed] jit: document function pointers David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACDdPnvvjxiyk4xaVHYKm_D4hkc-kcvwcSRv30oEYOnHV4WmMg@mail.gmail.com \
--to=bartosz.szreder@huuugegames.com \
--cc=dmalcolm@redhat.com \
--cc=jit@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).