public inbox for jit@gcc.gnu.org
 help / color / mirror / Atom feed
From: Dibyendu Majumdar <mobile@majumdar.org.uk>
To: David Malcolm <dmalcolm@redhat.com>
Cc: jit@gcc.gnu.org
Subject: Re: Hit a showstopper issue
Date: Thu, 01 Jan 2015 00:00:00 -0000	[thread overview]
Message-ID: <CACXZuxdpEiozt4-s07AujNXjP2bVa+140mSpnm87Yn7b9wN2wQ@mail.gmail.com> (raw)
In-Reply-To: <1434401660.14663.27.camel@surprise>

On 15 June 2015 at 21:54, David Malcolm <dmalcolm@redhat.com> wrote:
> Yes: the IR exposed by the libgccjit API is not SSA-form.  The optimizer
> does use SSA-form internally.
>
> I think my opinion at the time was that forcing users to create phi
> nodes was unnecessary work for them; let the API do it automatically,
> internally.   I don't know if the loss of this kind of validation is a
> show-stopper; it feels to me more like a fussy API that the user has to
> do extra work to appease.  But I could be wrong.
>

In LLVM I hardly ever specify phi-nodes - it constructs them during
optimization when it detects a scenario requiring a phi-node. I just
declare my locals and use them appropriately - but yes one can
explicitly code phi-nodes and to me (who is not so familiar with the
concept) this is painful.

>> In any case a warning about unreachable bocks may be more appropriate
>> than errors.
>
> FWIW I've experimented in the past with turning on warnings about
> uninitialized vars, so maybe we need an API setting for validations,
> with each validation having a tri-state:
>   * perform validation, as error
>   * perform validate, as warnings to stderr
>   * don't validate
>

That makes sense.

Regards

  parent reply	other threads:[~2015-06-15 21:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-01  0:00 Dibyendu Majumdar
2015-01-01  0:00 ` David Malcolm
2015-01-01  0:00   ` Dibyendu Majumdar
2015-01-01  0:00     ` Dibyendu Majumdar
2015-01-01  0:00       ` David Malcolm
2015-01-01  0:00         ` David Malcolm
2015-01-01  0:00         ` Dibyendu Majumdar [this message]
2015-01-01  0:00           ` David Malcolm
2015-01-01  0:00             ` Dibyendu Majumdar
2015-01-01  0:00 ` Dibyendu Majumdar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACXZuxdpEiozt4-s07AujNXjP2bVa+140mSpnm87Yn7b9wN2wQ@mail.gmail.com \
    --to=mobile@majumdar.org.uk \
    --cc=dmalcolm@redhat.com \
    --cc=jit@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).