From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jit-return-596-listarch-jit=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 83878 invoked by alias); 14 Jun 2015 19:11:06 -0000
Mailing-List: contact jit-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Post: <mailto:jit@gcc.gnu.org>
List-Help: <mailto:jit-help@gcc.gnu.org>
List-Subscribe: <mailto:jit-subscribe@gcc.gnu.org>
Sender: jit-owner@gcc.gnu.org
Received: (qmail 83867 invoked by uid 89); 14 Jun 2015 19:11:05 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Checked: by ClamAV 0.98.7 on sourceware.org
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2
X-Spam-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org
X-Spam-Level: 
X-HELO: mail-yk0-f170.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:mime-version:date:message-id:subject:from:to
         :content-type;
        bh=PTUq7jDxmlILhOOwBeXUm9GlD2GOfnQAkkRtQ8mtMp0=;
        b=hNOSpVTnZd0z5zwy79fozxKBiofwa9Gb/1OWPWv1h1XrFH6Zlfjv12p5eakh7aPLY/
         63t05yexbWOihtuMGky6po5zwlfNxgdAUpu47FlXho967GchI+lhQJnud9fIVbteST94
         uT5Xmx2Kifx21hSMUVSpQ4sBVS87kxjPjbK2vpaXohzdtH5Hp7QQODiGdKg7GpywkHMa
         ZeYwCmFz2BYXVjhXkqXGt5VEzsSLaukyR5Zh9VJu2+rfxzRzki70deUyLO/GMIw3Zq+A
         Wn/h4egnC6huVVID5o8SgYRPpmcDc5BQHGDjNzOoMikO7NxWqfFwiWESb8yhw9c9fpc6
         RH1g==
X-Gm-Message-State: ALoCoQkYBTIXEVgQvaaqdtKsqkdDM+SGU2kVkA8XAzF1318B/gP+XIURwmPJ0D7vI6dIhmJ0iWgg
MIME-Version: 1.0
X-Received: by 10.129.39.21 with SMTP id n21mr14853801ywn.55.1434309061637;
 Sun, 14 Jun 2015 12:11:01 -0700 (PDT)
Date: Thu, 01 Jan 2015 00:00:00 -0000
Message-ID: <CACXZuxe7cV7dW=5w9yEXnCHTXkdLN8GCrtGzm58d9ZRSYbLrfA@mail.gmail.com>
Subject: The output of gcc_jit_context_dump_to_file() is missing parenthesis
 in expressions involving casts
From: Dibyendu Majumdar <mobile@majumdar.org.uk>
To: jit@gcc.gnu.org
Content-Type: text/plain; charset=UTF-8
X-SW-Source: 2015-q2/txt/msg00054.txt.bz2

It seems that in some cases the output is not showing parenthesis
where it should.

For instance:

 if ((struct ravi_LClosure *)L->ci->func->p->sizep > (int)0)


The cast is to be applied to L->ci->func - so this expression should
be in parenthesis.

  gcc_jit_rvalue *rvalue__struct_ravi_LClosure___L__ci__func_0xae4e10 =
    gcc_jit_context_new_cast (ctxt_0xae4350,
                              NULL, /* gcc_jit_location *loc */
                              gcc_jit_lvalue_as_rvalue
(lvalue_L__ci__func_0xae4b90), /* gcc_jit_rvalue *rvalue */

  gcc_jit_lvalue *lvalue__struct_ravi_LClosure___L__ci__func__p_0xae4fd0=
    gcc_jit_rvalue_dereference_field
(rvalue__struct_ravi_LClosure___L__ci__func_0xae4e10, /*
gcc_jit_rvalue *ptr */
                                      NULL, /* gcc_jit_location *loc */
                                      field_p_0xacf1d0); /*
gcc_jit_field *field */

  gcc_jit_lvalue *lvalue__struct_ravi_LClosure___L__ci__func__p__k_0xae5020=
    gcc_jit_rvalue_dereference_field (gcc_jit_lvalue_as_rvalue
(lvalue__struct_ravi_LClosure___L__ci__func__p_0xae4fd0), /*
gcc_jit_rvalue *ptr */
                                      NULL, /* gcc_jit_location *loc */
                                      field_k_0xacdc10); /*
gcc_jit_field *field */