public inbox for jit@gcc.gnu.org
 help / color / mirror / Atom feed
From: Dibyendu Majumdar <mobile@majumdar.org.uk>
To: David Malcolm <dmalcolm@redhat.com>
Cc: jit@gcc.gnu.org
Subject: Re: [PATCH] PR jit/66812: Candidate fix for for the code generation issue, v1
Date: Thu, 01 Jan 2015 00:00:00 -0000	[thread overview]
Message-ID: <CACXZuxf=dh5k78Nwi5Y_VSUZbNLYw3BiMvrmt237vz-a3ChBAg@mail.gmail.com> (raw)
In-Reply-To: <1436477075.24803.171.camel@surprise>

On 9 July 2015 at 22:24, David Malcolm <dmalcolm@redhat.com> wrote:
> On Thu, 2015-07-09 at 17:15 -0400, David Malcolm wrote:
>> On Thu, 2015-07-09 at 17:06 -0400, David Malcolm wrote:
>>
>> (snip)
>>
>> > The fix will be to implement the LANG_HOOKS_GET_ALIAS_SET internal GCC
>> > API thus giving libgccjit some rules about aliasing.  Some options:
>> >
>> > (i) make it identical to C.
>> > (ii) give the client code some control over this
>> >
>> > My initial gut feeling is to go with (i).
>>
>> ...or possibly to do what the link-time optimizer does, which is to use
>> this internal API:
>>
>> /* Return the typed-based alias set for T, which may be an expression
>>    or a type.  Return -1 if we don't do anything special.  */
>>
>> alias_set_type
>> gimple_get_alias_set (tree t)
>>
>> which does almost all of what the C frontend does.  I'll try to cook up
>> a patch.
>
> Attached is a patch [1] which fixes the minimal reproducer I created,
> and the reproducer you sent.
>
> Does it work for you?
>

I get this error when compiling:

In file included from ../../gcc-5.1.0/gcc/jit/dummy-frontend.c:54:0:
../../gcc-5.1.0/gcc/gimple.h: In function ‘void
gimple_call_set_fndecl(gimple, tree)’:
../../gcc-5.1.0/gcc/gimple.h:2769:77: error:
‘build_fold_addr_expr_loc’ was not declared in this scope
   gimple_set_op (gs, 1, build_fold_addr_expr_loc (gimple_location (gs), decl));
                                                                             ^
Am I missing something?

Regards
Dibyendu

  reply	other threads:[~2015-07-09 22:20 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-01  0:00 A possible code generation issue Dibyendu Majumdar
2015-01-01  0:00 ` Dibyendu Majumdar
2015-01-01  0:00   ` Dibyendu Majumdar
2015-01-01  0:00     ` Dibyendu Majumdar
2015-01-01  0:00       ` David Malcolm
2015-01-01  0:00         ` Dibyendu Majumdar
2015-01-01  0:00           ` Dibyendu Majumdar
2015-01-01  0:00             ` Filed PR jit/66811: jit jumps aren't compilable as C (Re: A possible code generation issue) David Malcolm
2015-01-01  0:00               ` Filed PR jit/66811: jit dumps " David Malcolm
2015-01-01  0:00             ` A possible code generation issue Dibyendu Majumdar
2015-01-01  0:00               ` PR jit/66783 (Re: A possible code generation issue) David Malcolm
2015-01-01  0:00                 ` [PATCH, committed] PR jit/66783: prevent use of opaque structs David Malcolm
2015-01-01  0:00       ` Filed PR jit/66812 for the code generation issue David Malcolm
2015-01-01  0:00         ` David Malcolm
2015-01-01  0:00           ` David Malcolm
2015-01-01  0:00             ` David Malcolm
2015-01-01  0:00               ` Dibyendu Majumdar
2015-01-01  0:00                 ` David Malcolm
2015-01-01  0:00                   ` Dibyendu Majumdar
2015-01-01  0:00                     ` David Malcolm
2015-01-01  0:00                       ` Dibyendu Majumdar
2015-01-01  0:00                         ` Dibyendu Majumdar
2015-01-01  0:00                           ` David Malcolm
2015-01-01  0:00                             ` Dibyendu Majumdar
2015-01-01  0:00                               ` David Malcolm
2015-01-01  0:00                                 ` Dibyendu Majumdar
2015-01-01  0:00                                 ` David Malcolm
2015-01-01  0:00                                   ` [PATCH] PR jit/66812: Candidate fix for for the code generation issue, v1 David Malcolm
2015-01-01  0:00                                     ` Dibyendu Majumdar [this message]
2015-01-01  0:00                                       ` David Malcolm
2015-01-01  0:00                                         ` Dibyendu Majumdar
2015-01-01  0:00                                           ` Dibyendu Majumdar
2015-01-01  0:00                                             ` David Malcolm
2015-01-01  0:00                                               ` Dibyendu Majumdar
2015-01-01  0:00                                                 ` Dibyendu Majumdar
2015-01-01  0:00               ` Filed PR jit/66812 for the code generation issue Dibyendu Majumdar
2015-01-01  0:00                 ` Dibyendu Majumdar
2015-01-01  0:00                   ` Dibyendu Majumdar
2015-01-01  0:00                     ` Dibyendu Majumdar
2015-01-01  0:00                       ` Dibyendu Majumdar
2015-01-01  0:00                         ` Dibyendu Majumdar
2015-01-01  0:00                           ` David Malcolm
2015-01-01  0:00                             ` David Malcolm
2015-01-01  0:00                               ` Dibyendu Majumdar
2015-01-01  0:00                             ` Dibyendu Majumdar
2015-01-01  0:00               ` David Malcolm
2015-01-01  0:00             ` Dibyendu Majumdar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACXZuxf=dh5k78Nwi5Y_VSUZbNLYw3BiMvrmt237vz-a3ChBAg@mail.gmail.com' \
    --to=mobile@majumdar.org.uk \
    --cc=dmalcolm@redhat.com \
    --cc=jit@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).