From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50507 invoked by alias); 10 Jul 2015 00:14:40 -0000 Mailing-List: contact jit-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: jit-owner@gcc.gnu.org Received: (qmail 50472 invoked by uid 89); 10 Jul 2015 00:14:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.98.7 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-Spam-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: mail-yk0-f176.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=l6NSqTYPR4/tjXdANegC9Y0FffBu1LmfmYlnauj3N0U=; b=UbKG+ZFKGMuOrTSLzgkqGhbbwnXXKq5GHjR128sJrdiP85VwFEvyKFdJFzRLpXB/wJ 8PjUZBMrSAsOEjKZ8wW8gLiQ3Mz5oaF2vvjQaSodKBSTXBDw/n3PRnpK6s4wnUobXpMd I0TwiwU7AubfpL4hD3KMI8pBkpK+x0K9Iio/TMtOZhGznk//fCsfFKhK0v0IqnlOtgte T8Npx6JaQE3WdQYvZ/sxH7qD5z7nzxZ88iabmKBBFk6lgt1QqAbqf5MfHBxqgjlPhVHS 8EGIoxGtbK3EgNyvneSbB2TyOTInB0L2A0Pjoay7vuGkb/jTTbtUMZvncKJMR6pB3wqq cEqQ== X-Gm-Message-State: ALoCoQmd3mkpEJD3w81FqpZv6uJdtRcHqH6ZWb1KJLSkQUxpVISlV1w2AxUomzuZVjsMRg9eEmKZ MIME-Version: 1.0 X-Received: by 10.170.208.81 with SMTP id z78mr20383961yke.106.1436487274516; Thu, 09 Jul 2015 17:14:34 -0700 (PDT) In-Reply-To: <1436484627.24803.173.camel@surprise> References: <1436365266.24803.65.camel@surprise> <1436367926.24803.71.camel@surprise> <1436369443.24803.75.camel@surprise> <1436377619.24803.97.camel@surprise> <1436382217.24803.101.camel@surprise> <1436385256.24803.107.camel@surprise> <1436469764.24803.156.camel@surprise> <1436476508.24803.168.camel@surprise> <1436477075.24803.171.camel@surprise> <1436484627.24803.173.camel@surprise> Date: Thu, 01 Jan 2015 00:00:00 -0000 Message-ID: Subject: Re: [PATCH] PR jit/66812: Candidate fix for for the code generation issue, v1 From: Dibyendu Majumdar To: David Malcolm Cc: jit@gcc.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2015-q3/txt/msg00067.txt.bz2 On 10 July 2015 at 00:30, David Malcolm wrote: > On Thu, 2015-07-09 at 23:20 +0100, Dibyendu Majumdar wrote: >> On 9 July 2015 at 22:24, David Malcolm wrote: >> > On Thu, 2015-07-09 at 17:15 -0400, David Malcolm wrote: >> >> On Thu, 2015-07-09 at 17:06 -0400, David Malcolm wrote: >> >> >> >> (snip) >> >> >> >> > The fix will be to implement the LANG_HOOKS_GET_ALIAS_SET internal = GCC >> >> > API thus giving libgccjit some rules about aliasing. Some options: >> >> > >> >> > (i) make it identical to C. >> >> > (ii) give the client code some control over this >> >> > >> >> > My initial gut feeling is to go with (i). >> >> >> >> ...or possibly to do what the link-time optimizer does, which is to u= se >> >> this internal API: >> >> >> >> /* Return the typed-based alias set for T, which may be an expression >> >> or a type. Return -1 if we don't do anything special. */ >> >> >> >> alias_set_type >> >> gimple_get_alias_set (tree t) >> >> >> >> which does almost all of what the C frontend does. I'll try to cook = up >> >> a patch. >> > >> > Attached is a patch [1] which fixes the minimal reproducer I created, >> > and the reproducer you sent. >> > >> > Does it work for you? >> > >> >> I get this error when compiling: >> >> In file included from ../../gcc-5.1.0/gcc/jit/dummy-frontend.c:54:0: >> ../../gcc-5.1.0/gcc/gimple.h: In function =E2=80=98void >> gimple_call_set_fndecl(gimple, tree)=E2=80=99: >> ../../gcc-5.1.0/gcc/gimple.h:2769:77: error: >> =E2=80=98build_fold_addr_expr_loc=E2=80=99 was not declared in this scope >> gimple_set_op (gs, 1, build_fold_addr_expr_loc (gimple_location (gs),= decl)); >> = ^ >> Am I missing something? > > The patch was for trunk, where GCC's internal headers have been > reorganized, so we need different #includes for gcc-5-branch. > > Does the attached work? (it compiles; I haven't tested it though) > The isolated test works. Now running the full Lua test suite.