public inbox for jit@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Marc Nieper-Wißkirchen" <marc@nieper-wisskirchen.de>
To: David Malcolm <dmalcolm@redhat.com>
Cc: gcc-patches@gcc.gnu.org,
	"Marc Nieper-Wißkirchen via Jit" <jit@gcc.gnu.org>
Subject: Re: [PATCH] gcc: pass-manager: Fix memory leak. [PR jit/63854]
Date: Sat, 8 Jan 2022 10:26:53 +0100	[thread overview]
Message-ID: <CAEYrNrR5N_e7iwHXJ7xxQWNA_4PG2Z457+MEeBGDzsduc5QqUA@mail.gmail.com> (raw)
In-Reply-To: <88abc7840520b561e3f8e524cfdd2b2f0b3928f6.camel@redhat.com>

Am Do., 6. Jan. 2022 um 14:57 Uhr schrieb David Malcolm via Jit
<jit@gcc.gnu.org>:

> [...snip...]
>
> >
> > > diff --git a/gcc/passes.c b/gcc/passes.c
> > > index 4bea6ae5b6a..0c70ece5321 100644
> > > --- a/gcc/passes.c
> > > +++ b/gcc/passes.c
>
> [...snip...]
>
> > > @@ -1943,7 +1944,7 @@ pass_manager::dump_profile_report () const
> > >            "                                 |in count     |out
> > > prob     "
> > >            "|in count                  |out prob                  "
> > >            "|size               |time                      |\n");
> > > -
> > > +
> > >    for (int i = 1; i < passes_by_id_size; i++)
> > >      if (profile_record[i].run)
> > >        {
> >
>
> ...and there's a stray whitespace change here (in
> pass_manager::dump_profile_report), which probably shouldn't be in the
> patch.

There was stray whitespace in that line the unpatched version of
`passes.c`, which my Emacs silently cleaned up.

Shall I retain this whitespace although it should probably haven't
been there in the first place? Or should I just add a remark in the
patch notes about that?

Thanks,

Marc

  reply	other threads:[~2022-01-08  9:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-19 21:30 Marc Nieper-Wißkirchen
2022-01-06 13:53 ` David Malcolm
2022-01-06 13:57   ` David Malcolm
2022-01-08  9:26     ` Marc Nieper-Wißkirchen [this message]
2022-01-08 10:07   ` Marc Nieper-Wißkirchen
2022-01-08 16:32   ` Jeff Law
2022-01-15 13:56     ` Marc Nieper-Wißkirchen
2022-01-23 13:18       ` Marc Nieper-Wißkirchen
2022-01-31 11:42         ` Marc Nieper-Wißkirchen
2022-03-11 16:31           ` Marc Nieper-Wißkirchen
2022-03-19 17:43           ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEYrNrR5N_e7iwHXJ7xxQWNA_4PG2Z457+MEeBGDzsduc5QqUA@mail.gmail.com \
    --to=marc@nieper-wisskirchen.de \
    --cc=dmalcolm@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jit@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).