From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de [85.215.255.51]) by sourceware.org (Postfix) with ESMTPS id 343A73858401; Sat, 8 Jan 2022 09:27:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 343A73858401 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=nieper-wisskirchen.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=nieper-wisskirchen.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1641634025; s=strato-dkim-0002; d=nieper-wisskirchen.de; h=Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:Cc:Date: From:Subject:Sender; bh=h5r6Y4Lsbzv12pp5janjfdOYmayVbWHhm4eG2XghArw=; b=dEmm4v7GO0emxuFds+eGtdVFOY/W/brk4C0PJilFl/NiVcSNYaU1ormuo84dn4A52c ZAslojGBPNB3SKtcTKU2zoRobL6cx2Bn1qFugcTkqkzyW9AeH1i7KLK9T0SafvE2oCGP TuqoDKyUEfDTtH10oJPIIxzwHeYdO1ZGp9pdw3Dsc+cDhYXuOPTrU3cK1vViUBehW1kl PsShdxlgDiJalL3gCfVDWO1N1ZJtuCv6HK4sPd1vZacOYviYlwolnqAnjSDhxdzLNycA itX6jCXyZwltO/FgVsf9Z7PamdoDbWUtfUky+2ObNyB3vCW2gBwRhFNJ3Ffjk/DwuOe9 ZMWA== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":IW0WdmCmcvpIrP2+VJuPtIhjJvc4Ig+QdhX22iZVwSDOx4Kp3cYsBVGy6CZgmO/guIaKV8N565JADQ==" X-RZG-CLASS-ID: mo00 Received: from mail-yb1-f173.google.com by smtp.strato.de (RZmta 47.37.6 AUTH) with ESMTPSA id k693bey089R58oP (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Sat, 8 Jan 2022 10:27:05 +0100 (CET) Received: by mail-yb1-f173.google.com with SMTP id c6so21635756ybk.3; Sat, 08 Jan 2022 01:27:05 -0800 (PST) X-Gm-Message-State: AOAM531bInRPkB0b2HPgyDa8Ii2bIO04MUXnBCluXkJPioFiQ9Anpc4C bz5tisdfG+hjNxSvVWNLChKCnlSiD0DebCcbLi0= X-Google-Smtp-Source: ABdhPJw0zXvuZtBbW/+TYiQH8BO1mXihu/bCDv/YR3kwxpPckLToiPIqZpWFAu900S0yeLaY1WbbHKUyx4eus7RPNP4= X-Received: by 2002:a05:6902:110b:: with SMTP id o11mr56474924ybu.559.1641634024613; Sat, 08 Jan 2022 01:27:04 -0800 (PST) MIME-Version: 1.0 References: <20211219213010.17113-1-marc@nieper-wisskirchen.de> <2a54fac9b37d87afb009b8eb339d5ad6927454dd.camel@redhat.com> <88abc7840520b561e3f8e524cfdd2b2f0b3928f6.camel@redhat.com> In-Reply-To: <88abc7840520b561e3f8e524cfdd2b2f0b3928f6.camel@redhat.com> From: =?UTF-8?Q?Marc_Nieper=2DWi=C3=9Fkirchen?= Date: Sat, 8 Jan 2022 10:26:53 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] gcc: pass-manager: Fix memory leak. [PR jit/63854] To: David Malcolm Cc: gcc-patches@gcc.gnu.org, =?UTF-8?Q?Marc_Nieper=2DWi=C3=9Fkirchen_via_Jit?= Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Jan 2022 09:27:08 -0000 Am Do., 6. Jan. 2022 um 14:57 Uhr schrieb David Malcolm via Jit : > [...snip...] > > > > > > diff --git a/gcc/passes.c b/gcc/passes.c > > > index 4bea6ae5b6a..0c70ece5321 100644 > > > --- a/gcc/passes.c > > > +++ b/gcc/passes.c > > [...snip...] > > > > @@ -1943,7 +1944,7 @@ pass_manager::dump_profile_report () const > > > " |in count |out > > > prob " > > > "|in count |out prob " > > > "|size |time |\n"); > > > - > > > + > > > for (int i = 1; i < passes_by_id_size; i++) > > > if (profile_record[i].run) > > > { > > > > ...and there's a stray whitespace change here (in > pass_manager::dump_profile_report), which probably shouldn't be in the > patch. There was stray whitespace in that line the unpatched version of `passes.c`, which my Emacs silently cleaned up. Shall I retain this whitespace although it should probably haven't been there in the first place? Or should I just add a remark in the patch notes about that? Thanks, Marc