From: "Marc Nieper-Wißkirchen" <marc.nieper+gnu@gmail.com>
To: David Malcolm <dmalcolm@redhat.com>
Cc: "Marc Nieper-Wißkirchen" <marc.nieper+gnu@gmail.com>,
"Marc Nieper-Wißkirchen via Jit" <jit@gcc.gnu.org>
Subject: Re: C++ API: Union types are missing
Date: Mon, 31 Jan 2022 16:10:55 +0100 [thread overview]
Message-ID: <CAEYrNrTfgppXJh_9AWXeF1RJU2EXpjwDHLOLDbhp-XZ4-kPdow@mail.gmail.com> (raw)
In-Reply-To: <6c9e4de75b2ec8776e25ea5f01c0b5276ae09746.camel@redhat.com>
Am Mo., 31. Jan. 2022 um 15:57 Uhr schrieb David Malcolm <
dmalcolm@redhat.com>:
> On Sun, 2022-01-30 at 20:34 +0100, Marc Nieper-Wißkirchen wrote:
> > The C++ analog for gcc_jit_context_new_union_type is missing in
> > libgccjit++.h.
> >
> > I can send a patch adding it and anything else I may find missing as
> > well.
>
> Yes please; ideally with test coverage.
>
> > Dave, as only one header file is concerned, would a single patch be
> > okay? I
> > hope it could still make it into GCC 12 as no component outside of the
> > file
> > would be touched.
>
> It's technically something I ought to ask permission for from the
> release managers given that the rest of gcc 12 is in deep feature
> freeze, but I think there's a good case for this - especially if the
> patch has test coverage (if nothing else, I've found that it's
> impossible to gauge how good an API is without writing code to consume
> that API).
>
A patch is already out with a test case. :)
Another one will follow that adds the missing support for function pointer
types in the C++ API.
Marc
prev parent reply other threads:[~2022-01-31 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-30 19:34 Marc Nieper-Wißkirchen
2022-01-31 14:57 ` David Malcolm
2022-01-31 15:10 ` Marc Nieper-Wißkirchen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEYrNrTfgppXJh_9AWXeF1RJU2EXpjwDHLOLDbhp-XZ4-kPdow@mail.gmail.com \
--to=marc.nieper+gnu@gmail.com \
--cc=dmalcolm@redhat.com \
--cc=jit@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).