From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) by sourceware.org (Postfix) with ESMTPS id DB1973858038 for ; Mon, 31 Jan 2022 15:11:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DB1973858038 Received: by mail-yb1-xb36.google.com with SMTP id c19so12601022ybf.2 for ; Mon, 31 Jan 2022 07:11:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XmTnQsT+YtS+SDF83VRUwsSH9uef9uy0dsdE4fD+hpQ=; b=fJ3E3mCA0jNYDSV+3PO5vNcmym2qJOYkrq6EHfWjAYd5eM+9CHkAegS9fX/jkrefJ9 pFAqFzTGjziKJvTsgfWvYEVdX1djvfmgwnUYgyTNSAbqTc/ydD7xOquXcH4MwLfT6LmE VeNTeOq6dt104yd1Z9aaCSSRQD4/O+ZBBzYqyzMND+nerqZVfG4qARY5PC9EX9JePik7 kr9RdbdJV7r/o3QxGmAGiOWb0AUuIqS5VViVqLP1dyiLbMI02ampk1Hot1ORPtARX57R oVLIDm+cKM2CkLSTc0uQc0jAEb8KNh2n2D6lINl8LwKAY8YWbSTHt3m0Mqag14/EaRiu LjNA== X-Gm-Message-State: AOAM530XNfwQ4K1Wdz21Mt8qUx6spbs7HiKOTE2dvDiyNmDbtCoiWx8N f1mxBWTP+WOMG/NrHdlumKAdj1Jc3c4DFpUCerQ= X-Google-Smtp-Source: ABdhPJwDB4nEoMtvchZko9k97693zkbpeGEBeSaXVayoaxjc6HCBjD6fQ+pPd6qk/ydAD0gNHEyq6m0NIbdrhH6a1mE= X-Received: by 2002:a25:c095:: with SMTP id c143mr29874824ybf.559.1643641867070; Mon, 31 Jan 2022 07:11:07 -0800 (PST) MIME-Version: 1.0 References: <6c9e4de75b2ec8776e25ea5f01c0b5276ae09746.camel@redhat.com> In-Reply-To: <6c9e4de75b2ec8776e25ea5f01c0b5276ae09746.camel@redhat.com> From: =?UTF-8?Q?Marc_Nieper=2DWi=C3=9Fkirchen?= Date: Mon, 31 Jan 2022 16:10:55 +0100 Message-ID: Subject: Re: C++ API: Union types are missing To: David Malcolm Cc: =?UTF-8?Q?Marc_Nieper=2DWi=C3=9Fkirchen?= , =?UTF-8?Q?Marc_Nieper=2DWi=C3=9Fkirchen_via_Jit?= X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jan 2022 15:11:09 -0000 Am Mo., 31. Jan. 2022 um 15:57 Uhr schrieb David Malcolm < dmalcolm@redhat.com>: > On Sun, 2022-01-30 at 20:34 +0100, Marc Nieper-Wi=C3=9Fkirchen wrote: > > The C++ analog for gcc_jit_context_new_union_type is missing in > > libgccjit++.h. > > > > I can send a patch adding it and anything else I may find missing as > > well. > > Yes please; ideally with test coverage. > > > Dave, as only one header file is concerned, would a single patch be > > okay? I > > hope it could still make it into GCC 12 as no component outside of the > > file > > would be touched. > > It's technically something I ought to ask permission for from the > release managers given that the rest of gcc 12 is in deep feature > freeze, but I think there's a good case for this - especially if the > patch has test coverage (if nothing else, I've found that it's > impossible to gauge how good an API is without writing code to consume > that API). > A patch is already out with a test case. :) Another one will follow that adds the missing support for function pointer types in the C++ API. Marc