From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) by sourceware.org (Postfix) with ESMTPS id 491093851C2C; Fri, 29 May 2020 14:48:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 491093851C2C Received: by mail-io1-xd41.google.com with SMTP id s18so2648850ioe.2; Fri, 29 May 2020 07:48:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CQouI3+56cOG4qz3ASbIyUHL0ecwsl8pzcn9sW+i0Tw=; b=FoxAWNQ8LK32T1WEoorFba0R+kX6wZJrj8FlRQTlNDNJLuK8sTmHt8v1O2ckhHEjTg M8whTf6f5Eu4lDHGqEHiU4NFsIaHE5aTgKFxd+iZLydBnR5oXqrxaoQLQYyEd3HAhV09 L63iXAaqU79Z1VyfCii2BjHTyW84zgpMXHvd2Qb4NJwZ5z74q0nlAyvSiCXT35RgBIoC 6He/NP0bGhGSKQFY1jJ3v2tVakzyhWqfNArwnzXTS22ZNQzGMG+6KkMA+S+govzOsvUP zB1FR/6NcB2jXbMpPFuKbzFN9rZhSB9OvMvI6Sf/vbMorHNWEqwUiMb8Kq7aLov6TDvm eDRA== X-Gm-Message-State: AOAM530V+qdFuqznsXXIoIFCqSfPHIhG88qvaEHec7nU/BymL6iz6gxz UDPx6evDdUeSjzjzuXKB4urxOqa04sd14xxPj2I= X-Google-Smtp-Source: ABdhPJwhq8j5NH/j/X0+mvezMKlXs0hdEbPJTkSsRCWnUfzZwt0+v/v/Q0NvxvETU4Cjgq5tt8u8/G8sQLW9FG5pxqs= X-Received: by 2002:a6b:ab03:: with SMTP id u3mr6770009ioe.148.1590763704625; Fri, 29 May 2020 07:48:24 -0700 (PDT) MIME-Version: 1.0 References: <4b619179a08075bd2ee7f9e98aa2d5918191306d.camel@redhat.com> <5de2a5202b50882612e1fe51d254f2b125f61716.camel@redhat.com> <885d0b34df56c30f25c2ba57f4eecf517d1ba05c.camel@redhat.com> In-Reply-To: <885d0b34df56c30f25c2ba57f4eecf517d1ba05c.camel@redhat.com> From: NightStrike Date: Fri, 29 May 2020 10:48:16 -0400 Message-ID: Subject: Re: [PATCH] Port libgccjit to Windows. To: David Malcolm Cc: =?UTF-8?Q?Nicolas_B=C3=A9rtolo?= , jit@gcc.gnu.org, GCC Patches , JonY <10walls@gmail.com>, Kai Tietz X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 May 2020 14:48:26 -0000 On Thu, May 28, 2020, 4:25 PM David Malcolm via Gcc-patches < gcc-patches@gcc.gnu.org> wrote: > On Wed, 2020-05-27 at 22:27 -0300, Nicolas B=C3=A9rtolo wrote: > > > New C++ source files should have a .cc extension. > > > I hope that at some point we'll rename all the existing .c ones > > > accordingly. > > > > I just couldn't get Make to generate jit-w32.o from jit-w32.cc. > > It looks for jit-w32.c. > > > > I had to leave it with the .c extension. > > Fair enough. > That's not a good reason to leave it like this. You should get a make expert to help here. I was able to successfully bootstrap and regression test with your > patch on x86_64-pc-linux-gnu. I also verified that the result of "make > install" was not affected for my configuration. > > I've pushed your patch to master as > c83027f32d9cca84959c7d6a1e519a0129731501. > > (I had to do a little fixup of the ChangeLog entries to get them to > work with the new hooks on our git repo) > > Thanks again for the patch > Dave > > [1] > https://docs.microsoft.com/en-us/previous-versions/windows/desktop/legacy= /aa379560(v=3Dvs.85) I don't want to sound confrontational, but I don't think testing this on linux and reviewing it by non windows experts is correct. At the very least, a windows maintainer (Jon, Kai) should review it for correctness. I've cc'd them here.