From: Richard Biener <richard.guenther@gmail.com>
To: David Malcolm <dmalcolm@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, jit@gcc.gnu.org
Subject: Re: [PATCH 20/21] PR jit/63854: Fix leak in ipa-icf.c
Date: Wed, 01 Jan 2014 00:00:00 -0000 [thread overview]
Message-ID: <CAFiYyc0A=N9K77bd38soMggMXbpUbGS18d7rRBHOa6QKQFaNqQ@mail.gmail.com> (raw)
In-Reply-To: <1416393981-39626-21-git-send-email-dmalcolm@redhat.com>
On Wed, Nov 19, 2014 at 11:46 AM, David Malcolm <dmalcolm@redhat.com> wrote:
> ipa-icf.c was leaking 16 bytes per iteration in the jit testcases here:
Ok.
Tahnks,
Richard.
> 80 bytes in 5 blocks are definitely lost in loss record 94 of 199
> at 0x4A0645D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
> by 0x5D764B7: xmalloc (xmalloc.c:147)
> by 0x5C962FF: ipa_icf::sem_item_optimizer::get_group_by_hash(unsigned int, ipa_icf::sem_item_type) (ipa-icf.c:1503)
> by 0x5C96C8C: ipa_icf::sem_item_optimizer::build_hash_based_classes() (ipa-icf.c:1723)
> by 0x5C96765: ipa_icf::sem_item_optimizer::execute() (ipa-icf.c:1616)
> by 0x5C98E81: ipa_icf::ipa_icf_driver() (ipa-icf.c:2373)
> by 0x5C993C8: ipa_icf::pass_ipa_icf::execute(function*) (ipa-icf.c:2421)
> by 0x5223CCD: execute_one_pass(opt_pass*) (passes.c:2306)
> by 0x5224BA7: execute_ipa_pass_list(opt_pass*) (passes.c:2700)
> by 0x4E49B0D: ipa_passes() (cgraphunit.c:2088)
> by 0x4E49E2C: symbol_table::compile() (cgraphunit.c:2172)
> by 0x4E4A1C2: symbol_table::finalize_compilation_unit() (cgraphunit.c:2325)
>
> by not freeing the allocation here:
>
> congruence_class_group *item = XNEW (congruence_class_group);
>
> in sem_item_optimizer::get_group_by_hash.
>
> Fix it.
>
> gcc/ChangeLog:
> PR jit/63854
> * ipa-icf.c (sem_item_optimizer::~sem_item_optimizer): Free each
> congruence_class_group *.
> ---
> gcc/ipa-icf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/gcc/ipa-icf.c b/gcc/ipa-icf.c
> index 2d5fcf5..b0ba82e 100644
> --- a/gcc/ipa-icf.c
> +++ b/gcc/ipa-icf.c
> @@ -1322,6 +1322,7 @@ sem_item_optimizer::~sem_item_optimizer ()
> delete (*it)->classes[i];
>
> (*it)->classes.release ();
> + free (*it);
> }
>
> m_items.release ();
> --
> 1.8.5.3
>
next prev parent reply other threads:[~2014-11-19 11:49 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-01 0:00 [PATCH 00/21] PR 63854: Fix various memory leaks David Malcolm
2014-01-01 0:00 ` [PATCH 16/21] PR jit/63854: Add all_late_ipa_passes to GCC_PASS_LISTS David Malcolm
2014-01-01 0:00 ` Richard Biener
2014-01-01 0:00 ` [PATCH 17/21] PR jit/63854: Fix leaking vec in jit David Malcolm
2014-01-01 0:00 ` Jeff Law
2014-01-01 0:00 ` [PATCH 03/21] PR jit/63854: Fix memory leaks within context/pass_manager/dump_manager David Malcolm
2014-01-01 0:00 ` Jeff Law
2014-01-01 0:00 ` [PATCH 15/21] PR jit/63854: lra.c: Fix leak of point_freq_vec's buffer when calling lra_inheritance David Malcolm
2014-01-01 0:00 ` Jeff Law
2014-01-01 0:00 ` [PATCH 06/21] PR jit/63854: Fix leak of opts_obstack David Malcolm
2014-01-01 0:00 ` Richard Biener
2014-01-01 0:00 ` [PATCH 11/21] PR jit/63854: Fix leak of "avail" within tree-ssa-pre.c David Malcolm
2014-01-01 0:00 ` Richard Biener
2014-01-01 0:00 ` [PATCH 13/21] PR jit/63854: Add support for running "make check-jit" under valgrind David Malcolm
2014-01-01 0:00 ` Jeff Law
2014-01-01 0:00 ` David Malcolm
2014-01-01 0:00 ` Jeff Law
2014-01-01 0:00 ` [PATCH 00/05] Fixes to jit.exp David Malcolm
2014-01-01 0:00 ` Running cc1 etc under valgrind (was Re: [PATCH 13/21] PR jit/63854: Add support for running "make check-jit" under valgrind) David Malcolm
2014-01-01 0:00 ` David Malcolm
2014-01-01 0:00 ` [PATCH 00/05] Fixes to jit.exp David Malcolm
2014-01-01 0:00 ` [PATCH 03/05] jit.exp: fix timeout bug inherited from dejagnu.exp David Malcolm
2014-01-01 0:00 ` [PATCH 01/05] jit.exp: Avoid embedding full paths into test results David Malcolm
2014-01-01 0:00 ` Mike Stump
2014-01-01 0:00 ` [PATCH 04/05] jit.exp: Verify the exit status of the spawnee David Malcolm
2014-01-01 0:00 ` [PATCH 05/05] Add command-line option-parsing to jit testcases David Malcolm
2014-01-01 0:00 ` PING: " David Malcolm
2014-01-01 0:00 ` Mike Stump
2014-01-01 0:00 ` David Malcolm
2014-01-01 0:00 ` Mike Stump
2014-01-01 0:00 ` [PATCH 02/05] PR jit/63854: Add support for running "make check-jit" under valgrind David Malcolm
2014-01-01 0:00 ` [PATCH 12/21] PR jit/63854: Add a valgrind suppresion file David Malcolm
2014-01-01 0:00 ` Richard Biener
2014-01-01 0:00 ` Jeff Law
2014-01-01 0:00 ` David Malcolm
2015-01-01 0:00 ` Hans-Peter Nilsson
2014-01-01 0:00 ` [PATCH 20/21] PR jit/63854: Fix leak in ipa-icf.c David Malcolm
2014-01-01 0:00 ` Richard Biener [this message]
2014-01-01 0:00 ` [PATCH 21/21] PR jit/63854: Fix leaks in test-fuzzer.c David Malcolm
2014-01-01 0:00 ` Jeff Law
2014-01-01 0:00 ` [PATCH 18/21] PR jit/63854: Add "long-term" allocator to gcc::context David Malcolm
2014-01-01 0:00 ` Joseph Myers
2015-01-01 0:00 ` PING: " David Malcolm
2015-01-01 0:00 ` Joseph Myers
2014-01-01 0:00 ` [PATCH 01/21] PR jit/63854: Fix memory leak within gcc_options David Malcolm
2014-01-01 0:00 ` Richard Biener
2014-01-01 0:00 ` [PATCH 10/21] PR jit/63854: Fix leak of worklist within jit-recording.c David Malcolm
2014-01-01 0:00 ` Jeff Law
2014-01-01 0:00 ` David Malcolm
2014-01-01 0:00 ` Richard Biener
2014-01-01 0:00 ` Jeff Law
2014-01-01 0:00 ` [PATCH 08/21] PR jit/63854: Add ira_costs_c_finalize David Malcolm
2014-01-01 0:00 ` Richard Biener
2014-01-01 0:00 ` [PATCH 07/21] PR jit/63854: Fix leak of optimization_summary_obstack David Malcolm
2014-01-01 0:00 ` Richard Biener
2014-01-01 0:00 ` [PATCH 02/21] PR jit/63854: Fix memory leak of reginfo.c: valid_mode_changes_obstack David Malcolm
2014-01-01 0:00 ` Richard Biener
2014-01-01 0:00 ` [PATCH 04/21] PR jit/63854: Fix memory leak within bb-reorder.c David Malcolm
2014-01-01 0:00 ` Richard Biener
2014-01-01 0:00 ` [PATCH 09/21] PR jit/63854: Don't leak producer_string in dwarf2out.c David Malcolm
2014-01-01 0:00 ` Richard Biener
2014-01-01 0:00 ` [PATCH 14/21] PR jit/63854: Fix leak of paths within jump threading David Malcolm
2014-01-01 0:00 ` Richard Biener
2014-01-01 0:00 ` [PATCH 05/21] PR jit/63854: Fix memory leak of save_decoded_options David Malcolm
2014-01-01 0:00 ` Richard Biener
2014-01-01 0:00 ` [PATCH 19/21] PR jit/63854: Fix leak of ipa hooks David Malcolm
2014-01-01 0:00 ` Jeff Law
2014-01-01 0:00 ` PING " David Malcolm
2014-01-01 0:00 ` Jan Hubicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc0A=N9K77bd38soMggMXbpUbGS18d7rRBHOa6QKQFaNqQ@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).