From: Richard Biener <richard.guenther@gmail.com>
To: Matthias Klose <doko@ubuntu.com>
Cc: David Malcolm <dmalcolm@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
jit@gcc.gnu.org
Subject: Re: [patch] PR jit/87808: Allow libgccjit to work without an external gcc driver
Date: Tue, 13 Jul 2021 08:41:38 +0200 [thread overview]
Message-ID: <CAFiYyc1HqPuoBKWcUw3uzAkPEzgJoPO8hBOW5A4-WG4RRT7mpQ@mail.gmail.com> (raw)
In-Reply-To: <5a46c90f-aea4-7dd6-cbc6-db8cf29cba95@ubuntu.com>
On Mon, Jul 12, 2021 at 11:00 PM Matthias Klose <doko@ubuntu.com> wrote:
>
> On 3/26/19 12:52 PM, Matthias Klose wrote:
> > On 22.03.19 23:00, David Malcolm wrote:
> >> On Thu, 2019-03-21 at 12:26 +0100, Matthias Klose wrote:
> >>> Fix PR jit/87808, the embedded driver still needing the external gcc
> >>> driver to
> >>> find the gcc_lib_dir. This can happen in a packaging context when
> >>> libgccjit
> >>> doesn't depend on the gcc package, but just on binutils and libgcc-
> >>> dev packages.
> >>> libgccjit probably could use /proc/self/maps to find the gcc_lib_dir,
> >>> but that
> >>> doesn't seem to be very portable.
> >>>
> >>> Ok for the trunk and the branches?
> >>>
> >>> Matthias
> >>
> >> [CCing the jit list]
> >>
> >> I've been trying to reproduce this bug in a working copy, and failing.
> >>
> >> Matthias, do you have a recipe you've been using to reproduce this?
> >
> > the JIT debug log shows the driver names that it wants to call. Are you sure
> > that this driver isn't available anywhere? I configure the gcc build with
> > --program-suffix=-8 --program-prefix=x86_64-linux-gnu-, and that one was only
> > available in one place, /usr/bin.
> >
> > Matthias
>
> David, the bug report now has two more comments from people that the current
> behavior is broken. Please could you review the patch?
I think libgccjit should use the same strathegy for finding the install location
like the driver does itself. I couldn't readily decipher its magic but at least
there's STANDARD_EXEC_PREFIX which seems to be used as possible
fallback.
In particular your patch doesn't seem to work with a DESTDIR=<path>
install?
Can we instead add a --with-gccjit-install-dir= or sth like that (whatever
path to whatever files the JIT exactly looks for)?
Richard.
> Thanks, Matthias
next prev parent reply other threads:[~2021-07-13 6:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <c35cf6d3-0eab-92fa-458d-2a544b7f9e66@ubuntu.com>
2019-01-01 0:00 ` David Malcolm
2019-01-01 0:00 ` Matthias Klose
2021-07-12 21:00 ` Matthias Klose
2021-07-13 6:41 ` Richard Biener [this message]
2021-07-14 5:42 ` Matthias Klose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc1HqPuoBKWcUw3uzAkPEzgJoPO8hBOW5A4-WG4RRT7mpQ@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=dmalcolm@redhat.com \
--cc=doko@ubuntu.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).