From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26713 invoked by alias); 19 Nov 2014 11:49:52 -0000 Mailing-List: contact jit-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: jit-owner@gcc.gnu.org Received: (qmail 26686 invoked by uid 89); 19 Nov 2014 11:49:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.98.4 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-oi0-f42.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Ss/2kO2XZfsmF8ETQgo+1KBPp8EadWhREsRakVbTxag=; b=efucGX9uOVXuJKYaSLoifYsEnT6sCdes5s0qhu40pOU2oojxTRFqTusQ/70evHLtsH UtcIlj37N4/yQxQ7dy073fS+fUbo6Kh0T3jrDnxneT3Kfm/OJwcKugKGPGDEW7DUwbSy WITbUwp3J8ViptRXkY84RKE6IbAh1fhYRZf3Ta2Q9YYwStO9cDj18/HDQFB48K+yat65 vR0+SwqG1e/H/2dF0hR8kV/wTz9XPg6OvarPjWJTTTa4Cau7PtMqY+Lzf3GnkpKCfSBa fTsK7ANrAvVMUnsHb/MSaQWJGNExWyJZJgepsqujd6h3R2mn0fh9t2NAj2ExHjQYBcRG 4G3A== MIME-Version: 1.0 X-Received: by 10.60.45.132 with SMTP id n4mr35382158oem.26.1416397789428; Wed, 19 Nov 2014 03:49:49 -0800 (PST) In-Reply-To: <1416393981-39626-6-git-send-email-dmalcolm@redhat.com> References: <1416393981-39626-1-git-send-email-dmalcolm@redhat.com> <1416393981-39626-6-git-send-email-dmalcolm@redhat.com> Date: Wed, 01 Jan 2014 00:00:00 -0000 Message-ID: Subject: Re: [PATCH 05/21] PR jit/63854: Fix memory leak of save_decoded_options From: Richard Biener To: David Malcolm Cc: GCC Patches , jit@gcc.gnu.org Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2014-q4/txt/msg00179.txt.bz2 On Wed, Nov 19, 2014 at 11:46 AM, David Malcolm wrote: > This commit fixes this leak from opts-common.c, about 4KB per iteration. Ok. Thanks, Richard. > ==57820== 18,816 (2,560 direct, 16,256 indirect) bytes in 4 blocks are definitely lost in loss record 907 of 917 > ==57820== at 0x4A083AA: realloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) > ==57820== by 0x59A67CC: xrealloc (xmalloc.c:179) > ==57820== by 0x59587C9: decode_cmdline_options_to_array(unsigned int, char const**, unsigned int, cl_decoded_option**, unsigned int*) (opts-common.c:885) > ==57820== by 0x4E2ED90: toplev::main(int, char**) (toplev.c:2089) > ==57820== by 0x4E43186: gcc::jit::playback::context::compile() (jit-playback.c:1615) > ==57820== by 0x4E4018D: gcc::jit::recording::context::compile() (jit-recording.c:861) > ==57820== by 0x401CA4: test_jit (harness.h:190) > ==57820== by 0x401D88: main (harness.h:232) > > gcc/ChangeLog: > PR jit/63854 > * toplev.c (toplev::finalize): Clean up save_decoded_options. > --- > gcc/toplev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gcc/toplev.c b/gcc/toplev.c > index 876279f..291b84d 100644 > --- a/gcc/toplev.c > +++ b/gcc/toplev.c > @@ -2173,6 +2173,8 @@ toplev::finalize (void) > finalize_options_struct (&global_options); > finalize_options_struct (&global_options_set); > > + XDELETEVEC (save_decoded_options); > + > /* Clean up the context (and pass_manager etc). */ > delete g; > g = NULL; > -- > 1.8.5.3 >