From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x241.google.com (mail-oi1-x241.google.com [IPv6:2607:f8b0:4864:20::241]) by sourceware.org (Postfix) with ESMTPS id 130743851C0C; Thu, 11 Jun 2020 22:02:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 130743851C0C Received: by mail-oi1-x241.google.com with SMTP id a137so6898261oii.3; Thu, 11 Jun 2020 15:02:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GI+rn/OHrXOCdLOi0XpDYnpIC3npd+pTZn+RArXNATI=; b=DTIyQcSHeWoNHgfn7DdancbVjCrDTF+A+XFXLATDNloCOjmEfxJP7AiT1OlZtiLAnB vBVENocnzyWmSwextKiAb1OjYj4g0D4n6sL1uQEEiRzM9YnxwwhQSDmEzXJlePYKD9gq 8u40UjYjSxuyolI/qt4bNOZlWRTaY26vtnMTcJVrpPTLzhMm7K+SvE2cAoeqP5cC4Uth ZkqugAwWmXbQQUlolP8URWR821fRrbiFGVN5+ub3dxj4/RHKmSHPVZRXRK6uUtnU292p TovUoh9MmTKvcx1Pn7rul/PGqQBfpfisTLRYojvRRdczMHe5oWxMwRxF/X5T53rCDL/S ZazQ== X-Gm-Message-State: AOAM532gdWYxikN7zyPQJ+KNGKMnvRVsfF2oVqxPngOBo7uGMbtX0uEC 5NmqNdhuUGkxarqAHjfrGE4enKAG1m17PMasvDE= X-Google-Smtp-Source: ABdhPJxuznsXh9VUXyDt3tBRsQSd0X5oRhiSbeOkYLkrsO2UKTmXBVS7JGkAAd/qmM/i5XGlzEDTRZ6o663E08bbj4g= X-Received: by 2002:aca:b742:: with SMTP id h63mr69678oif.65.1591912949463; Thu, 11 Jun 2020 15:02:29 -0700 (PDT) MIME-Version: 1.0 References: <4b619179a08075bd2ee7f9e98aa2d5918191306d.camel@redhat.com> <5de2a5202b50882612e1fe51d254f2b125f61716.camel@redhat.com> <885d0b34df56c30f25c2ba57f4eecf517d1ba05c.camel@redhat.com> <5edb0f517d11a551f622ebb787fc06cd6c06225b.camel@redhat.com> <01bd8894-78f7-47b4-1a38-e062d549450b@gmail.com> <5789e311-e4dd-27c0-f792-fd0929c1216d@gmail.com> In-Reply-To: <5789e311-e4dd-27c0-f792-fd0929c1216d@gmail.com> From: =?UTF-8?Q?Nicolas_B=C3=A9rtolo?= Date: Thu, 11 Jun 2020 19:02:17 -0300 Message-ID: Subject: Re: [PATCH] Port libgccjit to Windows. To: JonY <10walls@gmail.com> Cc: David Malcolm , jit@gcc.gnu.org, gcc-patches@gcc.gnu.org Content-Type: multipart/mixed; boundary="000000000000ddefea05a7d61d58" X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jun 2020 22:02:31 -0000 --000000000000ddefea05a7d61d58 Content-Type: text/plain; charset="UTF-8" Hi, On 6/7/20 11:12 PM, JonY wrote: > Ideally, libtool is used so we get libgccjit-0.dll, unfortunately it is > not. So the only way to ABI version the dll would be to use Unix style > soname to mark when an ABI has changed. I tried generating the library as libgccjit-0.dll and naming its import library libgccjit.dll.a. It worked. I understand you prefer the libgccjit-0.dll filename from this comment about libtool. A patch implementing this change is attached. Thanks for your feedback. Nicolas. --000000000000ddefea05a7d61d58 Content-Type: application/octet-stream; name="0001-Rename-libgccjit.dll-to-libgccjit-0.dll.patch" Content-Disposition: attachment; filename="0001-Rename-libgccjit.dll-to-libgccjit-0.dll.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kbbbu1120 RnJvbSA2MmE2ODI4NjMzOGQ0YmQxZGI0ZDJjNzA3NWM4NWI2YTUzZjVmMTk4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNvbGFzIEJlcnRvbG8gPG5pY29sYXNiZXJ0b2xvQGdtYWls LmNvbT4KRGF0ZTogVHVlLCA5IEp1biAyMDIwIDExOjM3OjUxIC0wMzAwClN1YmplY3Q6IFtQQVRD SF0gUmVuYW1lIGxpYmdjY2ppdC5kbGwgdG8gbGliZ2Njaml0LTAuZGxsLgoKKiBnY2Mvaml0L01h a2UtbGFuZy5pbjogQWx3YXlzIGRlZmluZSB2ZXJzaW9uLCBtaW5vciBhbmQgcmVsZWFzZSBudW1i ZXJzLiBDcmVhdGUKdGhlIFdpbmRvd3Mgc2hhcmVkIGxpYnJhcnkgYXMgbGliZ2Njaml0LSQoTElC R0NDSklUX1ZFUlNJT05fTlVNKS5kbGwuCi0tLQogZ2NjL2ppdC9NYWtlLWxhbmcuaW4gfCAxOCAr KysrKysrKysrLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCA4IGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2djYy9qaXQvTWFrZS1sYW5nLmluIGIvZ2NjL2ppdC9N YWtlLWxhbmcuaW4KaW5kZXggOWNiNzgxNGQ2Li4zYjU0MzkyNmMgMTAwNjQ0Ci0tLSBhL2djYy9q aXQvTWFrZS1sYW5nLmluCisrKyBiL2djYy9qaXQvTWFrZS1sYW5nLmluCkBAIC00MCw4ICs0MCwx MyBAQAogIyBpbnRvIHRoZSBqaXQgcnVsZSwgYnV0IHRoYXQgbmVlZHMgYSBsaXR0bGUgYml0IG9m IHdvcmsKICMgdG8gZG8gdGhlIHJpZ2h0IHRoaW5nIHdpdGhpbiBhbGwuY3Jvc3MuCiAKK0xJQkdD Q0pJVF9WRVJTSU9OX05VTSA9IDAKK0xJQkdDQ0pJVF9NSU5PUl9OVU0gPSAwCitMSUJHQ0NKSVRf UkVMRUFTRV9OVU0gPSAxCisKIGlmbmVxICgsJChmaW5kc3RyaW5nIG1pbmd3LCQodGFyZ2V0KSkp Ci1MSUJHQ0NKSVRfRklMRU5BTUUgPSBsaWJnY2NqaXQuZGxsCitMSUJHQ0NKSVRfRklMRU5BTUUg PSBsaWJnY2NqaXQtJChMSUJHQ0NKSVRfVkVSU0lPTl9OVU0pLmRsbAorTElCR0NDSklUX0lNUE9S VF9MSUIgPSBsaWJnY2NqaXQuZGxsLmEKIAogaml0OiAkKExJQkdDQ0pJVF9GSUxFTkFNRSkgXAog CSQoRlVMTF9EUklWRVJfTkFNRSkKQEAgLTQ5LDkgKzU0LDYgQEAgaml0OiAkKExJQkdDQ0pJVF9G SUxFTkFNRSkgXAogZWxzZQogCiBMSUJHQ0NKSVRfTElOS0VSX05BTUUgPSBsaWJnY2NqaXQuc28K LUxJQkdDQ0pJVF9WRVJTSU9OX05VTSA9IDAKLUxJQkdDQ0pJVF9NSU5PUl9OVU0gPSAwCi1MSUJH Q0NKSVRfUkVMRUFTRV9OVU0gPSAxCiAKIExJQkdDQ0pJVF9TT05BTUUgPSAkKExJQkdDQ0pJVF9M SU5LRVJfTkFNRSkuJChMSUJHQ0NKSVRfVkVSU0lPTl9OVU0pCiBMSUJHQ0NKSVRfRklMRU5BTUUg PSBcCkBAIC0xMDIsOCArMTA0LDggQEAgZW5kaWYKIGppdC13YXJuID0gJChTVFJJQ1RfV0FSTikK IAogaWZuZXEgKCwkKGZpbmRzdHJpbmcgbWluZ3csJCh0YXJnZXQpKSkKLSMgQ3JlYXRlIGltcG9y dCBsaWJyYXJ5IGxpYmdjY2ppdC5kbGwuYQotTElCR0NDSklUX0VYVFJBX09QVFMgPSAtV2wsLS1v dXQtaW1wbGliLCQoTElCR0NDSklUX0ZJTEVOQU1FKS5hCisjIENyZWF0ZSBpbXBvcnQgbGlicmFy eQorTElCR0NDSklUX0VYVFJBX09QVFMgPSAtV2wsLS1vdXQtaW1wbGliLCQoTElCR0NDSklUX0lN UE9SVF9MSUIpCiBlbHNlCiBMSUJHQ0NKSVRfRVhUUkFfT1BUUyA9ICQoTElCR0NDSklUX1ZFUlNJ T05fU0NSSVBUX09QVElPTikgXAogCSQoTElCR0NDSklUX1NPTkFNRV9PUFRJT04pCkBAIC0zMDgs OCArMzEwLDggQEAgaml0Lmluc3RhbGwtaGVhZGVyczoKIGlmbmVxICgsJChmaW5kc3RyaW5nIG1p bmd3LCQodGFyZ2V0KSkpCiBqaXQuaW5zdGFsbC1jb21tb246IGluc3RhbGxkaXJzIGppdC5pbnN0 YWxsLWhlYWRlcnMKICMgSW5zdGFsbCBpbXBvcnQgbGlicmFyeQotCSQoSU5TVEFMTF9QUk9HUkFN KSAkKExJQkdDQ0pJVF9GSUxFTkFNRSkuYSBcCi0JICAkKERFU1RESVIpJChsaWJkaXIpLyQoTElC R0NDSklUX0ZJTEVOQU1FKS5hCisJJChJTlNUQUxMX1BST0dSQU0pICQoTElCR0NDSklUX0lNUE9S VF9MSUIpIFwKKwkgICQoREVTVERJUikkKGxpYmRpcikvJChMSUJHQ0NKSVRfSU1QT1JUX0xJQikK ICMgSW5zdGFsbCBETEwgZmlsZQogCSQoSU5TVEFMTF9QUk9HUkFNKSAkKExJQkdDQ0pJVF9GSUxF TkFNRSkgXAogCSAgJChERVNURElSKSQoYmluZGlyKS8kKExJQkdDQ0pJVF9GSUxFTkFNRSkKLS0g CjIuMjUuMS53aW5kb3dzLjEKCg== --000000000000ddefea05a7d61d58--