From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-4317.proton.ch (mail-4317.proton.ch [185.70.43.17]) by sourceware.org (Postfix) with ESMTPS id A517A3858C60; Mon, 24 Jul 2023 09:17:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A517A3858C60 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=lorenzosalvadore.it Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lorenzosalvadore.it Date: Mon, 24 Jul 2023 09:17:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lorenzosalvadore.it; s=protonmail2; t=1690190229; x=1690449429; bh=AIJFbO44qFeejllzd7IFICkEiJEkZX3V+e+VYnPx7J4=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=DfB3dWr06PJsvySVpWX/0BLMvwdhM7bTkm4VsVOV8dp6y5y/ajud4cZiIf9lWYkjk DEClChIo4CG3CUSnAdE/QWyRhZMGYt5LcKnnsIdom3ES1PQ4knwzNv4jKVeV80iCCd QLkURTxgdNA4h4qakzHxNA/YDIg1t0wepxpHg/gJDd1N/1CYkjs7m18IAVZytqxOyE QzOxlcESkF7/UVoIbyweCSyfSF1FaYyPQd8l/rwVbrb95uLFtgTNPiH3oewRXF/F/I 1XfGZmB01evCh2Nv0oKMa69D9cXPxpQidH8sly2MSrhIxNhD4gOayioxxmHZyiB0s4 4ETF8Xb/HYeng== To: "gcc-patches@gcc.gnu.org" From: Lorenzo Salvadore Cc: "jit@gcc.gnu.org" , "dmalcolm@redhat.com" , "richard.guenther@gmail.com" , Gerald Pfeifer Subject: Re: Ping^9: [PATCH] jit: Install jit headers in $(libsubincludedir) [PR 101491] Message-ID: In-Reply-To: References: =?us-ascii?Q?_<2hPJROSKr12LUbj75IdxapgudFJ3K=5FIi-S5WL7QSTmsACnLn2QkK1SVORwMSoBgC5CC1f9kzo03CBBc7wJ3Nw5whwLkrghpWU7s1Z37RyUg=3D@lorenzosalvadore.it>_<0CzquyLGP5hhA=5FcGQAlhaxq-jewz1JR0MRfMqOxmVReSdjkmSJazgi59Zok5D028q7GD0XIvlCRGdtU9nQYnWv1zk9EkmACks2BEobo3QrE=3D@lorenzosalvadore.it>_____?= Feedback-ID: 53711648:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, Ping https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606450.html I am pinging this since November, if this patch has something wrong please just tell me so that I can fix it. The PR is still open. Thanks, Lorenzo Salvadore > From f8e2c2ee89a7d8741bb65163d1f1c20edcd546ac Mon Sep 17 00:00:00 2001 > From: Lorenzo Salvadore developer@lorenzosalvadore.it >=20 > Date: Wed, 16 Nov 2022 11:27:38 +0100 > Subject: [PATCH] jit: Install jit headers in $(libsubincludedir) [PR 1014= 91] >=20 > Installing jit/libgccjit.h and jit/libgccjit++.h headers in > $(includedir) can be a problem for machines where multiple versions of > GCC are required simultaneously, see for example this bug report on > FreeBSD: >=20 > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D257060 >=20 > Hence, >=20 > - define $(libsubincludedir) the same way it is defined in libgomp; > - install jit/libgccjit.h and jit/libgccjit++.h in $(libsubincludedir). >=20 > The patch has already been applied successfully in the official FreeBSD > ports tree for the ports lang/gcc11 and lang/gcc12. Please see the > following commits: >=20 > https://cgit.freebsd.org/ports/commit/?id=3D0338e04504ee269b7a95e6707f131= 4bc1c4239fe > https://cgit.freebsd.org/ports/commit/?id=3Df1957296ed2dce8a09bb9582e9a5a= 715bf8b3d4d >=20 > gcc/ChangeLog: >=20 > 2022-11-16 Lorenzo Salvadore developer@lorenzosalvadore.it >=20 > PR jit/101491 > * Makefile.in: Define and create $(libsubincludedir) >=20 > gcc/jit/ChangeLog: >=20 > 2022-11-16 Lorenzo Salvadore developer@lorenzosalvadore.it >=20 > PR jit/101491 > * Make-lang.in: Install headers in $(libsubincludedir) > --- > gcc/Makefile.in | 3 +++ > gcc/jit/Make-lang.in | 4 ++-- > 2 files changed, 5 insertions(+), 2 deletions(-) >=20 > diff --git a/gcc/Makefile.in b/gcc/Makefile.in > index f672e6ea549..3bcf1c491ab 100644 > --- a/gcc/Makefile.in > +++ b/gcc/Makefile.in > @@ -635,6 +635,8 @@ libexecdir =3D @libexecdir@ >=20 > # Directory in which the compiler finds libraries etc. > libsubdir =3D $(libdir)/gcc/$(real_target_noncanonical)/$(version)$(accel= _dir_suffix) > +# Directory in which the compiler finds headers. > +libsubincludedir =3D $(libdir)/gcc/$(target_alias)/$(version)/include > # Directory in which the compiler finds executables > libexecsubdir =3D $(libexecdir)/gcc/$(real_target_noncanonical)/$(version= )$(accel_dir_suffix) > # Directory in which all plugin resources are installed > @@ -3642,6 +3644,7 @@ install-cpp: installdirs cpp$(exeext) > # $(libdir)/gcc/include isn't currently searched by cpp. > installdirs: > $(mkinstalldirs) $(DESTDIR)$(libsubdir) > + $(mkinstalldirs) $(DESTDIR)$(libsubincludedir) > $(mkinstalldirs) $(DESTDIR)$(libexecsubdir) > $(mkinstalldirs) $(DESTDIR)$(bindir) > $(mkinstalldirs) $(DESTDIR)$(includedir) > diff --git a/gcc/jit/Make-lang.in b/gcc/jit/Make-lang.in > index 248ec45b729..ba1b3e95da5 100644 > --- a/gcc/jit/Make-lang.in > +++ b/gcc/jit/Make-lang.in > @@ -360,9 +360,9 @@ selftest-jit: > # Install hooks: > jit.install-headers: installdirs > $(INSTALL_DATA) $(srcdir)/jit/libgccjit.h \ > - $(DESTDIR)$(includedir)/libgccjit.h > + $(DESTDIR)$(libsubincludedir)/libgccjit.h > $(INSTALL_DATA) $(srcdir)/jit/libgccjit++.h \ > - $(DESTDIR)$(includedir)/libgccjit++.h > + $(DESTDIR)$(libsubincludedir)/libgccjit++.h >=20 > ifneq (,$(findstring mingw,$(target))) > jit.install-common: installdirs jit.install-headers > -- > 2.38.0