From: Bernd Edlinger <bernd.edlinger@hotmail.de>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
David Malcolm <dmalcolm@redhat.com>, Jeff Law <law@redhat.com>,
Richard Biener <rguenther@suse.de>,
"jit@gcc.gnu.org" <jit@gcc.gnu.org>
Subject: [PING**3] [PATCH] Fix not properly nul-terminated string constants in JIT
Date: Mon, 01 Jan 2018 00:00:00 -0000 [thread overview]
Message-ID: <VI1PR0701MB2862A4061A479455C7138989E4CE0@VI1PR0701MB2862.eurprd07.prod.outlook.com> (raw)
In-Reply-To: <VI1PR0701MB2862328DA3BF03E662E1AE7DE4E00@VI1PR0701MB2862.eurprd07.prod.outlook.com>
Ping...
On 10/10/18 9:43 PM, Bernd Edlinger wrote:
> Ping...
>
>
> On 08/26/18 21:40, Bernd Edlinger wrote:
>> Ping...
>>
>> This is just plain wrong, independent
>> of any STRING_CST semantic issues.
>>
>> The original patch (retested on current trunk) is
>> here: https://gcc.gnu.org/ml/gcc-patches/2018-08/msg00370.html
>>
>>
>> On 08/05/18 18:59, Bernd Edlinger wrote:
>>> Hi!
>>>
>>>
>>> My other patch with adds assertions to varasm.c regarding correct
>>> nul termination of sting literals did make these incorrect string
>>> constants in JIT frontend fail.
>>>
>>> The string constants are not nul terminated if their length exceeds
>>> 200 characters. The test cases do not use strings of that size where
>>> that would make a difference. But using a fixed index type is clearly
>>> wrong.
>>>
>>> This patch removes the fixed char[200] array type from playback::context,
>>> and uses build_string_literal instead of using build_string directly.
>>>
>>>
>>> Bootstrapped and reg-tested on x86_64-pc-linux-gnu.
>>> Is it OK for trunk?
>>>
>>>
>>> Thanks
>>> Bernd.
next parent reply other threads:[~2018-11-01 15:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AM5PR0701MB2657D814EBE588723929D667E4210@AM5PR0701MB2657.eurprd07.prod.outlook.com>
[not found] ` <AM5PR0701MB265792CD3DD0EF032E5E7C77E4340@AM5PR0701MB2657.eurprd07.prod.outlook.com>
[not found] ` <VI1PR0701MB2862328DA3BF03E662E1AE7DE4E00@VI1PR0701MB2862.eurprd07.prod.outlook.com>
2018-01-01 0:00 ` Bernd Edlinger [this message]
[not found] ` <1541191232.14521.323.camel@redhat.com>
[not found] ` <VI1PR0701MB2862B729AB712F93047C3E42E4CF0@VI1PR0701MB2862.eurprd07.prod.outlook.com>
[not found] ` <VI1PR0701MB2862D5791A08BFF23037C888E4C60@VI1PR0701MB2862.eurprd07.prod.outlook.com>
2019-01-01 0:00 ` Bernd Edlinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0701MB2862A4061A479455C7138989E4CE0@VI1PR0701MB2862.eurprd07.prod.outlook.com \
--to=bernd.edlinger@hotmail.de \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
--cc=law@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).