From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sender3-of-o90.zoho.com (sender3-of-o90.zoho.com [136.143.184.90]) by sourceware.org (Postfix) with ESMTPS id E81F13858400; Wed, 29 Dec 2021 22:46:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E81F13858400 ARC-Seal: i=1; a=rsa-sha256; t=1640817961; cv=none; d=zohomail.com; s=zohoarc; b=nn5wHWxuJrLpzznxpTSDm4rWhNARh3H1fO+MJK5p4tOITscQwcSc5Y+282uIGDy9vqhGqag4GSoJTcinOq5Wvz6XPyNChAe6GwodxOyQMwskcmplIohlKxrYKwxFtoOMjidGYpuBGkenVIPf/j/vd2aK7CTLSCIGGrjG3wPgTPM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1640817961; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=UTcCQZFz0h6lDwZoGjs26wsvNslsp/HAP3iHQ9PpVZU=; b=KACS79oWbqq6AfhefByDKAdjAo3Du2l4v6POK6xqGXIXRHjTD9w5DVm4y7f2vtgB3MTiSWzACShIFD30gcthddqtr0b7umFOsaLTYd0fYKrNvrSUv7TvcbpU/38oWQJdGbbkxUQXnD90K8qhNJXGay/MyhzpE/wmccR3gG5NcWY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zoho.com; spf=pass smtp.mailfrom=bouanto@zoho.com; dmarc=pass header.from= Received: from [192.168.1.174] (38.87.11.6 [38.87.11.6]) by mx.zohomail.com with SMTPS id 1640817960649548.843700614483; Wed, 29 Dec 2021 14:46:00 -0800 (PST) Message-ID: Subject: Re: [commited] jit: Support for global rvalue initialization and constructors From: Antoni Boucher To: Petter Tomner , David Malcolm , "jit@gcc.gnu.org" , "gcc-patches@gcc.gnu.org" Date: Wed, 29 Dec 2021 17:45:59 -0500 In-Reply-To: <54a63e2ec8954573939d4dcad7d3ae12@kth.se> References: <8c135550d44f43b9b80c2a3a50939128@kth.se> ,<95b9504a2c0f8d255105a278b04a3dcb6cb5dc4e.camel@zoho.com> <54a63e2ec8954573939d4dcad7d3ae12@kth.se> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Dec 2021 22:46:11 -0000 I realized that trying to do an assignment to an array created by the new array constructor API will result in a "gimplification failed" error: libgccjit.so: error: gimplification failed 0x7fa3a441e5d3 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int) ../../../gcc/gcc/gimplify.c:15964 0x7fa3a442b1ab gimplify_modify_expr ../../../gcc/gcc/gimplify.c:5975 0x7fa3a441ac4c gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int) ../../../gcc/gcc/gimplify.c:14951 0x7fa3a441e63c gimplify_stmt(tree_node**, gimple**) ../../../gcc/gcc/gimplify.c:7026 0x7fa3a441bca3 gimplify_statement_list ../../../gcc/gcc/gimplify.c:2014 0x7fa3a441bca3 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int) ../../../gcc/gcc/gimplify.c:15396 0x7fa3a441e63c gimplify_stmt(tree_node**, gimple**) ../../../gcc/gcc/gimplify.c:7026 0x7fa3a441f000 gimplify_bind_expr ../../../gcc/gcc/gimplify.c:1427 0x7fa3a441adc6 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*), int) ../../../gcc/gcc/gimplify.c:15152 0x7fa3a441e63c gimplify_stmt(tree_node**, gimple**) ../../../gcc/gcc/gimplify.c:7026 0x7fa3a4420671 gimplify_body(tree_node*, bool) ../../../gcc/gcc/gimplify.c:16197 0x7fa3a4420b3c gimplify_function_tree(tree_node*) ../../../gcc/gcc/gimplify.c:16351 0x7fa3a419fe5e gcc::jit::playback::function::postprocess() ../../../gcc/gcc/jit/jit-playback.c:1909 0x7fa3a41a13dc gcc::jit::playback::context::replay() ../../../gcc/gcc/jit/jit-playback.c:3250 Should an assignment to such a value be supported? Le mercredi 15 d=C3=A9cembre 2021 =C3=A0 19:19 +0000, Petter Tomner a =C3= =A9crit=C2=A0: > Oh ye I accidentally dropped that in the merge thank you. >=20 > I believe there is an implicit "global:" in the top of each version > scope, so it shouldn't > matter other than looking a bit deviant. >=20 > Regards, > Petter >=20 > Fr=C3=A5n: Antoni Boucher > Skickat: den 15 december 2021 15:19 > Till: Petter Tomner; David Malcolm; jit@gcc.gnu.org; > gcc-patches@gcc.gnu.org > =C3=84mne: Re: [commited] jit: Support for global rvalue initialization > and constructors > =C2=A0=C2=A0=C2=A0=20 > Hi Petter. > I believe you have forgotten the line `global:` in the file > `gcc/jit/libgccjit.map`. > I'm not sure what this line does, but it is there for all other ABI. > David: What do you think? > Regards. >=20 > Le mardi 14 d=C3=A9cembre 2021 =C3=A0 17:22 +0000, Petter Tomner via Jit = a > =C3=A9crit=C2=A0: > > Hi! > >=20 > > I have pushed the patch for rvalue initialization and ctors for > > libgccjit, for ABI 19. > >=20 > > Please see attached patch. > >=20 > > Regards, > > Petter > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=20 >=20 > =C2=A0=C2=A0=C2=A0=20