From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 897F2393A002 for ; Thu, 8 Jul 2021 21:34:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 897F2393A002 Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-255-Zn5b4Li3OCq6YiWao49jwg-1; Thu, 08 Jul 2021 17:34:44 -0400 X-MC-Unique: Zn5b4Li3OCq6YiWao49jwg-1 Received: by mail-qk1-f200.google.com with SMTP id j6-20020a37c2460000b02903b55e9da892so4810077qkm.5 for ; Thu, 08 Jul 2021 14:34:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=1ENwCRMWRInxeUhzHo0iWuETSgFw7A8gILedqOQEhXY=; b=BTx0x5/CKZ1/u0MHCNHB84PAjWhCq2i9hSVeBBp1yZWSW3EWMyQ7kd7FRpzujF2aro 8fy6F0Sdk4CJ/HbQ83s0cnHwYzvUZ9DKIpT6ygNygjoQ3ifHAaGAESlqBTQOws6gRLhc DQZk789tM1g2noF0c1rtaDEKi0Yo28dXtSo8Y7Tl+UevE/LwcOgsvMqJ8SSn7+rkyW7J sQ481wyEX3lzc1/79bY2TUrerVRIUHpHJtYnZlDdzFWgHs7haoiH1JRXZQyzbKCU7guj PwmIC+QQb5hpsCxlF2/FHIrMrkA+cR6n0sFbHXdlZFnG6+5bNnvFVy2hWGuXTATOIeB3 1OEg== X-Gm-Message-State: AOAM530XySvWicEbRxTlJayMCwbQnRAzZnOY/TfOS/9yiABVo41kfeX9 gUWaUHtXH7XRbLVBHgYy7Xibt2mDqLpEl7d26gfdhqYi0ZBAw24xKZkIcrcj8uKjgqZf/LPqGpt h3KLSEas= X-Received: by 2002:a05:622a:1192:: with SMTP id m18mr17580841qtk.369.1625780083688; Thu, 08 Jul 2021 14:34:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzsuIGGxfOq+JKOw5sVq8C+oFZCBukkxndGzeNyT66XS/LUiNgVH989OqJ11iOYZrLrfaj5YA== X-Received: by 2002:a05:622a:1192:: with SMTP id m18mr17580829qtk.369.1625780083474; Thu, 08 Jul 2021 14:34:43 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.nh.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id u12sm1495694qkk.123.2021.07.08.14.34.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jul 2021 14:34:43 -0700 (PDT) Message-ID: Subject: Re: [PATCH] libgccjit: Handle truncation and extension for casts [PR 95498] From: David Malcolm To: Antoni Boucher , Bernhard Reutner-Fischer Cc: jit@gcc.gnu.org Date: Thu, 08 Jul 2021 17:34:42 -0400 In-Reply-To: References: <20200713003002.bs5hwv4gav6ml5rt@bouanto-laptop.localdomain> <874ki6txcc.fsf@tromey.com> <20210220221706.ewfq2b3i2mzx4ice@bouanto-desktop.localdomain> <3ae55b5acc33b38c579ac9c293993c29adc55ae9.camel@redhat.com> <597ecec1c91c1176f740796e20432372377aa554.camel@redhat.com> <0f7f2bf386c29efa1403020cbb02bec815ce25fe.camel@zoho.com> <651ead30f4fa016c233c203bd5d3e749273ab92b.camel@redhat.com> <8d782bf220cc81c727f842b21d835b5b991d3a35.camel@zoho.com> <1f12388082367de4e8d2ea8fe802c22efd50c109.camel@redhat.com> <4834aac911b9fc1f58d0e9cea8773775aad2a23e.camel@zoho.com> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jul 2021 21:34:46 -0000 On Thu, 2021-07-08 at 17:28 -0400, Antoni Boucher wrote: > Is this the approval for write or are we not there yet? Assuming it passes the regression tests, yes - approved for trunk. Dave > > Le jeudi 08 juillet 2021 à 16:44 -0400, David Malcolm a écrit : > > On Tue, 2021-07-06 at 09:00 -0400, Antoni Boucher wrote: > > > I updated the patch to fix this. > > > I'm sending the patch once again for review. > > > Thanks. > > > > Looks good to me. > > > > Dave > > > > > > > > Le samedi 19 juin 2021 à 11:08 +0200, Bernhard Reutner-Fischer a > > > écrit : > > > > On 18 June 2021 23:11:58 CEST, Antoni Boucher via Gcc-patches > > > > wrote: > > > > > Ok. > > > > > Here's the patch with the updated subject and with format > > > > > fixed. > > > > > > > > +  if (t_ret) > > > > +      return t_ret; > > > > +  enum tree_code dst_code = TREE_CODE (dst_type); > > > > +  switch (dst_code) > > > > +    { > > > > > > > > The enum is redundant. > > > > /enum tree_code/s/enum // > > > > thanks, > > > > > > > > >