From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sender4-pp-o90.zoho.com (sender4-pp-o90.zoho.com [136.143.188.90]) by sourceware.org (Postfix) with ESMTPS id EDC723858434; Thu, 22 Feb 2024 20:29:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EDC723858434 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=zoho.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=zoho.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EDC723858434 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=136.143.188.90 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1708633792; cv=pass; b=pCenYc3GmF+2Ca6LwmpKNYgSE/zRdlbIRuhD1D9xi5+WNeA/wED/oNNOqQB8lM/Glit79RXOJ434GWlST2+g9tug221ECsKrixUrolRI1JsxY79fd/OUthXcakGPRgk9plas5Xi3CHGRoM+Wno67FHw5qctPiu4iL1Iz5f3OkVU= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1708633792; c=relaxed/simple; bh=ZjbS7cJ2UMuMTndLoscfM49EROOAlOfFG7hECypw7Ng=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=MlLpu8HAq8/qfDpttMjZwDLL5Y7/ny2hN6RjuKIK35eqCQDTzLCv5bFp38txCkKe/79zmWLj7W5A8q4/60ZBfwsscsUJ9jQ479XDIEKG2K7NfPZbDEas+WyMRwhDEaDlPs63Wv4qZFGpan92gZM1ZSRlt7WJOYgXXLl4EEKBORE= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; t=1708633786; cv=none; d=zohomail.com; s=zohoarc; b=gfLsn/rLfsmA2GN6I/YXO+q1ihZFtgY1y14rCuiRraYb/l4EL2yEFHBzmPgsRgyHBBYLU6jwq1NApX6u5ljJQ9EXs3Eopgoc1x3zT0lC0VHtk4+ONqcaGSbOuXp7K1mm35E1ZgOhqdnvXpII8+fQEjxls7pZKgBunDnPXchUpCQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1708633786; h=Content-Type:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=o9rDKx+yfApB4J3lK2njNHzel/BbzwIXVRJKDkvEb5g=; b=EJw/VNN447En5l8vpAvEVGliFR9+XGum+pst1lL2EtWLL34WQHpxcT9Poql+zsd8hByUw4L/+vTUB2Slll+/yKPhGF8yIeHotTLPkty556S/IiYpX36vrecLJHs+cxQbnvWbvt26N4ZyGeL+fK00zQbaDKzTxHw3cly4T4zQWnQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zoho.com; spf=pass smtp.mailfrom=bouanto@zoho.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1708633786; s=zm2022; d=zoho.com; i=bouanto@zoho.com; h=Message-ID:Subject:Subject:From:From:To:To:Date:Date:In-Reply-To:References:Content-Type:MIME-Version:Feedback-ID:Message-Id:Reply-To:Cc; bh=o9rDKx+yfApB4J3lK2njNHzel/BbzwIXVRJKDkvEb5g=; b=PKNk5N+oJeNfH7mE7A6ea7wtP2mZF7cbK5F9y136WHnwu0SNObgyHSO/6NHoO2F8 EUhk2lh4JtyHRgrQ3YbrO+RgN1Ukls2gBmzcEEJB6qYXUiHGiQcautW5bZ7ao7LUUU2 z3UvwqFtI63/FqrX3F+vZqByPaG070A9EbcxBcW0= Received: from [192.168.1.172] (38.87.11.6 [38.87.11.6]) by mx.zohomail.com with SMTPS id 170863378494970.22780231991487; Thu, 22 Feb 2024 12:29:44 -0800 (PST) Message-ID: Subject: Re: [PATCH] libgccjit: Support signed char flag From: Antoni Boucher To: David Malcolm , "jit@gcc.gnu.org" , "gcc-patches@gcc.gnu.org" Date: Thu, 22 Feb 2024 15:29:43 -0500 In-Reply-To: <74e66bf566ded48ecc2f7cc4e55bf8b92efdd5b2.camel@redhat.com> References: <455400c598a6a9e0932c4c5b15c5d8fc30355ade.camel@zoho.com> <74e66bf566ded48ecc2f7cc4e55bf8b92efdd5b2.camel@redhat.com> Autocrypt: addr=bouanto@zoho.com; prefer-encrypt=mutual; keydata=mQENBFOSMLQBCADO5aw6Ys8thMQUNzrwAnfJX2wbgWiz0pQ01DjYj22eeIpChkoZn6LWdt4dieq30u2rFi/yQzJ02foHwI2+aL9rU6xz/x4TwqyRJQGMOqklNc3R+pdXmH4WDQkQDWmLxvc07vu+zb8Tx5A6pMDh4J2ncCEhLEUcH39Yq/yg4eBnFwUX6N7kakvHrnScGNqhnSFCacoJeMJUAR+1G7VBSBd++jmnHLnx3mj7QkRZVECJUw2zqiv1yReCC6GU4SvqLjdqm5ZGeoWOqD/NHjBRoEeOVjzp6M/qOjjWRbkJVqmvgfcD8UytSSqqboR35YFT4L+rZt2ri3T12MJb3i5syCAXABEBAAG0IUFudG9uaSBCb3VjaGVyIDxib3VhbnRvQHpvaG8uY29tPokBVgQTAQgAQAIbIwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAFiEEOELC4Uw1Jeb66YE6RVeGAwR4zcEFAlz4QM4FCRLMEZoACgkQRVeGAwR4zcFBQQf/afttJrA/puADQZhrDfkgr0MFvq6iB+GCy1b8BkXimk1TOXTPt87YLehSeijNu3JkYhl5eRc87BNfU9J87KfI/KIy6hZxqlDXk16FhW9bw/7wYEA0hpb3MUn7xLElXDT0ZHaD+KTe8Oun7qfzgx5RlL6r/WODf3CkSpO085R/rfeBqDEx9mVlhDWgq6Az3CZoD+3CqiCKVqmDuHTWz4kwrd9AM5eVcLvvLKnZIdoIp+G5Ao6BvaGlZyfenN1iOSjLy2NXNt4MnUt0lUYEP5KSIIRhHQ8xkUbj7eWUmaahkxhNb3fH3sAPwGnRZrPpb4rgYzNmSk63wWMh9M2xk+rLb7kBDQRTkjC0AQgAumZzsAV/UFWI+dpzebQfma36kKYZZFuseant5sq/HWP553XQ/U6ttJiKyN5MpCqtxvCAoRplf42YhlHuFqgf73WJxoJ6Y+sdyqoBSwlR+ gzAneAmsa8gmmY0wawH0Z2leazjKuS7mJjVEQZg0ZGsiCVRGeRnDqFGzDEzDc9ngWKSoTq0fKzlGy1X85OrtmUrvEbhSo6HP+FoeunHkIqrxu3w3vDoFEXxVQlKI6V3I4nCz5n6DB8WR3L7nsiiTnOiGirPw1ngvWFLW86kkA4FJpayc8Xl3va3SLY+2y4yuROboX2DVI4AC/Qeug/mDiBicPxkP6YfUartQRMe6obkEQARAQABiQE8BBgBCAAmAhsMFiEEOELC4Uw1Jeb66YE6RVeGAwR4zcEFAlz4QRsFCRLMEecACgkQRVeGAwR4zcE56ggAgTgrJInBKC+7552Dpccuo6Clh3wZfjlNLv9/6r5lKEbaNzaTrfhPiAP4WgnluIUmj8amOFLFJpj+BAVNOXpZ4D2R3o9ch8z7fot+fW4Yw+PKIxH4I2xEys8ndoEB3aiQwHjKcGIhkIU7uyMJFQr2aWjdTY0gmXw0YZueHOSLgo7uX4XKxB8fEO/yto/Tff2YBAAq+AtNwt+Gh5YS9rZw7rwUTWMi84yVOlc+zRE79E9NJkvdTwX7IJYo64VzIRNfgHsn7QNdVzuM1XIFHl+Glk6cIlI8s6BO7nEoCn3hTF104fQTAO3fEs+XXZOKXo2lk8faowEoPq5r58StrV0nyg== Content-Type: multipart/mixed; boundary="=-O01CfPnF1TugvK09CP2I" User-Agent: Evolution 3.50.3 MIME-Version: 1.0 X-Zoho-Virus-Status: 1 X-Zoho-AV-Stamp: zmail-av-1.1.0/208.621.69 Feedback-ID: rr0801122867ac21709515a29187baea7d000043f8421847cf5d6326972b92f0316a3629ad9ff3ebbb6aa8dd42:zu0801122658df30ba02f4302d28583ede000014c28deba676001cc5cbc67c278a885a7b2ad6bd35d86dc2:rf080112310104146134ddf25ad013af450000635ca5230a48b98bbf3c6f52a6dfe58e5c7410c76354eed59077ce711b015e32ec208d:ZohoMail X-ZohoMailClient: External X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-O01CfPnF1TugvK09CP2I Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks for the review and idea. Here's the updated patch. I added a test, but I could not set -fsigned- char as this is not an option accepted by the jit frontend. However, the test still works in the sense that it fails without this patch and passes with it. I'm just wondering if it would pass on all targets or if I should add a target filtering directive to only execute on some target. What do you think? On Tue, 2024-01-09 at 11:01 -0500, David Malcolm wrote: > On Thu, 2023-12-21 at 08:42 -0500, Antoni Boucher wrote: > > Hi. > > This patch adds support for the -fsigned-char flag. >=20 > Thanks.=C2=A0 The patch looks correct to me. >=20 > > I'm not sure how to test it since I stumbled upon this bug when I > > found > > this other bug > > (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D107863) > > which is now fixed. > > Any idea how I could test this patch? >=20 > We already document that GCC_JIT_TYPE_CHAR has "some signedness".=C2=A0 > The > bug being fixed here is that gcc_jit_context compilations were always > treating "char" as unsigned, regardless of the value of -fsigned-char > (either from the target's default, or as a context option), when it > makes more sense to follow the C frontend's behavior. >=20 > So perhaps jit-written code with a context that has -fsigned-char as > an > option (via gcc_jit_context_add_command_line_option), and which > promotes a negative char to a signed int, and then returns the result > as an int?=C2=A0 Presumably if we're erroneously forcing "char" to be > unsigned, the int will be in the range 0x80 to 0xff, rather that > being > negative. >=20 > Dave >=20 --=-O01CfPnF1TugvK09CP2I Content-Disposition: attachment; filename="0001-libgccjit-Support-signed-char-flag.patch" Content-Type: text/x-patch; name="0001-libgccjit-Support-signed-char-flag.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSA1N2Q0YmQ2OTViY2IxNmM1NGVjYmUwNTM0NjI4MmY1ZGMyNzBjMzBhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmkgQm91Y2hlciA8Ym91YW50b0B6b2hvLmNvbT4KRGF0 ZTogTW9uLCAzIE9jdCAyMDIyIDE5OjExOjM5IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gbGliZ2Nj aml0OiBTdXBwb3J0IHNpZ25lZCBjaGFyIGZsYWcKCmdjYy9qaXQvQ2hhbmdlTG9nOgoKCSogZHVt bXktZnJvbnRlbmQuY2MgKGppdF9sYW5naG9va19pbml0KTogU2VuZCBmbGFnX3NpZ25lZF9jaGFy Cglhcmd1bWVudCB0byBidWlsZF9jb21tb25fdHJlZV9ub2Rlcy4KCmdjYy90ZXN0c3VpdGUvQ2hh bmdlTG9nOgoKCSogaml0LmRnL2FsbC1ub24tZmFpbGluZy10ZXN0cy5oOiBBZGQgdGVzdC1zaWdu ZWQtY2hhci5jLgoJKiBqaXQuZGcvdGVzdC1zaWduZWQtY2hhci5jOiBOZXcgdGVzdC4KLS0tCiBn Y2Mvaml0L2R1bW15LWZyb250ZW5kLmNjICAgICAgICAgICAgICAgICAgICB8ICAyICstCiBnY2Mv dGVzdHN1aXRlL2ppdC5kZy9hbGwtbm9uLWZhaWxpbmctdGVzdHMuaCB8IDEwICsrKysKIGdjYy90 ZXN0c3VpdGUvaml0LmRnL3Rlc3Qtc2lnbmVkLWNoYXIuYyAgICAgIHwgNTIgKysrKysrKysrKysr KysrKysrKysKIDMgZmlsZXMgY2hhbmdlZCwgNjMgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigt KQogY3JlYXRlIG1vZGUgMTAwNjQ0IGdjYy90ZXN0c3VpdGUvaml0LmRnL3Rlc3Qtc2lnbmVkLWNo YXIuYwoKZGlmZiAtLWdpdCBhL2djYy9qaXQvZHVtbXktZnJvbnRlbmQuY2MgYi9nY2Mvaml0L2R1 bW15LWZyb250ZW5kLmNjCmluZGV4IGRiZWVhY2QxN2E4Li5kYzEzNDdiNzE0YSAxMDA2NDQKLS0t IGEvZ2NjL2ppdC9kdW1teS1mcm9udGVuZC5jYworKysgYi9nY2Mvaml0L2R1bW15LWZyb250ZW5k LmNjCkBAIC0xMDI5LDcgKzEwMjksNyBAQCBqaXRfbGFuZ2hvb2tfaW5pdCAodm9pZCkKICAgZGlh Z25vc3RpY19zdGFydGVyIChnbG9iYWxfZGMpID0gaml0X2JlZ2luX2RpYWdub3N0aWM7CiAgIGRp YWdub3N0aWNfZmluYWxpemVyIChnbG9iYWxfZGMpID0gaml0X2VuZF9kaWFnbm9zdGljOwogCi0g IGJ1aWxkX2NvbW1vbl90cmVlX25vZGVzIChmYWxzZSk7CisgIGJ1aWxkX2NvbW1vbl90cmVlX25v ZGVzIChmbGFnX3NpZ25lZF9jaGFyKTsKIAogICBidWlsZF9jb21tb25fYnVpbHRpbl9ub2RlcyAo KTsKIApkaWZmIC0tZ2l0IGEvZ2NjL3Rlc3RzdWl0ZS9qaXQuZGcvYWxsLW5vbi1mYWlsaW5nLXRl c3RzLmggYi9nY2MvdGVzdHN1aXRlL2ppdC5kZy9hbGwtbm9uLWZhaWxpbmctdGVzdHMuaAppbmRl eCAxNGEwYTMyMTU1MC4uNDA0Mzc3YTRkZjAgMTAwNjQ0Ci0tLSBhL2djYy90ZXN0c3VpdGUvaml0 LmRnL2FsbC1ub24tZmFpbGluZy10ZXN0cy5oCisrKyBiL2djYy90ZXN0c3VpdGUvaml0LmRnL2Fs bC1ub24tZmFpbGluZy10ZXN0cy5oCkBAIC0zNTMsNiArMzUzLDEzIEBACiAvKiB0ZXN0LXNldHRp bmctYWxpZ25tZW50LmM6IFRoaXMgY2FuJ3QgYmUgaW4gdGhlIHRlc3RjYXNlcyBhcnJheSBhcyBp dAogICAgaXMgdGFyZ2V0LXNwZWNpZmljLiAgKi8KIAorLyogdGVzdC1zaWduZWQtY2hhci5jICov CisjZGVmaW5lIGNyZWF0ZV9jb2RlIGNyZWF0ZV9jb2RlX3NpZ25lZF9jaGFyCisjZGVmaW5lIHZl cmlmeV9jb2RlIHZlcmlmeV9jb2RlX3NpZ25lZF9jaGFyCisjaW5jbHVkZSAidGVzdC1zaWduZWQt Y2hhci5jIgorI3VuZGVmIGNyZWF0ZV9jb2RlCisjdW5kZWYgdmVyaWZ5X2NvZGUKKwogLyogdGVz dC1zaXplb2YuYyAqLwogI2RlZmluZSBjcmVhdGVfY29kZSBjcmVhdGVfY29kZV9zaXplb2YKICNk ZWZpbmUgdmVyaWZ5X2NvZGUgdmVyaWZ5X2NvZGVfc2l6ZW9mCkBAIC01NjAsNiArNTY3LDkgQEAg Y29uc3Qgc3RydWN0IHRlc3RjYXNlIHRlc3RjYXNlc1tdID0gewogICB7InJlZmxlY3Rpb24iLAog ICAgY3JlYXRlX2NvZGVfcmVmbGVjdGlvbiAsCiAgICB2ZXJpZnlfY29kZV9yZWZsZWN0aW9uIH0s CisgIHsic2lnbmVkLWNoYXIiLAorICAgY3JlYXRlX2NvZGVfc2lnbmVkX2NoYXIsCisgICB2ZXJp ZnlfY29kZV9zaWduZWRfY2hhcn0sCiAgIHsic2l6ZW9mIiwKICAgIGNyZWF0ZV9jb2RlX3NpemVv ZiwKICAgIHZlcmlmeV9jb2RlX3NpemVvZn0sCmRpZmYgLS1naXQgYS9nY2MvdGVzdHN1aXRlL2pp dC5kZy90ZXN0LXNpZ25lZC1jaGFyLmMgYi9nY2MvdGVzdHN1aXRlL2ppdC5kZy90ZXN0LXNpZ25l ZC1jaGFyLmMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLmMxMmI0MWQ5 MmNjCi0tLSAvZGV2L251bGwKKysrIGIvZ2NjL3Rlc3RzdWl0ZS9qaXQuZGcvdGVzdC1zaWduZWQt Y2hhci5jCkBAIC0wLDAgKzEsNTIgQEAKKyNpbmNsdWRlIDxzdGRsaWIuaD4KKyNpbmNsdWRlIDxz dGRpby5oPgorI2luY2x1ZGUgPHN0ZGRlZi5oPgorCisjaW5jbHVkZSAibGliZ2Njaml0LmgiCisK KyNpbmNsdWRlICJoYXJuZXNzLmgiCisKK3ZvaWQKK2NyZWF0ZV9jb2RlIChnY2Nfaml0X2NvbnRl eHQgKmN0eHQsIHZvaWQgKnVzZXJfZGF0YSkKK3sKKyAgLyogTGV0J3MgdHJ5IHRvIGluamVjdCB0 aGUgZXF1aXZhbGVudCBvZjoKKyAgICAgICAgaW50IHRlc3Rfc2lnbmVkX2NoYXIgKCkKKyAgICAg ICAgeworICAgICAgICAgICAgY2hhciB2YWwgPSAtMjsKKyAgICAgICAgICAgIHJldHVybiAoaW50 KSB2YWw7CisgICAgICAgIH0KKyAgICAqLworICBnY2Nfaml0X3R5cGUgKmNoYXJfdHlwZSA9Cisg ICAgZ2NjX2ppdF9jb250ZXh0X2dldF90eXBlIChjdHh0LCBHQ0NfSklUX1RZUEVfQ0hBUik7Cisg IGdjY19qaXRfdHlwZSAqaW50X3R5cGUgPQorICAgIGdjY19qaXRfY29udGV4dF9nZXRfdHlwZSAo Y3R4dCwgR0NDX0pJVF9UWVBFX0lOVCk7CisKKyAgZ2NjX2ppdF9mdW5jdGlvbiAqdGVzdF9mbiA9 CisgICAgZ2NjX2ppdF9jb250ZXh0X25ld19mdW5jdGlvbiAoY3R4dCwgTlVMTCwKKwkJCQkgIEdD Q19KSVRfRlVOQ1RJT05fRVhQT1JURUQsCisJCQkJICBpbnRfdHlwZSwKKwkJCQkgICJ0ZXN0X3Np Z25lZF9jaGFyIiwKKwkJCQkgIDAsIE5VTEwsCisJCQkJICAwKTsKKworICBnY2Nfaml0X2Jsb2Nr ICpibG9jayA9IGdjY19qaXRfZnVuY3Rpb25fbmV3X2Jsb2NrKHRlc3RfZm4sICJlbnRyeSIpOwor CisgIGdjY19qaXRfcnZhbHVlICp2YWwgPSBnY2Nfaml0X2NvbnRleHRfbmV3X3J2YWx1ZV9mcm9t X2ludCAoY3R4dCwKKyAgICBjaGFyX3R5cGUsIC0yKTsKKyAgZ2NjX2ppdF9ydmFsdWUgKnJldHVy bl92YWx1ZSA9IGdjY19qaXRfY29udGV4dF9uZXdfY2FzdCAoCisgICAgY3R4dCwgTlVMTCwgdmFs LCBpbnRfdHlwZSk7CisKKyAgZ2NjX2ppdF9ibG9ja19lbmRfd2l0aF9yZXR1cm4gKGJsb2NrLCBO VUxMLCByZXR1cm5fdmFsdWUpOworfQorCit2b2lkCit2ZXJpZnlfY29kZSAoZ2NjX2ppdF9jb250 ZXh0ICpjdHh0LCBnY2Nfaml0X3Jlc3VsdCAqcmVzdWx0KQoreworICBDSEVDS19OT05fTlVMTCAo cmVzdWx0KTsKKworICB0eXBlZGVmIGludCAoKmZuX3R5cGUpICgpOworICBmbl90eXBlIHRlc3Rf c2lnbmVkX2NoYXIgPQorICAgIChmbl90eXBlKWdjY19qaXRfcmVzdWx0X2dldF9jb2RlIChyZXN1 bHQsICJ0ZXN0X3NpZ25lZF9jaGFyIik7CisgIENIRUNLX05PTl9OVUxMICh0ZXN0X3NpZ25lZF9j aGFyKTsKKyAgQ0hFQ0tfVkFMVUUgKHRlc3Rfc2lnbmVkX2NoYXIgKCksIC0yKTsKK30KLS0gCjIu NDMuMAoK --=-O01CfPnF1TugvK09CP2I--