From: Joseph Myers <joseph@codesourcery.com>
To: David Malcolm <dmalcolm@redhat.com>
Cc: <jit@gcc.gnu.org>, <gcc-patches@gcc.gnu.org>,
Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
Subject: Re: [PATCH 1/3] PR jit/64810: driver, arm, jit: configure-time default options
Date: Thu, 01 Jan 2015 00:00:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.10.1501302156081.22533@digraph.polyomino.org.uk> (raw)
In-Reply-To: <1422616184-38258-1-git-send-email-dmalcolm@redhat.com>
On Fri, 30 Jan 2015, David Malcolm wrote:
> gcc/ChangeLog:
> PR jit/64810
> * Makefile.in (GCC_OBJS): Add gcc-main.o.
> * gcc-main.c: New file, containing "main" taken from gcc.c.
> * gcc.c (do_self_spec): Free decoded_options.
> (class driver): Move declaration to gcc.h.
> (main): Move declaration and implementation to new file
> gcc-main.c.
> (driver_get_configure_time_options): New function.
> * gcc.h (class driver): Move this declaration here, from
> gcc.c.
> (driver_get_configure_time_options): New declaration.
The driver changes are OK. Though in the JIT I suspect you might need to
process DRIVER_SELF_SPECS as well - not everything handled through
DRIVER_SELF_SPECS is a default cc1 would follow anyway, sometimes it may
actually set things rather than merely make them visible to other specs.
And indeed CC1_SPEC may also be needed. Some architectures use
DRIVER_SELF_SPECS to handle -march=native, some use CC1_SPEC - so if you
configure --with-arch=native (a perfectly legitimate way to configure GCC
if you're building it for one particular system to use to build code that
will run only there) then processing OPTION_DEFAULT_SPECS will cause
-march=native to appear in the list of options, and the other two specs
are needed to convert it into the underlying options understood by the
back-end option handling.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2015-01-30 22:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-01 0:00 David Malcolm
2015-01-01 0:00 ` Joseph Myers [this message]
2015-01-01 0:00 ` [PATCH 2/3] PR jit/64810: support DImode on arm David Malcolm
2015-01-01 0:00 ` [PATCH 3/3] PR jit/64810: fix for arm_option_override David Malcolm
2015-01-01 0:00 ` Richard Earnshaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1501302156081.22533@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
--cc=ramana.radhakrishnan@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).