From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76891 invoked by alias); 22 Jan 2017 09:05:37 -0000 Mailing-List: contact jit-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: jit-owner@gcc.gnu.org Received: (qmail 74278 invoked by uid 89); 22 Jan 2017 09:05:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=discusses, cvs, Think, UD:ansidecl.h X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-Spam-User: qpsmtpd, 2 recipients X-HELO: ainaz.pair.com Date: Sun, 01 Jan 2017 00:00:00 -0000 From: Gerald Pfeifer To: David Malcolm cc: Pedro Alves , Bernd Schmidt , Trevor Saunders , gcc-patches@gcc.gnu.org, jit@gcc.gnu.org Subject: Re: [wwwdocs, coding conventions] Mention OVERRIDE/FINAL In-Reply-To: <1476480483.10766.46.camel@redhat.com> Message-ID: References: <1462552846-17096-1-git-send-email-dmalcolm@redhat.com> <8ce94f18-421f-9466-85cf-e17d9caee151@redhat.com> <20160506183345.GK3628@ball> <5b2de202-c6bd-f8fc-3407-45a40ddfe62c@redhat.com> <014f88ec-909b-db46-1213-e9dbb8f14ee4@redhat.com> <0c78b409-efcc-3c49-4323-699e7ecfb6a0@redhat.com> <1476480483.10766.46.camel@redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="=-nAxpe8PZ4yXu2FPIqLdX" X-SW-Source: 2017-q1/txt/msg00005.txt.bz2 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --=-nAxpe8PZ4yXu2FPIqLdX Content-Type: text/plain; CHARSET=US-ASCII Content-length: 560 Hi David, On Fri, 14 Oct 2016, David Malcolm wrote: > I propose that we update our coding conventions to mention the OVERRIDE > and FINAL macros in the paragraph that discusses virtual funcs. > > The attached patch (to the website) does so. > > OK to commit? I saw that Pedro agreed, but none of our global reviewers (such as Bernd) chimed in. So, while this looks fine from a pure wwwdocs perspective, I did not feel comfortable approving it without larger concensus. If you want to push this, perhaps send a note/request to gcc@ proposing this? Gerald --=-nAxpe8PZ4yXu2FPIqLdX Content-Type: text/x-patch; NAME=www-use-OVERRIDE-and-FINAL.patch; CHARSET=UTF-8 Content-Transfer-Encoding: BASE64 Content-Description: Content-Disposition: ATTACHMENT; FILENAME=www-use-OVERRIDE-and-FINAL.patch Content-length: 1107 SW5kZXg6IGh0ZG9jcy9jb2Rpbmdjb252ZW50aW9ucy5odG1sCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvZ2NjL3d3d2RvY3MvaHRk b2NzL2NvZGluZ2NvbnZlbnRpb25zLmh0bWwsdgpyZXRyaWV2aW5nIHJldmlz aW9uIDEuNzcKZGlmZiAtdSAtcCAtcjEuNzcgY29kaW5nY29udmVudGlvbnMu aHRtbAotLS0gaHRkb2NzL2NvZGluZ2NvbnZlbnRpb25zLmh0bWwJMTggU2Vw IDIwMTYgMTM6NTU6MTcgLTAwMDAJMS43NworKysgaHRkb2NzL2NvZGluZ2Nv bnZlbnRpb25zLmh0bWwJMTQgT2N0IDIwMTYgMjE6MjI6NDQgLTAwMDAKQEAg LTkwMiw3ICs5MDIsMTAgQEAgSXRzIHVzZSB3aXRoIGRhdGEtY2Fycnlpbmcg Y2xhc3NlcyBpcyBtbwogPHA+CiBUaGluayBjYXJlZnVsbHkgYWJvdXQgdGhl IHNpemUgYW5kIHBlcmZvcm1hbmNlIGltcGFjdAogb2YgdmlydHVhbCBmdW5j dGlvbnMgYW5kIHZpcnR1YWwgYmFzZXMKLWJlZm9yZSB1c2luZyB0aGVtLgor YmVmb3JlIHVzaW5nIHRoZW0uICBJZiB5b3UgZG8gdXNlIHZpcnR1YWwgZnVu Y3Rpb25zLCB1c2UgdGhlCis8Y29kZT5PVkVSUklERTwvY29kZT4gYW5kIDxj b2RlPkZJTkFMPC9jb2RlPiBtYWNyb3MgZnJvbQorPGNvZGU+aW5jbHVkZS9h bnNpZGVjbC5oPC9jb2RlPiB0byBhbm5vdGF0ZSB0aGUgY29kZSBmb3IgYSBo dW1hbiByZWFkZXIsCithbmQgdG8gYWxsb3cgc3VmZmljaWVudGx5IG1vZGVy biBDKysgY29tcGlsZXJzIHRvIGRldGVjdCBtaXN0YWtlcy4KIDwvcD4KIAog PHA+Cg== --=-nAxpe8PZ4yXu2FPIqLdX--