From: David Malcolm <dmalcolm@redhat.com>
To: Antoni Boucher <bouanto@zoho.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"jit@gcc.gnu.org" <jit@gcc.gnu.org>
Subject: Re: [PATCH] libgccjit: Clear pending_assemble_externals_processed
Date: Thu, 15 Feb 2024 14:23:24 -0500 [thread overview]
Message-ID: <b1db42ffd169a6f4dad4e73a763f966e8d366f83.camel@redhat.com> (raw)
In-Reply-To: <1a303744d38e540eb78df6bc8949704e19b8359a.camel@zoho.com>
On Thu, 2024-02-15 at 14:14 -0500, Antoni Boucher wrote:
> It's OK to merge even though it touches files outside of the jit
> directory and we're in stage 4?
> Or do we need some kind of approval?
I think this patch is sufficiently low-risk that you can go ahead and
merge it.
Dave
>
> On Thu, 2024-02-15 at 10:35 -0500, David Malcolm wrote:
> > On Thu, 2024-02-08 at 17:09 -0500, Antoni Boucher wrote:
> > > Hi.
> > > This patch fixes the bug 113842.
> > > I cannot yet add a test with this patch since it requires using
> > > try/catch which is not yet merged in master.
> > > Thanks for the review.
> >
> > Thanks; patch looks good for trunk, assuming you've tested it on a
> > target that defines ASM_OUTPUT_EXTERNAL.
> >
> > Dave
> >
>
prev parent reply other threads:[~2024-02-15 19:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 22:09 Antoni Boucher
2024-02-15 14:33 ` Antoni Boucher
2024-02-15 15:35 ` David Malcolm
2024-02-15 19:14 ` Antoni Boucher
2024-02-15 19:23 ` David Malcolm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1db42ffd169a6f4dad4e73a763f966e8d366f83.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=bouanto@zoho.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).