From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111817 invoked by alias); 4 Oct 2019 01:27:58 -0000 Mailing-List: contact jit-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: jit-owner@gcc.gnu.org Received: (qmail 111799 invoked by uid 89); 4 Oct 2019 01:27:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=H*f:sk:gkro8yy, H*i:sk:gkro8yy, Applied X-Spam-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 04 Oct 2019 01:27:56 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1E53C83F40; Fri, 4 Oct 2019 01:27:55 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-68.rdu2.redhat.com [10.10.112.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id C28F0608A5; Fri, 4 Oct 2019 01:27:52 +0000 (UTC) Subject: Re: [PATCH] IPA-CP release transformation summary (PR jit/91928) To: Andrea Corallo Cc: Martin Jambor , "gcc-patches@gcc.gnu.org" , "jit@gcc.gnu.org" , nd , Jan Hubicka , Jan Hubicka References: <29ab6082-a8d7-7471-ff99-3472a28eb84e@redhat.com> From: Jeff Law Openpgp: preference=signencrypt Autocrypt: addr=law@redhat.com; prefer-encrypt=mutual; keydata= mQENBFkbIO8BCACVIqDhDVh9ur8C+zNV1J/cXfwvVDAUcphDEFl4jyHqZORK4Pd3Db8oWqLm Q8lOCr/VOS7lrCtdpVMQkLGOGA16oJ8g7hzhnojpjY09UjsoUiG7oKacuxj8skfp6SIx93Zl +iNYPRa4S+za6nY8qiVjyUuiyX04ZPZMrKp2c2sGi+HnBKUZXGhrz/Jdzdox3tjajWZnObyy nhEN6hn9L3KawTtGPE/R6A/1RhHTD9FQmIWIeucpaY5c6GNKXTFpj2VYx57LY5hve1R5vhrJ IZcgwZAiOtmik5lVi96glY5h6bugRwpexjhwORTLPBCkwiYotSxX99mWd6EHL576i5CNABEB AAG0GUplZmYgTGF3IDxsYXdAcmVkaGF0LmNvbT6JAU4EEwEIADgWIQR+niGjtnP5P/8PpRq8 fP682pgzWwUCWRsg7wIbAwULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRC8fP682pgzW5QG B/9VATJmx5235RB+8jiDYGXQf3vd9gBfPy/l1tsaK400eFAevDzfGvKmeCKe+uGnlrH3vyT8 rg9zqH+s5a1Y+lDXPOpJAFmmzbOLU4FW4ucbawmtYvBL65PqpQneCTYnC802/OAcxjm/Onem HlgeK6WicNsBTPwYN/0araDFUejyYBIFi9CNqqflwk5Z3brKbQ9bAYIkysVLC/c3njKPmM0c WPFHG91ubLbWCHwTIK0+mAL714eTD74dXzOjO2ZDBPLGlFN/kO3+YjaO6UOD2O8acvAMCivT kWLr7JwRgLIQDN2DkhQDd3LTPqQE/yOcMcXBTO+fxm8KG0iKQBqWMyGJuQENBFkbIO8BCACy qbOsv7XegSeea8XORt5zMaBVWKoSyhmmcCmlxZFS2cuYOBt79MO13lZE2DlO3Lv5IKikj/D4 ketGVO4+h5psEMH5Yz5P8bx0TmgwbK1GxPZrzeXozUFJDvvCDbIlT0v0pwUXuK3hg8Ieo2h5 uTed/cn1OjySXW5BqLxN0cyr5hL+J6dcsHvKLT/N3nTgCQhoJXK2MrEMhAGgF3jKpMn3CoS4 i/ZbNI2MQR6LWHwdZ95f0fI8NzHSfVzeLtzCKQec7nr9fgd6Ylk1ZpGWQUPlQmKjzYgeCeTK NO04cwt20WIrQWeWiZFPA0U86NDBdSBrYp4kG3dfIXE+wSSvE7qPABEBAAGJATYEGAEIACAW IQR+niGjtnP5P/8PpRq8fP682pgzWwUCWRsg7wIbDAAKCRC8fP682pgzW3REB/9cT7iKRPg/ OK9bpLlllIEDM90IaKC79DQrv+fRudOR78cdV4XUwPSFnyHUsP3VJ4lDy5FhiKCwGie0BK53 EsxgMrLy1L8hboFdTE4Vi0xzCheMaMVp4hATDU29k1cuxu1VPpCa8E3mYeHjNV7ip0HN5L4D rfs8lRPJE/oM1vGs9DgQFZrCPPNRNGKC97BH+DHccesEJr7tSsQrkPkt0z/FTKr5wIM02vSx OJjgmcVbGB7dc2j/Sx8loXmuKnuKtM35668kUG8jeJvSQk3o/VHpD27bhl0rR68R2jN6G6kQ egMVb6dPu1Ius8rBE5rFw88J4JEb5q4hMNClWWUFHIdP Message-ID: Date: Tue, 01 Jan 2019 00:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 04 Oct 2019 01:27:55 +0000 (UTC) X-SW-Source: 2019-q4/txt/msg00003.txt.bz2 On 10/3/19 6:47 AM, Andrea Corallo wrote: > > Jeff Law writes: > >> On 10/1/19 4:11 AM, Andrea Corallo wrote: >>> Martin Jambor writes: >>> >>>> Hi, >>>> >>>> On Mon, Sep 30 2019, Andrea Corallo wrote: >>>>> Hi all, >>>>> I'd like to submit this patch. >>>>> It release the ipa cp transformation summary after functions being expanded. >>>>> This is to fix the compiler when used with libgccjit on subsequent >>>>> compilations (every new compilation should have a clean transformation >>>>> summary). >>>> if this is a general problem then I think we should instead add another >>>> hook to class ipa_opt_pass_d to free transformation summary, call it for >>>> all IPA passes at the appropriate time and implement it for IPA-CP. That >>>> way it will work for all IPA passes which might have a transformation >>>> summary. >>>> >>>> Martin >>>> >>>> >>>>> Bootstrap on arm64 and X86-64. >>>>> >>>>> Bests >>>>> Andrea >>>>> >>>>> gcc/ChangeLog >>>>> 2019-??-?? Andrea Corallo >>>>> >>>>> * cgraphunit.c (expand_all_functions): Release ipcp_transformation_sum >>>>> when finished. >>>>> * ipa-prop.c (ipcp_free_transformation_sum): New function. >>>>> * ipa-prop.h (ipcp_free_transformation_sum): Add declaration. >>> Hi, >>> actually looking around in order to implement the suggestions I realized >>> that already some code was put in place in toplev::finalize calling >>> then ipa_cp_c_finalize exactly for this purpose. >>> >>> I've updated the patch accordingly. >>> >>> Bootstraped on aarch64. >>> >>> Is it okay for trunk? >>> >>> Bests >>> Andrea >>> >>> gcc/ChangeLog >>> 2019-??-?? Andrea Corallo >>> >>> * ipa-cp.c (ipa_cp_c_finalize): Release ipcp_transformation_sum. >>> * ipa-prop.c (ipcp_free_transformation_sum): New function. >>> * ipa-prop.h (ipcp_free_transformation_sum): Add declaration. >> OK for the trunk. >> >> jeff > > Applied as r276507. > > The same patch applies cleanly onto gcc-9-branch, I think would be good to > back port it cause libgccjit is not very usable without. > Should we back port it? It's a bit out of the scope of what we usually backport, but I think this is a reasonable exception. So, yea, if you want, go ahead. Thanks jeff