From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-4.sys.kth.se (smtp-4.sys.kth.se [IPv6:2001:6b0:1:1300:250:56ff:fea6:2de3]) by sourceware.org (Postfix) with ESMTPS id 436B0383F40F; Sat, 4 Sep 2021 23:40:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 436B0383F40F Received: from smtp-4.sys.kth.se (localhost.localdomain [127.0.0.1]) by smtp-4.sys.kth.se (Postfix) with ESMTP id 8AF196C56; Sun, 5 Sep 2021 01:40:03 +0200 (CEST) X-Virus-Scanned: by amavisd-new at kth.se Received: from smtp-4.sys.kth.se ([127.0.0.1]) by smtp-4.sys.kth.se (smtp-4.sys.kth.se [127.0.0.1]) (amavisd-new, port 10024) with LMTP id t5-wHB4Mg0UD; Sun, 5 Sep 2021 01:40:02 +0200 (CEST) Received: from exdb3.ug.kth.se (exdb3.ug.kth.se [192.168.32.58]) by smtp-4.sys.kth.se (Postfix) with ESMTPS id B6B576C42; Sun, 5 Sep 2021 01:40:02 +0200 (CEST) Received: from exdb6.ug.kth.se (192.168.32.61) by exdb3.ug.kth.se (192.168.32.58) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.858.15; Sun, 5 Sep 2021 01:40:02 +0200 Received: from exdb6.ug.kth.se ([192.168.32.61]) by exdb6.ug.kth.se ([192.168.32.61]) with mapi id 15.02.0858.015; Sun, 5 Sep 2021 01:40:02 +0200 From: Petter Tomner To: "gcc-patches@gcc.gnu.org" , "jit@gcc.gnu.org" Subject: [PATCH 0/2 v2] jit : Generate debug info for variables Thread-Topic: [PATCH 0/2 v2] jit : Generate debug info for variables Thread-Index: Adeh47kPPxY3DD+URLCAvGXaKb0NdA== Date: Sat, 4 Sep 2021 23:40:01 +0000 Message-ID: Accept-Language: sv-SE, en-US Content-Language: sv-SE X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.168.32.250] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_ASCII_DIVIDERS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Sep 2021 23:40:08 -0000 Hi, This is a revision of my patch for debug info. The patches are posted as mails to this thread. Make check-jit runs fine on= Debian x64. Below is the original mail and under it a rehash of the review comments. Regards, Petter --------------------------------------------------------------------------= ------------------------------- Hi, This is a patch to generate debug info for local variables as well as globa= ls.=20 With this, "ptype foo", "info variables", "info locals" etc works when debu= gging in GDB. Finalizing of global variable declares are moved to after locations are han= dled and done as Fortran, C, Go etc do it. Also, primitive types have their TYPE_NAME set= for debug info on types to work. Below are the patch, and I attached a testcase. Since it requires GDB to ru= n it might not be suitable? Make check-jit runs fine on Debian x64. Regards, ---------------------------------------------------------------------------= ------------------------------ > Can you write non-empty ChangeLog entries please. Done. I think the python script chokes on asd/qwe/jit.db/ (the dot) though. > @@ -2984,15 +2975,22 @@ replay () > Looks like some whitespace churn above Fixed. > I don't see "Signed-off-by" tags in the patches. Added. > I think this should be "unsupported" rather than "xfail". Changed. > This is OK, but maybe using gcc_jit_context_dump_to_file with update_locations =3D=3D 1 might be more sustainable in the long run? Ye I didn't remember that flag. Entering loc manually aint no fun.