From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sender4-pp-o90.zoho.com (sender4-pp-o90.zoho.com [136.143.188.90]) by sourceware.org (Postfix) with ESMTPS id 22D853858D35; Tue, 6 Feb 2024 12:54:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 22D853858D35 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=zoho.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=zoho.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 22D853858D35 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=136.143.188.90 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1707224086; cv=pass; b=l293PJXdGI6KPfcks7D0TmTSdJxOrUdCe8QJxjeDPWKuDpXUoBP30ytAXj8gK12gU7AJFriBtc7ehBnp/NztcP1fyb090nvuj7B60j06Qpwnw3+w1ubbp6eNYK5GGHFYzYoAfYd4P1bN/5vHQHq5G/XJP8Qv1yH7uLuRrdqx/XQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1707224086; c=relaxed/simple; bh=O02Bu4X5txoJrMJU5ZiAP9OD3C08LxilmrwLLAFq6hE=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=Ojp90O8r/0EpCB7SLCwE1i8ZckkAOVcxes2yeDeAVRCVKw0gS3WPl0XKIA5PBLb5qvloEYbCLWzJLr27yxbWeMMg5INTmxV6D7B7WmNLn8gMkijqtSmURkODM7G5XcndAyCnU4ns2KQ6i+/gOg0KU6/1/Tq29S4nmzHYYw2I8Hk= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; t=1707224074; cv=none; d=zohomail.com; s=zohoarc; b=eV9h3atanzC84bHYnCWv6DUh4Wd9nlyiFCndD+7zvDk1EGRgUoYKTfkunHB1disllHUHguA9paYjl1XJGQF/Ao2S/NZIW6q8Gi22gtYsmIxtlvbyZ8vzAXGYEKvqlhIzJ/VKWU/b6vA3xpEUNBdEUZYwZgPYrvdRl8x+l9WL2Vk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1707224074; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=xLYajDY2QIEc9KM7ESrP87uPb0/lXwRQ26AKBaYwXMU=; b=hRlz72+XC3/L2ZSwEws2kNffPWgHpqozoyehAA4i1+TCjE6EWS7T24zxIf+HC7gyliLwfT0SCKUe/EsV1dCWEJcJNu+6rCSp+ftH/Cbf9y3RjAePc3992HGqAaUMuTEBvHs/13XNgrRZq0MGYBL+PTGJG7bCoh1wArXATBAyunA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zoho.com; spf=pass smtp.mailfrom=bouanto@zoho.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1707224074; s=zm2022; d=zoho.com; i=bouanto@zoho.com; h=Message-ID:Subject:Subject:From:From:To:To:Date:Date:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:MIME-Version:Feedback-ID:Message-Id:Reply-To:Cc; bh=xLYajDY2QIEc9KM7ESrP87uPb0/lXwRQ26AKBaYwXMU=; b=Yre70Rk9W8+CCsQ5sqwURZeOeLAT5Zw1mljtKWtEN3Y9kJQIYTZCWJzM9evBSAw0 CnAJ1MXjKtpNkskvQV3FMJWeHMDgdJecnYZJEc1lKkZkLg6OxUVy2vXEMu+doVlLqVS MUuC2c/Rf+arJQrlOER67fNzL5OQF+IwQ4kh1MGo= Received: from [192.168.1.172] (38.87.11.6 [38.87.11.6]) by mx.zohomail.com with SMTPS id 1707224073448653.7615096739404; Tue, 6 Feb 2024 04:54:33 -0800 (PST) Message-ID: Subject: Re: [PATCH] libgccjit: Add ability to get CPU features From: Antoni Boucher To: David Malcolm , jit@gcc.gnu.org, gcc-patches@gcc.gnu.org, Iain Buclaw Date: Tue, 06 Feb 2024 07:54:30 -0500 In-Reply-To: <036c7c0625a9bbb1a35e0d7d2ec4a553f88a6eec.camel@zoho.com> References: <8b0199d9835f568b7bcde41bf9432c21f604e489.camel@zoho.com> <755705e37731c4fbc3ab7eb1a96d8df0147bb002.camel@redhat.com> <036c7c0625a9bbb1a35e0d7d2ec4a553f88a6eec.camel@zoho.com> Autocrypt: addr=bouanto@zoho.com; prefer-encrypt=mutual; keydata=mQENBFOSMLQBCADO5aw6Ys8thMQUNzrwAnfJX2wbgWiz0pQ01DjYj22eeIpChkoZn6LWdt4dieq30u2rFi/yQzJ02foHwI2+aL9rU6xz/x4TwqyRJQGMOqklNc3R+pdXmH4WDQkQDWmLxvc07vu+zb8Tx5A6pMDh4J2ncCEhLEUcH39Yq/yg4eBnFwUX6N7kakvHrnScGNqhnSFCacoJeMJUAR+1G7VBSBd++jmnHLnx3mj7QkRZVECJUw2zqiv1yReCC6GU4SvqLjdqm5ZGeoWOqD/NHjBRoEeOVjzp6M/qOjjWRbkJVqmvgfcD8UytSSqqboR35YFT4L+rZt2ri3T12MJb3i5syCAXABEBAAG0IUFudG9uaSBCb3VjaGVyIDxib3VhbnRvQHpvaG8uY29tPokBVgQTAQgAQAIbIwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAFiEEOELC4Uw1Jeb66YE6RVeGAwR4zcEFAlz4QM4FCRLMEZoACgkQRVeGAwR4zcFBQQf/afttJrA/puADQZhrDfkgr0MFvq6iB+GCy1b8BkXimk1TOXTPt87YLehSeijNu3JkYhl5eRc87BNfU9J87KfI/KIy6hZxqlDXk16FhW9bw/7wYEA0hpb3MUn7xLElXDT0ZHaD+KTe8Oun7qfzgx5RlL6r/WODf3CkSpO085R/rfeBqDEx9mVlhDWgq6Az3CZoD+3CqiCKVqmDuHTWz4kwrd9AM5eVcLvvLKnZIdoIp+G5Ao6BvaGlZyfenN1iOSjLy2NXNt4MnUt0lUYEP5KSIIRhHQ8xkUbj7eWUmaahkxhNb3fH3sAPwGnRZrPpb4rgYzNmSk63wWMh9M2xk+rLb7kBDQRTkjC0AQgAumZzsAV/UFWI+dpzebQfma36kKYZZFuseant5sq/HWP553XQ/U6ttJiKyN5MpCqtxvCAoRplf42YhlHuFqgf73WJxoJ6Y+sdyqoBSwlR+ gzAneAmsa8gmmY0wawH0Z2leazjKuS7mJjVEQZg0ZGsiCVRGeRnDqFGzDEzDc9ngWKSoTq0fKzlGy1X85OrtmUrvEbhSo6HP+FoeunHkIqrxu3w3vDoFEXxVQlKI6V3I4nCz5n6DB8WR3L7nsiiTnOiGirPw1ngvWFLW86kkA4FJpayc8Xl3va3SLY+2y4yuROboX2DVI4AC/Qeug/mDiBicPxkP6YfUartQRMe6obkEQARAQABiQE8BBgBCAAmAhsMFiEEOELC4Uw1Jeb66YE6RVeGAwR4zcEFAlz4QRsFCRLMEecACgkQRVeGAwR4zcE56ggAgTgrJInBKC+7552Dpccuo6Clh3wZfjlNLv9/6r5lKEbaNzaTrfhPiAP4WgnluIUmj8amOFLFJpj+BAVNOXpZ4D2R3o9ch8z7fot+fW4Yw+PKIxH4I2xEys8ndoEB3aiQwHjKcGIhkIU7uyMJFQr2aWjdTY0gmXw0YZueHOSLgo7uX4XKxB8fEO/yto/Tff2YBAAq+AtNwt+Gh5YS9rZw7rwUTWMi84yVOlc+zRE79E9NJkvdTwX7IJYo64VzIRNfgHsn7QNdVzuM1XIFHl+Glk6cIlI8s6BO7nEoCn3hTF104fQTAO3fEs+XXZOKXo2lk8faowEoPq5r58StrV0nyg== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.3 MIME-Version: 1.0 Feedback-ID: rr080112281a489b032c141c2ded05ff6800000992acb0ec5b36c127ad48339688d4aeb14f1802d99d39a575ca:zu080112260b442a0c34787d00a4f3d7de0000fe9045854e185e932f5ac00f98ce73ec9749df1266c1dcdf:rf08011232d9a99e46d221822a669cc8130000c14090975cdd498b5131bf4d8aa006ffe7affabe208aa5464acb4f25d4ab4f7fa7523f99:ZohoMail X-ZohoMailClient: External X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: David: Ping. On Tue, 2024-01-30 at 10:50 -0500, Antoni Boucher wrote: > David: I'm unsure what to do here. It seems we cannot find a > reviewer. > Would it help if I show you the code in gccrs that is similar? > Would it help if I ask someone from gccrs to review this code? >=20 > On Sat, 2024-01-20 at 09:50 -0500, Antoni Boucher wrote: > > CC-ing Iain in case they can do the review since it is based on how > > they did it in the D frontend. > > Could you please do the review? > > Thanks! > >=20 > > On Thu, 2023-11-09 at 18:04 -0500, David Malcolm wrote: > > > On Thu, 2023-11-09 at 17:27 -0500, Antoni Boucher wrote: > > > > Hi. > > > > This patch adds support for getting the CPU features in > > > > libgccjit > > > > (bug > > > > 112466) > > > >=20 > > > > There's a TODO in the test: > > > > I'm not sure how to test that gcc_jit_target_info_arch returns > > > > the > > > > correct value since it is dependant on the CPU. > > > > Any idea on how to improve this? > > > >=20 > > > > Also, I created a CStringHash to be able to have a > > > > std::unordered_set. Is there any built-in way of > > > > doing > > > > this? > > >=20 > > > Thanks for the patch. > > >=20 > > > Some high-level questions: > > >=20 > > > Is this specifically about detecting capabilities of the host > > > that > > > libgccjit is currently running on? or how the target was > > > configured > > > when libgccjit was built? > > >=20 > > > One of the benefits of libgccjit is that, in theory, we support > > > all > > > of > > > the targets that GCC already supports.=C2=A0 Does this patch change > > > that, > > > or > > > is this more about giving client code the ability to determine > > > capabilities of the specific host being compiled for? > > >=20 > > > I'm nervous about having per-target jit code.=C2=A0 Presumably there'= s > > > a > > > reason that we can't reuse existing target logic here - can you > > > please > > > describe what the problem is.=C2=A0 I see that the ChangeLog has: > > >=20 > > > > * config/i386/i386-jit.cc: New file. > > >=20 > > > where i386-jit.cc has almost 200 lines of nontrivial code.=C2=A0 Wher= e > > > did > > > this come from?=C2=A0 Did you base it on existing code in our source > > > tree, > > > making modifications to fit the new internal API, or did you > > > write > > > it > > > from scratch?=C2=A0 In either case, how onerous would this be for > > > other > > > targets? > > >=20 > > > I'm not at expert at target hooks (or at the i386 backend), so if > > > we > > > do > > > go with this approach I'd want someone else to review those parts > > > of > > > the patch. > > >=20 > > > Have you verified that GCC builds with this patch with jit *not* > > > enabled in the enabled languages? > > >=20 > > > [...snip...] > > >=20 > > > A nitpick: > > >=20 > > > > +.. function:: const char * \ > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 gcc_jit_target_info_arch (gcc_jit_target_info > > > > *info) > > > > + > > > > +=C2=A0=C2=A0 Get the architecture of the currently running CPU. > > >=20 > > > What does this string look like? > > > How long does the pointer remain valid? > > >=20 > > > Thanks again; hope the above makes sense > > > Dave > > >=20 > >=20 >=20