From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9D9E03858C60 for ; Tue, 3 Oct 2023 17:27:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9D9E03858C60 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696354030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0F6mPFRO0OFSUU5CfOthXCO6OnSmNWtr6kl1cPVo5ic=; b=gQPGZ44gsA5bIX22xk1kIsClalT0HFjmJ+dSY0PbNJCcJfgCLTI6B6PEDPwcQ5E9HKlmAW 7Hzv+y7V/I5PAzjT4QOwpn2LlcoeWgTU1Rdsnt8NLRQaruMaT+TcqWDFDUVon+6eIrODsQ yka3srNBAXniw8HJ0rNMHkfyaYrRH4s= Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-621-j55KKcZ7OJmrFcrddEcwVQ-1; Tue, 03 Oct 2023 13:27:09 -0400 X-MC-Unique: j55KKcZ7OJmrFcrddEcwVQ-1 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-5a23ad271d7so17919357b3.1 for ; Tue, 03 Oct 2023 10:27:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696354028; x=1696958828; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=0F6mPFRO0OFSUU5CfOthXCO6OnSmNWtr6kl1cPVo5ic=; b=biR5hwNsRlyn6z7V44YzxKyQYDh7T3n1MMsrJbqMtJH7rORODvQU2dl/sUZHmf61/S wY1lrJ2lkC+BDAHPVdzae6lbDRpEl3EYOIp3NPFbQvFB4XIypQTRAEAl0zekwlm4Ky/S RQkDE1mPsgMhMQl+jYiy+WDCdG87kdbLftuQMzJaH6KlQ5EcHEzuWM+R85Q7aF2vwsoo CYhWsVpd8WrE29XzQz3LV8LcveOnLPmytc+iuvfM9OVqZoW902+9leRIHt/QsRKkAcce p1LxnFzwMf/nkXoZ3W89+hJy9PmXfjPGEGapN80BaA9e3WvhgJWl75xjqfMg+Stu6Q7h mw7Q== X-Gm-Message-State: AOJu0YzcKx12DvgJdxyo8XgiSLqrN9I5leJXpQQ/gt5NyOh8f1DVCuWY Oozi7hYy4Gszit5S+3Fuywu+zk2fbrUUEzenziEzMl1+MhrNIgi3qige/bWeG/I7EGq4nz4K35W Zm0Ndrqg= X-Received: by 2002:a0d:f405:0:b0:583:741c:5fe6 with SMTP id d5-20020a0df405000000b00583741c5fe6mr193301ywf.52.1696354028165; Tue, 03 Oct 2023 10:27:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGp8Uypo+e86j3yauqi8iVLmc1zJAB7FyDnXXIiNlvf5+xIOTMhq8fZZC6nqYb2Yd46KVmEEg== X-Received: by 2002:a0d:f405:0:b0:583:741c:5fe6 with SMTP id d5-20020a0df405000000b00583741c5fe6mr193290ywf.52.1696354027934; Tue, 03 Oct 2023 10:27:07 -0700 (PDT) Received: from t14s.localdomain (c-76-28-97-5.hsd1.ma.comcast.net. [76.28.97.5]) by smtp.gmail.com with ESMTPSA id u1-20020a0ca701000000b0065d134904dbsm651308qva.56.2023.10.03.10.27.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 10:27:07 -0700 (PDT) Message-ID: Subject: Re: [COMMITTED] Remove pass counting in VRP. From: David Malcolm To: Andrew MacLeod , gcc-patches Cc: jit@gcc.gnu.org Date: Tue, 03 Oct 2023 13:27:06 -0400 In-Reply-To: References: <248800ec-0e0e-6cae-5aaa-a9c69cd5f46a@redhat.com> <32f0b8a98304dcce002b38c94de951b49cc5b8fe.camel@redhat.com> User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 2023-10-03 at 13:11 -0400, Andrew MacLeod wrote: >=20 > On 10/3/23 13:02, David Malcolm wrote: > > On Tue, 2023-10-03 at 10:32 -0400, Andrew MacLeod wrote: > > > Pass counting in VRP is used to decide when to call early VRP, > > > pass > > > the > > > flag to enable warnings, and when the final pass is. > > >=20 > > > If you try to add additional passes, this becomes quite fragile. > > > This > > > patch simply chooses the pass based on the data pointer passed > > > in, > > > and > > > remove the pass counter.=C2=A0=C2=A0 The first FULL VRP pass invokes = the > > > warning > > > code, and the flag passed in now represents the FINAL pass of > > > VRP. > > > There is no longer a global flag which, as it turns out, wasn't > > > working > > > well with the JIT compiler, but when undetected.=C2=A0 (Thanks to > > > dmalcolm > > > for helping me sort out what was going on there) > > >=20 > > >=20 > > > Bootstraps=C2=A0 on x86_64-pc-linux-gnu with no regressions.=C2=A0=C2= =A0 Pushed. > > [CCing jit mailing list] > >=20 > > I'm worried that this patch may have "papered over" an issue with > > libgccjit.=C2=A0 Specifically: >=20 > well, that isnt the patch that was checked in :-P Aha! That makes much more sense. I took a look at https://gcc.gnu.org/git/?p=3Dgcc.git;a=3Dcommitdiff;h=3D7eb5ce7f58ed4a48641= e1786e4fdeb2f7fb8c5ff and yes, that looks like it will work with libgccjit Thanks for clarifying (and for fixing the issue) Dave >=20 > Im not sure how the old version got into the commit note. >=20 > Attached is the version checked in. >=20