From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sender4-pp-o90.zoho.com (sender4-pp-o90.zoho.com [136.143.188.90]) by sourceware.org (Postfix) with ESMTPS id DDDBA3861863; Thu, 15 Feb 2024 15:51:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DDDBA3861863 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=zoho.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=zoho.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DDDBA3861863 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=136.143.188.90 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1708012300; cv=pass; b=HteAdKmTJC9fYYnOqUy51eEGlxEb8fbXaaeM2gTlQB7YzvVpn+Zf9dG7mEKQrT9cGLNr+HFsJ+9UYgJX2374D1MY+nnHGPOXfaAAaNc58I+UYSSxUh67B1oNAfcHwFv2q7Drcz02/H4Kfv2pejfS4BluGIVYuCI1UHwa0H4UjpA= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1708012300; c=relaxed/simple; bh=vA9XlYwRSM4ocvrxYdCkMwJNOUdKWWOqYrYmio+I/E4=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=qqYrJqJ89j8YRaI64QHTN1ds1riZwJMwVvppGIQwOyqxqiQkiX6wvZVkbPQ2cgsIflUUpStlqDHnfB8NHZogulaMvz6sClxE47pGsMQ0G3D7+mLlii2ThP+4C88vWmUKmo3BbDpzV78ng0GmDiQXrEzGFRnTnpRR7Mx1xBoy+S0= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; t=1708012286; cv=none; d=zohomail.com; s=zohoarc; b=GjU6OLxdZRumw0GaDX4k3brG3SZCkyiPoCu3jvcTJ8nDtdBZrbZB7VPExLn7bqOlJX/upC95JPT2WLDWvgiv0zj6oYK5JkOQwvJMFy+QUVwSSBB0EsCK2CzB+rKzkVVwEtwQPxt8HeYxCHRrlwOlp2iywnRaojy8iau74slGf4Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1708012286; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=vA9XlYwRSM4ocvrxYdCkMwJNOUdKWWOqYrYmio+I/E4=; b=VU5qS4pcg3FlJ0arbPYqTRJU6i322KQ7l+PZhtdt4wCThd3J/DJBkz5qQNNKl6z4hzMFTls8jYkxGrMKm6f7S7nbURrwjAqb76g8LesdAJM5vqdD9vaR2nHLcW8ViD+pHmRJC/8SncWiEJYAkofWkutjotddXTY33dzEuVEspDg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zoho.com; spf=pass smtp.mailfrom=bouanto@zoho.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1708012286; s=zm2022; d=zoho.com; i=bouanto@zoho.com; h=Message-ID:Subject:Subject:From:From:To:To:Cc:Cc:Date:Date:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:MIME-Version:Feedback-ID:Message-Id:Reply-To; bh=vA9XlYwRSM4ocvrxYdCkMwJNOUdKWWOqYrYmio+I/E4=; b=HXsBvigcMqYlJqhyoCEFNfQBPf1AnINxokcUHKfaMTztoWAMLffsxb/UdFnKMiJQ 1dHwCyVvIuRShxBa4ZUhvJPoND5QFwSF2DeL1sYkXutQMgaBY/127DJQnnZ+GF+KDyJ kkESCiw0dJ10K1G29nrZ2flUHTzoIgJEfnjyQjpg= Received: from [192.168.1.172] (38.87.11.6 [38.87.11.6]) by mx.zohomail.com with SMTPS id 1708012285247920.5118886770846; Thu, 15 Feb 2024 07:51:25 -0800 (PST) Message-ID: Subject: Re: [PATCH] libgccjit: Fix ira cost segfault From: Antoni Boucher To: David Malcolm , jit@gcc.gnu.org, gcc-patches@gcc.gnu.org Cc: Jan Hubicka , Uros Bizjak Date: Thu, 15 Feb 2024 10:51:22 -0500 In-Reply-To: <38ce46b90b2c0b4ddff3c68bf6dd11689b874e8c.camel@redhat.com> References: <531885fa576a672454e6630549858842588c800e.camel@zoho.com> <38ce46b90b2c0b4ddff3c68bf6dd11689b874e8c.camel@redhat.com> Autocrypt: addr=bouanto@zoho.com; prefer-encrypt=mutual; keydata=mQENBFOSMLQBCADO5aw6Ys8thMQUNzrwAnfJX2wbgWiz0pQ01DjYj22eeIpChkoZn6LWdt4dieq30u2rFi/yQzJ02foHwI2+aL9rU6xz/x4TwqyRJQGMOqklNc3R+pdXmH4WDQkQDWmLxvc07vu+zb8Tx5A6pMDh4J2ncCEhLEUcH39Yq/yg4eBnFwUX6N7kakvHrnScGNqhnSFCacoJeMJUAR+1G7VBSBd++jmnHLnx3mj7QkRZVECJUw2zqiv1yReCC6GU4SvqLjdqm5ZGeoWOqD/NHjBRoEeOVjzp6M/qOjjWRbkJVqmvgfcD8UytSSqqboR35YFT4L+rZt2ri3T12MJb3i5syCAXABEBAAG0IUFudG9uaSBCb3VjaGVyIDxib3VhbnRvQHpvaG8uY29tPokBVgQTAQgAQAIbIwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAFiEEOELC4Uw1Jeb66YE6RVeGAwR4zcEFAlz4QM4FCRLMEZoACgkQRVeGAwR4zcFBQQf/afttJrA/puADQZhrDfkgr0MFvq6iB+GCy1b8BkXimk1TOXTPt87YLehSeijNu3JkYhl5eRc87BNfU9J87KfI/KIy6hZxqlDXk16FhW9bw/7wYEA0hpb3MUn7xLElXDT0ZHaD+KTe8Oun7qfzgx5RlL6r/WODf3CkSpO085R/rfeBqDEx9mVlhDWgq6Az3CZoD+3CqiCKVqmDuHTWz4kwrd9AM5eVcLvvLKnZIdoIp+G5Ao6BvaGlZyfenN1iOSjLy2NXNt4MnUt0lUYEP5KSIIRhHQ8xkUbj7eWUmaahkxhNb3fH3sAPwGnRZrPpb4rgYzNmSk63wWMh9M2xk+rLb7kBDQRTkjC0AQgAumZzsAV/UFWI+dpzebQfma36kKYZZFuseant5sq/HWP553XQ/U6ttJiKyN5MpCqtxvCAoRplf42YhlHuFqgf73WJxoJ6Y+sdyqoBSwlR+ gzAneAmsa8gmmY0wawH0Z2leazjKuS7mJjVEQZg0ZGsiCVRGeRnDqFGzDEzDc9ngWKSoTq0fKzlGy1X85OrtmUrvEbhSo6HP+FoeunHkIqrxu3w3vDoFEXxVQlKI6V3I4nCz5n6DB8WR3L7nsiiTnOiGirPw1ngvWFLW86kkA4FJpayc8Xl3va3SLY+2y4yuROboX2DVI4AC/Qeug/mDiBicPxkP6YfUartQRMe6obkEQARAQABiQE8BBgBCAAmAhsMFiEEOELC4Uw1Jeb66YE6RVeGAwR4zcEFAlz4QRsFCRLMEecACgkQRVeGAwR4zcE56ggAgTgrJInBKC+7552Dpccuo6Clh3wZfjlNLv9/6r5lKEbaNzaTrfhPiAP4WgnluIUmj8amOFLFJpj+BAVNOXpZ4D2R3o9ch8z7fot+fW4Yw+PKIxH4I2xEys8ndoEB3aiQwHjKcGIhkIU7uyMJFQr2aWjdTY0gmXw0YZueHOSLgo7uX4XKxB8fEO/yto/Tff2YBAAq+AtNwt+Gh5YS9rZw7rwUTWMi84yVOlc+zRE79E9NJkvdTwX7IJYo64VzIRNfgHsn7QNdVzuM1XIFHl+Glk6cIlI8s6BO7nEoCn3hTF104fQTAO3fEs+XXZOKXo2lk8faowEoPq5r58StrV0nyg== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.3 MIME-Version: 1.0 Feedback-ID: rr08011228b98c0e31aad505bdbfb11c80000050a9a6205201f2ec445124c598d1877152606ba1fa0377c48e8b:zu080112264d9d845d739f6c2e4731b07e0000f38121b5a86af1c3a33f3e3cc4af18cce1e2c1eff0c1beac:rf08011231c3c6798198db6903a7f02c4100005a9eb5639118d823c05d4e708dfe73281eb62b49dbb90d33e197fe9ce9b86bbbdf2748:ZohoMail X-ZohoMailClient: External X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This patch is indeed not necessary anymore. On Wed, 2024-01-10 at 09:32 -0500, David Malcolm wrote: > On Wed, 2024-01-10 at 09:30 -0500, David Malcolm wrote: > > On Thu, 2023-11-16 at 17:28 -0500, Antoni Boucher wrote: > > > Hi. > > > This patch fixes a segfault that happens when compiling librsvg > > > (more > > > specifically its dependency aho-corasick) with rustc_codegen_gcc > > > (bug > > > 112575). > > > I was not able to create a reproducer for this bug: I'm assuming > > > I > > > might need to concat all the reproducers together in the same > > > file > > > in > > > order to be able to reproduce the issue. > >=20 > > Hi Antoni > >=20 > > Thanks for the patch; sorry for missing it before. > >=20 > > CCing the i386 maintainers; quoting the patch here to give them > > context: >=20 > Oops; actually adding them to the CC this time; sorry. >=20 > >=20 > > > From e0f4f51682266bc9f507afdb64908ed3695a2f5e Mon Sep 17 00:00:00 > > > 2001 > > > From: Antoni Boucher > > > Date: Thu, 2 Nov 2023 17:18:35 -0400 > > > Subject: [PATCH] libgccjit: Fix ira cost segfault > > >=20 > > > gcc/ChangeLog: > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0PR jit/112575 > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0* config/i386/i386-op= tions.cc > > > (ix86_option_override_internal): > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Cleanup target_attrib= ute_cache. > > > --- > > > =C2=A0gcc/config/i386/i386-options.cc | 6 ++++++ > > > =C2=A01 file changed, 6 insertions(+) > > >=20 > > > diff --git a/gcc/config/i386/i386-options.cc > > > b/gcc/config/i386/i386-options.cc > > > index df7d24352d1..f596c0fb53c 100644 > > > --- a/gcc/config/i386/i386-options.cc > > > +++ b/gcc/config/i386/i386-options.cc > > > @@ -3070,6 +3070,12 @@ ix86_option_override_internal (bool > > > main_args_p, > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=3D opts->x_flag_unsa= fe_math_optimizations; > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 target_option_default_node =3D t= arget_option_current_node > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =3D build_target_opt= ion_node (opts, opts_set); > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* TODO: check if this is the correct= location.=C2=A0 It should > > > probably be in > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 some finalizer function, = but I don't > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 know if there's one.=C2= =A0 */ > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 target_attribute_cache[0] =3D NULL; > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 target_attribute_cache[1] =3D NULL; > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 target_attribute_cache[2] =3D NULL; > > > =C2=A0=C2=A0=C2=A0=C2=A0 } > > > =C2=A0 > > > =C2=A0=C2=A0 if (opts->x_flag_cf_protection !=3D CF_NONE) > > > --=20 > > > 2.42.1 > > >=20 > >=20 > > Presumably this happens when there's more than one in-process > > invocation of the compiler code (via libgccjit). > >=20 > > >=20 > > > I'm also not sure I put the cleanup in the correct location. > > > Is there any finalizer function for target specific code? > >=20 > > As you know (but the i386 maintainers might not), to allow multiple > > in- > > process invocations of the compiler code (for libgccjit) we've been > > putting code to reset global state in various > > {filename_cc}_finalize > > functions called from toplev::finalize (see the end of toplev.cc). > >=20 > > There doesn't seem to be any kind of hook at this time for calling > > target-specific cleanups from toplev::finalize. > >=20 > > However, as of r14-4003-geaa8e8541349df ggc_common_finalize zeroes > > everything marked with GTY.=C2=A0 The array target_attribute_cache does > > have > > a GTY marking, so perhaps as of that commit this patch isn't > > necessary? > >=20 > > Otherwise, if special-casing this is required, sorry: I'm not > > familiar > > enough with i386-options.cc to know if the patch is correct. > >=20 > > >=20 > > > Thanks to fix this issue. > >=20 > > Dave >=20