From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sender4-pp-o90.zoho.com (sender4-pp-o90.zoho.com [136.143.188.90]) by sourceware.org (Postfix) with ESMTPS id C7D793858C53; Thu, 8 Feb 2024 14:00:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C7D793858C53 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=zoho.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=zoho.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C7D793858C53 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=136.143.188.90 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1707400806; cv=pass; b=S96XvNfvgdlZp4U4zuzuLvYnBwLDuOdfIcuCdgZFAia4oglbfDqYEphGzcQ4gz8nBVDHGoDeqwir857uAPHKR7rDLmY92YxqFH/qCaMUi8y2jZaOLZrd3gzQX4V7gBVqhoDptNR9QQbZjDjdi9fvn2fad3z7qkiELfREmljQ8Bw= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1707400806; c=relaxed/simple; bh=QSQXA/TSMiO813WfVdQ8oRS8uYpBH2wEvMQglm8vTFo=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=XiPz2Gx+vtASKnInMZeXD8XOliRO8NLv7AK68SpjTUwDZshwBlSKGFjKjITlbczjV63dIc1lMI5QwIUp8kKVpt+jkB0J9jjAFxR0UP/jcQ3YZ69AFXfGfuQbB5zlHpwij4wJialEWGC4TsGPyt8rqt54ANgTAgDzEuLSf7Ygz/8= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; t=1707400798; cv=none; d=zohomail.com; s=zohoarc; b=W7I7Mn40pOz2Xe/DbDxwSYQcBA2O2/ywjKSpw97hRgjVyilQxNFst8r1vb3xapNeMoZvvFvDcNohXH/ShDL8BbzRLAZ6N0n7ReFgEExadvMAyCvncDMkw2RjH//rfaqkQzE40hEbV/qihAFVFakhv2vaFJ2OMqnK54ys6pKXweg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1707400798; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=QSQXA/TSMiO813WfVdQ8oRS8uYpBH2wEvMQglm8vTFo=; b=exn/1wBI7XGyv/1q92g/W9sAChWn7Nj4W/z86t8BTftCWN82Fzd36MgVN/LorUUBYf0U+u5EyrdZO/jN4lq5akfIBdBEZitBr0VjuQ9TdpHVOyltYe/pjaOHXE9N92ptQqW257qp7kXiqAaJ0F4/0tQ4JOt80RTcsRnIReXhkkI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zoho.com; spf=pass smtp.mailfrom=bouanto@zoho.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1707400798; s=zm2022; d=zoho.com; i=bouanto@zoho.com; h=Message-ID:Subject:Subject:From:From:To:To:Cc:Cc:Date:Date:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:MIME-Version:Feedback-ID:Message-Id:Reply-To; bh=QSQXA/TSMiO813WfVdQ8oRS8uYpBH2wEvMQglm8vTFo=; b=OJjNsoC8uoM9n0lPhPkKu1qo3ByWygVpseEI2HUJyEd6fyMLSg6ZLLzcuZ4926Gk FNG4v66BZ+qo4GPSB6n7vychaYM5ymtLFuTzlUD89boNwH+hN5fwm4hwAD8KTh9YHAj 8AhneEmGealEXlfFU89t9QOA5dLVvXcCdyT5pLaw= Received: from [192.168.1.172] (38.87.11.6 [38.87.11.6]) by mx.zohomail.com with SMTPS id 1707400796080344.14767793881265; Thu, 8 Feb 2024 05:59:56 -0800 (PST) Message-ID: Subject: Re: [PATCH] libgccjit: Add support for machine-dependent builtins From: Antoni Boucher To: David Malcolm , Andrew Pinski Cc: jit@gcc.gnu.org, gcc-patches@gcc.gnu.org Date: Thu, 08 Feb 2024 08:59:53 -0500 In-Reply-To: <0f44d7bb2d4baa961112e164cefa1bd0a8ec0b1c.camel@zoho.com> References: <184790403bd8227db4054b9e672afbfdf879dc0c.camel@zoho.com> <68c5b0693c8f7a6c6ce59259fdf088106861e4e4.camel@zoho.com> <0f44d7bb2d4baa961112e164cefa1bd0a8ec0b1c.camel@zoho.com> Autocrypt: addr=bouanto@zoho.com; prefer-encrypt=mutual; keydata=mQENBFOSMLQBCADO5aw6Ys8thMQUNzrwAnfJX2wbgWiz0pQ01DjYj22eeIpChkoZn6LWdt4dieq30u2rFi/yQzJ02foHwI2+aL9rU6xz/x4TwqyRJQGMOqklNc3R+pdXmH4WDQkQDWmLxvc07vu+zb8Tx5A6pMDh4J2ncCEhLEUcH39Yq/yg4eBnFwUX6N7kakvHrnScGNqhnSFCacoJeMJUAR+1G7VBSBd++jmnHLnx3mj7QkRZVECJUw2zqiv1yReCC6GU4SvqLjdqm5ZGeoWOqD/NHjBRoEeOVjzp6M/qOjjWRbkJVqmvgfcD8UytSSqqboR35YFT4L+rZt2ri3T12MJb3i5syCAXABEBAAG0IUFudG9uaSBCb3VjaGVyIDxib3VhbnRvQHpvaG8uY29tPokBVgQTAQgAQAIbIwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAFiEEOELC4Uw1Jeb66YE6RVeGAwR4zcEFAlz4QM4FCRLMEZoACgkQRVeGAwR4zcFBQQf/afttJrA/puADQZhrDfkgr0MFvq6iB+GCy1b8BkXimk1TOXTPt87YLehSeijNu3JkYhl5eRc87BNfU9J87KfI/KIy6hZxqlDXk16FhW9bw/7wYEA0hpb3MUn7xLElXDT0ZHaD+KTe8Oun7qfzgx5RlL6r/WODf3CkSpO085R/rfeBqDEx9mVlhDWgq6Az3CZoD+3CqiCKVqmDuHTWz4kwrd9AM5eVcLvvLKnZIdoIp+G5Ao6BvaGlZyfenN1iOSjLy2NXNt4MnUt0lUYEP5KSIIRhHQ8xkUbj7eWUmaahkxhNb3fH3sAPwGnRZrPpb4rgYzNmSk63wWMh9M2xk+rLb7kBDQRTkjC0AQgAumZzsAV/UFWI+dpzebQfma36kKYZZFuseant5sq/HWP553XQ/U6ttJiKyN5MpCqtxvCAoRplf42YhlHuFqgf73WJxoJ6Y+sdyqoBSwlR+ gzAneAmsa8gmmY0wawH0Z2leazjKuS7mJjVEQZg0ZGsiCVRGeRnDqFGzDEzDc9ngWKSoTq0fKzlGy1X85OrtmUrvEbhSo6HP+FoeunHkIqrxu3w3vDoFEXxVQlKI6V3I4nCz5n6DB8WR3L7nsiiTnOiGirPw1ngvWFLW86kkA4FJpayc8Xl3va3SLY+2y4yuROboX2DVI4AC/Qeug/mDiBicPxkP6YfUartQRMe6obkEQARAQABiQE8BBgBCAAmAhsMFiEEOELC4Uw1Jeb66YE6RVeGAwR4zcEFAlz4QRsFCRLMEecACgkQRVeGAwR4zcE56ggAgTgrJInBKC+7552Dpccuo6Clh3wZfjlNLv9/6r5lKEbaNzaTrfhPiAP4WgnluIUmj8amOFLFJpj+BAVNOXpZ4D2R3o9ch8z7fot+fW4Yw+PKIxH4I2xEys8ndoEB3aiQwHjKcGIhkIU7uyMJFQr2aWjdTY0gmXw0YZueHOSLgo7uX4XKxB8fEO/yto/Tff2YBAAq+AtNwt+Gh5YS9rZw7rwUTWMi84yVOlc+zRE79E9NJkvdTwX7IJYo64VzIRNfgHsn7QNdVzuM1XIFHl+Glk6cIlI8s6BO7nEoCn3hTF104fQTAO3fEs+XXZOKXo2lk8faowEoPq5r58StrV0nyg== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.3 MIME-Version: 1.0 Feedback-ID: rr08011228421b26d726904debe13ca93f00006795fa4b1de65a02ed33cde87f46021c616b069a3cb266aea9b9:zu080112262c3c9538033e9202c713ed4a0000e829662d3b52ada772e990e3382d192bcbc8accdb07d6638:rf08011232972de60ea9dfd05f483b2f7a00003b9f8fb717805393dd7c4e516c8e1979391494dcb5205f6061aaf2662e3e5238bd41ea71:ZohoMail X-ZohoMailClient: External X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: David: Ping. On Wed, 2024-01-10 at 18:58 -0500, Antoni Boucher wrote: > Here it is: https://gcc.gnu.org/pipermail/jit/2023q4/001725.html >=20 > On Wed, 2024-01-10 at 18:44 -0500, David Malcolm wrote: > > On Wed, 2024-01-10 at 18:29 -0500, Antoni Boucher wrote: > > > David: Ping in case you missed this patch. > >=20 > > For some reason it's not showing up in patchwork (or, at least, I > > can't > > find it there).=C2=A0 Do you have a URL for it there? > >=20 > > Sorry about this > > Dave > >=20 > > >=20 > > > On Sat, 2023-02-11 at 17:37 -0800, Andrew Pinski wrote: > > > > On Sat, Feb 11, 2023 at 4:31 PM Antoni Boucher via Gcc-patches > > > > wrote: > > > > >=20 > > > > > Hi. > > > > > This patch adds support for machine-dependent builtins in > > > > > libgccjit > > > > > (bug 108762). > > > > >=20 > > > > > There are two things I don't like in this patch: > > > > >=20 > > > > > =C2=A01. There are a few functions copied from the C frontend > > > > > (common_mark_addressable_vec and a few others). > > > > >=20 > > > > > =C2=A02. Getting a target builtin only works from the second > > > > > compilation > > > > > since the type information is recorded at the first > > > > > compilation. > > > > > I > > > > > couldn't find a way to get the builtin data without using the > > > > > langhook. > > > > > It is necessary to get the type information for type checking > > > > > and > > > > > instrospection. > > > > >=20 > > > > > Any idea how to fix these issues? > > > >=20 > > > > Seems like you should do this patch in a few steps; that is > > > > split > > > > it > > > > up. > > > > Definitely split out GCC_JIT_TYPE_BFLOAT16 support. > > > > I also think the vector support should be in a different patch > > > > too. > > > >=20 > > > > Splitting out these parts would definitely make it easier for > > > > review > > > > and make incremental improvements. > > > >=20 > > > > Thanks, > > > > Andrew Pinski > > > >=20 > > > >=20 > > > >=20 > > > > >=20 > > > > > Thanks for the review. > > >=20 > >=20 >=20