From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id DD5E83858C2C for ; Thu, 9 Sep 2021 12:41:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DD5E83858C2C Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-516-BR_KlgOlOJeemLYmHM0q2g-1; Thu, 09 Sep 2021 08:41:56 -0400 X-MC-Unique: BR_KlgOlOJeemLYmHM0q2g-1 Received: by mail-qv1-f71.google.com with SMTP id d2-20020a0caa02000000b003784ba308f1so6435958qvb.9 for ; Thu, 09 Sep 2021 05:41:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=gQOEwtTXS6YCtFudNZVFpcccPbQPbTGJrMbS4Q36SHY=; b=745ihjIuz9QCjfg0H6DD/VYQz8s82z7XrqfrKcAVqr05kNp6oB6ubzHKU+3v7B0y0x VnEyuWFuWUU9VcTPi7et4n6Y57jRV+bPFjyRKKI/dAk4FGm2+lD30ixddJNPKaoxOPhg TZ7smQZKRbdB+n9ulDGDqfotP3huU2Dj210x3qkk2MZrMRCPOlCKbAo+Ww2ez37hw9xQ +5O3lGQOwZzACB1SDMm7VPnAIiFwTRaZhJbK+gSGqwZwyIXIvXmz0XNxqfjfQUksbVdN WVavdxsB17QpLsIHJUmQ6hAbBFhnTEJWKJnaXfhvYDPINQ76K88OYfeASg0vBhpcYOqi BBPw== X-Gm-Message-State: AOAM5313xAzTJqa7CqduMYwQ6w3nALLLSeSJCdHE8vofHUHMdy6ktDWZ 9UWqiWZMbNIm3XzBpCwQEvNvIN04ruIQhNS/fYw5q5z0kf8DGMo3fswl0Sh6MX2Et38QP1imjS7 KIdd9wkQ= X-Received: by 2002:a05:6214:3e2:: with SMTP id cf2mr819583qvb.37.1631191315662; Thu, 09 Sep 2021 05:41:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx0ZpxCwukQ8Fe5EsPexxiHRqjHzi9pDmQ6jVDDdS/4vXwu7H3HpjdY4DzRffmy8mrN83OqQA== X-Received: by 2002:a05:6214:3e2:: with SMTP id cf2mr819562qvb.37.1631191315422; Thu, 09 Sep 2021 05:41:55 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.ma.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id x83sm1205547qkb.118.2021.09.09.05.41.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Sep 2021 05:41:54 -0700 (PDT) Message-ID: Subject: Re: Sv: Sv: [PATCH 1/2 v2] jit : Generate debug info for variables From: David Malcolm To: Petter Tomner , "gcc-patches@gcc.gnu.org" , "jit@gcc.gnu.org" Date: Thu, 09 Sep 2021 08:41:54 -0400 In-Reply-To: <57cd0673c512469ab9bf0a6b2bdc1cb2@kth.se> References: <7886e65c8e4c4df4b49ae69ccee01973@kth.se> <75de9fbd1bcf460a8aeb48fde2072d96@kth.se> <4752e7eeda98e1b15e2adf0abdfc04313663ca32.camel@redhat.com> <57cd0673c512469ab9bf0a6b2bdc1cb2@kth.se> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Sep 2021 12:41:59 -0000 On Thu, 2021-09-09 at 07:45 +0000, Petter Tomner wrote: > Hi, > > I tested it on another machine over ssh and newer gdb:s (8.3+) clobbers > the output with color escapes so I had to disable colors > for the gdb session in jit.exp for the regex matching to work properly: > > +    verbose "Disable color styling in GDB newer then 8.3 (errors on > older)" > +    send "set style enabled off\n" > > On pre 8.3 gdb:s that will be an ignored syntax error. > > With that change it passes the check-jit test on that machine too. > >         === jit Summary === > >         # of expected passes            12073 > > I squashed the patches and attached it to this mail (with the above > change). Great, thanks. > > > No, I don't have push rights to the GCC repo. Should I request it? In theory I can push the patch on your behalf, but I'm hoping that you'll want to contribute other patches to libgccjit/GCC, so I'd prefer it if you got push rights and did it yourself. I'm happy to sponsor you for access; see: https://gcc.gnu.org/gitwrite.html#authenticated Thanks again for the patch Dave > > Regards, > Petter > > > -----Ursprungligt meddelande----- > Från: David Malcolm > Skickat: den 8 september 2021 14:49 > Till: Petter Tomner ; gcc-patches@gcc.gnu.org; > jit@gcc.gnu.org > Ämne: Re: Sv: [PATCH 1/2 v2] jit : Generate debug info for variables > > On Tue, 2021-09-07 at 16:18 +0000, Petter Tomner via Gcc-patches wrote: > > I realized I still managed to mess up some WS. I have attached a > > patch > > that is the same, except fixes the WS issue underneath. > > > > Regards, Petter > > > > +      FOR_EACH_VEC_ELT (m_globals, i, global) > > +    rest_of_decl_compilation (global, true, true); > > Thanks for the updated patch. > > Looks good to me, assuming it's been tested successfully.  It should be > combined with the testcase into a single commit when pushed. > > Do you have push rights to the GCC git repo? > > Dave > >