From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sender4-pp-o90.zoho.com (sender4-pp-o90.zoho.com [136.143.188.90]) by sourceware.org (Postfix) with ESMTPS id D09253858D39; Sat, 20 Jan 2024 14:50:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D09253858D39 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=zoho.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=zoho.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D09253858D39 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=136.143.188.90 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1705762230; cv=pass; b=qq8WbrBUJWsNd3DNwYZo2SQSJ+tLCSneqzCznOhNPFuSULKBvY5rQypSAMVYDqtD2ydtEMMSNqNZvoDTzfEZdrFwRG9sCVVOKnf0SBLRuVJIDSLR+E7Nnb0VDPGvUYpTVZcUEaRuP7hPbWcmQ9eCwN297Dze/6BXPD1RxKjR92s= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1705762230; c=relaxed/simple; bh=Cy5pujvgeGS6GBq/ydiKCftGpfPqIfK7V8LQC7klIXE=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=PNcaP8t78aNn5PeuU3k+c0msTaUriYWMFjgMO54s2dxsmFDMEejje/g44ZrGaDOw6udvGOTNKGyXM8vXW9bEqY6FuNz9mFL5+/0oroYkeborCXn4pZpbbxKrENaYg6CDUtQTrfYJUdcv8vJ3WwGkwXXlkuIdZvac1OkNVA52N2Q= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; t=1705762212; cv=none; d=zohomail.com; s=zohoarc; b=k7mGRQuxFM2UxLQX/Cr2qhuUeCyR6LRxw4KVg8K+U5Ld252Zm0b9TER2vdr29WUVapCOWRX/OwIks/25ySFqbCu9Y8VODR2tqLkcPnlxIVnxtylFCuHv54iVANqxsii9kcVXQjjgjtEYyYhj8q9GxR0+vi+KbqJQ9eqd/n7RQss= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1705762212; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=gfpFwpbVZpzKi4NMatOhkdLC2eki6cBaZ/0hDfcWUXg=; b=dcKU/iw//8tU/WTCwBRrriBGpUcMe/LNDxCaCX52mMsXFPHzBid7A7Nctwl7/6WiS8Rx0aXlh3MM8P7hoq6ulvMYh3Uy1K+/fh8Jz+XxCyS+h5luvLF38zFdiUfq9fNFFizynFZOCmMt6NCAi73yPd4M08nBMSK9WWK9vK2yKIg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zoho.com; spf=pass smtp.mailfrom=bouanto@zoho.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1705762212; s=zm2022; d=zoho.com; i=bouanto@zoho.com; h=Message-ID:Subject:Subject:From:From:To:To:Cc:Cc:Date:Date:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:MIME-Version:Feedback-ID:Message-Id:Reply-To; bh=gfpFwpbVZpzKi4NMatOhkdLC2eki6cBaZ/0hDfcWUXg=; b=aC18hNzs9hMsGch4dO/8nLDdrmCRlFVO/e2n68r3FHUk2QddsbGT8wthlE21H3P/ dckDLrNTLg/OuTJjAwmc5ZyPWuVp6nCDc6M3m4PRHH+XHT5fh5LTZuzppvFFSKjuzCE ZF4IAysQg6j/MKubqbYX3MiL3/clAg40QvOTvKOE= Received: from [192.168.1.172] (38.87.11.6 [38.87.11.6]) by mx.zohomail.com with SMTPS id 170576220939996.95819165289333; Sat, 20 Jan 2024 06:50:09 -0800 (PST) Message-ID: Subject: Re: [PATCH] libgccjit: Add ability to get CPU features From: Antoni Boucher To: David Malcolm , jit@gcc.gnu.org, gcc-patches@gcc.gnu.org Cc: Iain Buclaw Date: Sat, 20 Jan 2024 09:50:06 -0500 In-Reply-To: <755705e37731c4fbc3ab7eb1a96d8df0147bb002.camel@redhat.com> References: <8b0199d9835f568b7bcde41bf9432c21f604e489.camel@zoho.com> <755705e37731c4fbc3ab7eb1a96d8df0147bb002.camel@redhat.com> Autocrypt: addr=bouanto@zoho.com; prefer-encrypt=mutual; keydata=mQENBFOSMLQBCADO5aw6Ys8thMQUNzrwAnfJX2wbgWiz0pQ01DjYj22eeIpChkoZn6LWdt4dieq30u2rFi/yQzJ02foHwI2+aL9rU6xz/x4TwqyRJQGMOqklNc3R+pdXmH4WDQkQDWmLxvc07vu+zb8Tx5A6pMDh4J2ncCEhLEUcH39Yq/yg4eBnFwUX6N7kakvHrnScGNqhnSFCacoJeMJUAR+1G7VBSBd++jmnHLnx3mj7QkRZVECJUw2zqiv1yReCC6GU4SvqLjdqm5ZGeoWOqD/NHjBRoEeOVjzp6M/qOjjWRbkJVqmvgfcD8UytSSqqboR35YFT4L+rZt2ri3T12MJb3i5syCAXABEBAAG0IUFudG9uaSBCb3VjaGVyIDxib3VhbnRvQHpvaG8uY29tPokBVgQTAQgAQAIbIwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAFiEEOELC4Uw1Jeb66YE6RVeGAwR4zcEFAlz4QM4FCRLMEZoACgkQRVeGAwR4zcFBQQf/afttJrA/puADQZhrDfkgr0MFvq6iB+GCy1b8BkXimk1TOXTPt87YLehSeijNu3JkYhl5eRc87BNfU9J87KfI/KIy6hZxqlDXk16FhW9bw/7wYEA0hpb3MUn7xLElXDT0ZHaD+KTe8Oun7qfzgx5RlL6r/WODf3CkSpO085R/rfeBqDEx9mVlhDWgq6Az3CZoD+3CqiCKVqmDuHTWz4kwrd9AM5eVcLvvLKnZIdoIp+G5Ao6BvaGlZyfenN1iOSjLy2NXNt4MnUt0lUYEP5KSIIRhHQ8xkUbj7eWUmaahkxhNb3fH3sAPwGnRZrPpb4rgYzNmSk63wWMh9M2xk+rLb7kBDQRTkjC0AQgAumZzsAV/UFWI+dpzebQfma36kKYZZFuseant5sq/HWP553XQ/U6ttJiKyN5MpCqtxvCAoRplf42YhlHuFqgf73WJxoJ6Y+sdyqoBSwlR+ gzAneAmsa8gmmY0wawH0Z2leazjKuS7mJjVEQZg0ZGsiCVRGeRnDqFGzDEzDc9ngWKSoTq0fKzlGy1X85OrtmUrvEbhSo6HP+FoeunHkIqrxu3w3vDoFEXxVQlKI6V3I4nCz5n6DB8WR3L7nsiiTnOiGirPw1ngvWFLW86kkA4FJpayc8Xl3va3SLY+2y4yuROboX2DVI4AC/Qeug/mDiBicPxkP6YfUartQRMe6obkEQARAQABiQE8BBgBCAAmAhsMFiEEOELC4Uw1Jeb66YE6RVeGAwR4zcEFAlz4QRsFCRLMEecACgkQRVeGAwR4zcE56ggAgTgrJInBKC+7552Dpccuo6Clh3wZfjlNLv9/6r5lKEbaNzaTrfhPiAP4WgnluIUmj8amOFLFJpj+BAVNOXpZ4D2R3o9ch8z7fot+fW4Yw+PKIxH4I2xEys8ndoEB3aiQwHjKcGIhkIU7uyMJFQr2aWjdTY0gmXw0YZueHOSLgo7uX4XKxB8fEO/yto/Tff2YBAAq+AtNwt+Gh5YS9rZw7rwUTWMi84yVOlc+zRE79E9NJkvdTwX7IJYo64VzIRNfgHsn7QNdVzuM1XIFHl+Glk6cIlI8s6BO7nEoCn3hTF104fQTAO3fEs+XXZOKXo2lk8faowEoPq5r58StrV0nyg== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.3 MIME-Version: 1.0 Feedback-ID: rr08011228c644e2e669cace39df1dcd3a0000543a82771643fd59975d1c5027c71bb217a975a3add72e2e60ac:zu08011226cefebe4c4df6d8c101b90b0100009dcd9b13e877b2e7808ca382ab1cac2a2204c30cd5be3e39:rf08011232c3497f5c387b25023e846b87000065f82c6c84864d0e1d0a38f96dfce49b844e83cf24d07ba6278533af3c8319e406742d21:ZohoMail X-ZohoMailClient: External X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: CC-ing Iain in case they can do the review since it is based on how they did it in the D frontend. Could you please do the review? Thanks! On Thu, 2023-11-09 at 18:04 -0500, David Malcolm wrote: > On Thu, 2023-11-09 at 17:27 -0500, Antoni Boucher wrote: > > Hi. > > This patch adds support for getting the CPU features in libgccjit > > (bug > > 112466) > >=20 > > There's a TODO in the test: > > I'm not sure how to test that gcc_jit_target_info_arch returns the > > correct value since it is dependant on the CPU. > > Any idea on how to improve this? > >=20 > > Also, I created a CStringHash to be able to have a > > std::unordered_set. Is there any built-in way of > > doing > > this? >=20 > Thanks for the patch. >=20 > Some high-level questions: >=20 > Is this specifically about detecting capabilities of the host that > libgccjit is currently running on? or how the target was configured > when libgccjit was built? >=20 > One of the benefits of libgccjit is that, in theory, we support all > of > the targets that GCC already supports.=C2=A0 Does this patch change that, > or > is this more about giving client code the ability to determine > capabilities of the specific host being compiled for? >=20 > I'm nervous about having per-target jit code.=C2=A0 Presumably there's a > reason that we can't reuse existing target logic here - can you > please > describe what the problem is.=C2=A0 I see that the ChangeLog has: >=20 > > * config/i386/i386-jit.cc: New file. >=20 > where i386-jit.cc has almost 200 lines of nontrivial code.=C2=A0 Where di= d > this come from?=C2=A0 Did you base it on existing code in our source tree= , > making modifications to fit the new internal API, or did you write it > from scratch?=C2=A0 In either case, how onerous would this be for other > targets? >=20 > I'm not at expert at target hooks (or at the i386 backend), so if we > do > go with this approach I'd want someone else to review those parts of > the patch. >=20 > Have you verified that GCC builds with this patch with jit *not* > enabled in the enabled languages? >=20 > [...snip...] >=20 > A nitpick: >=20 > > +.. function:: const char * \ > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 gcc_jit_target_info_arch (gcc_jit_target_info *info) > > + > > +=C2=A0=C2=A0 Get the architecture of the currently running CPU. >=20 > What does this string look like? > How long does the pointer remain valid? >=20 > Thanks again; hope the above makes sense > Dave >=20