From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 6F6E63857025 for ; Thu, 8 Jul 2021 20:44:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6F6E63857025 Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-211-NZ55op5ANH66pLVpbUGggg-1; Thu, 08 Jul 2021 16:44:52 -0400 X-MC-Unique: NZ55op5ANH66pLVpbUGggg-1 Received: by mail-qv1-f72.google.com with SMTP id gf3-20020a0562142503b02902b1b968a608so4880188qvb.16 for ; Thu, 08 Jul 2021 13:44:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=4JNaMkTQYYRelO3o+4B69SnjtiJPYHWEY6mPltChFl8=; b=k26ue5GhStRsUykoDRXEu+4pwoCjYIuxnuDaRJ7SKy7hbIdE3+VI/vh3e6rcQp6aDG aHW2gxp/Hk8GLp5L1LjGX3U3yaEq75m+omWfq6qUNcT0xv3sfzhTdU9cG2o05RlvWU5Y /lIuCIgAFCnIqFerGjaaV0XIHXWF2WFHVh+qfwrrVJzgpcy3S5blvlHtI6+45nkFD344 zb8fqKtQsZHfu99/nas2f+Ni1q2c7Ko1WFn1WPJw00epTsLRmJrywl3wtx2u1cWyjiWc IyCX0xl2ZHTlDQQcnJo742qn78WJdLItSG2JqUw396Ex+kc04CLdquR/q5GjE4TmhSmw w7yQ== X-Gm-Message-State: AOAM531mF7NY/SVYYPiHBV/55UH6Dwvsqbyj9UhjLnVfYF6o1WBvnSEb 97+YNPJjcHvx7zoOO7roxzevZS1Ib1rkARgeg5FlNZlR4DPSXQDee6BFNjNyyPmtqU7qjGyqlA4 01B9RXXE= X-Received: by 2002:a05:622a:138e:: with SMTP id o14mr746549qtk.185.1625777092491; Thu, 08 Jul 2021 13:44:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxhDm0VO9zKuNko6qXYJBimyLk4KmWq2I8dDOBMIw5SsUHNg+Mt0/Bw2bnRQrG9RylvFpU7ww== X-Received: by 2002:a05:622a:138e:: with SMTP id o14mr746540qtk.185.1625777092328; Thu, 08 Jul 2021 13:44:52 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.ma.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id o10sm1357932qtv.62.2021.07.08.13.44.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jul 2021 13:44:51 -0700 (PDT) Message-ID: Subject: Re: [PATCH] libgccjit: Handle truncation and extension for casts [PR 95498] From: David Malcolm To: Antoni Boucher , Bernhard Reutner-Fischer Cc: jit@gcc.gnu.org Date: Thu, 08 Jul 2021 16:44:50 -0400 In-Reply-To: References: <20200713003002.bs5hwv4gav6ml5rt@bouanto-laptop.localdomain> <874ki6txcc.fsf@tromey.com> <20210220221706.ewfq2b3i2mzx4ice@bouanto-desktop.localdomain> <3ae55b5acc33b38c579ac9c293993c29adc55ae9.camel@redhat.com> <597ecec1c91c1176f740796e20432372377aa554.camel@redhat.com> <0f7f2bf386c29efa1403020cbb02bec815ce25fe.camel@zoho.com> <651ead30f4fa016c233c203bd5d3e749273ab92b.camel@redhat.com> <8d782bf220cc81c727f842b21d835b5b991d3a35.camel@zoho.com> <1f12388082367de4e8d2ea8fe802c22efd50c109.camel@redhat.com> <4834aac911b9fc1f58d0e9cea8773775aad2a23e.camel@zoho.com> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jul 2021 20:44:56 -0000 On Tue, 2021-07-06 at 09:00 -0400, Antoni Boucher wrote: > I updated the patch to fix this. > I'm sending the patch once again for review. > Thanks. Looks good to me. Dave > > Le samedi 19 juin 2021 à 11:08 +0200, Bernhard Reutner-Fischer a > écrit : > > On 18 June 2021 23:11:58 CEST, Antoni Boucher via Gcc-patches > > wrote: > > > Ok. > > > Here's the patch with the updated subject and with format fixed. > > > > +  if (t_ret) > > +      return t_ret; > > +  enum tree_code dst_code = TREE_CODE (dst_type); > > +  switch (dst_code) > > +    { > > > > The enum is redundant. > > /enum tree_code/s/enum // > > thanks, >