Re: [PATCH] libgccjit: Add support for setting the link section of global variables [PR100688]

[David Malcolm <dmalcolm@redhat.com>]

On Sat, 2021-11-20 at 11:53 -0500, Antoni Boucher wrote:
> Hi.
> Here's the updated patch.
> See comments below.
> Thanks for the review!

> 
> Le samedi 20 novembre 2021 à 11:20 -0500, David Malcolm a écrit :
> > On Sat, 2021-11-20 at 00:58 -0500, Antoni Boucher wrote:

[...snip...]


> > 
> > 
> > > > > diff --git a/gcc/testsuite/jit.dg/all-non-failing-tests.h
> > > > b/gcc/testsuite/jit.dg/all-non-failing-tests.h
> > > > > index 4202eb7798b..7e3b59dee0d 100644
> > > > > --- a/gcc/testsuite/jit.dg/all-non-failing-tests.h
> > > > > +++ b/gcc/testsuite/jit.dg/all-non-failing-tests.h
> > > > > @@ -181,6 +181,13 @@
> > > > >  #undef create_code
> > > > >  #undef verify_code
> > > > >  
> > > > > +/* test-link-section.c */
> > > > > +#define create_code create_code_link_section
> > > > > +#define verify_code verify_code_link_section
> > > > > +#include "test-link-section.c"
> > > > > +#undef create_code
> > > > > +#undef verify_code
> > 
> > The updated version of the testcase doesn't have a verify_code, so it
> > can't be in the "testcases" array.  
> > Please replace this with something like:
> > 
> > 
> > /* test-link-section.c: This can't be in the testcases array as it
> >    doesn't have a verify_code implementation.  */
> >  
> > 
> > (I'm trying to have all-nonfailing-tests.h refer to each non-failing
> > test, either adding it to the testcases array, or documenting why it
> > isn't in the array; listing them in alphabetical order)
> 
> Hum, that code seems to refer to the previous patch.
> I removed that part and changed the test to test-link-section-
> assembler.c which checks that the assembly contains the link section.
> As far as I know, it does not need to be listed here to be ran.

Right, it's just a comment.  It's not to be run here, I'm just trying
to document those tests that aren't being as part of the
threads/combination tests, since it's so easy to accidentally omit them
when adding a new test - ideally all-non-failing-tests.h will mention
all of the tests that don't have "error" in their titles, either adding
them to the "testcases" array, or documenting why they're not in the
array, with a comment like the one I suggested above (feel free to
directly use that).

[...snip...]

> > 
> > Overall the patch looks good, my comments are all just nit-picks at
> > this point, except that obviously you need to finish updating the
> > symbol name to "section_name" in gcc_jit_lvalue_set_link_section so
> > that it compiles.  Please check it compiles and that the testsuite
> > passes before pushing - though I think this is waiting on another
> > patch, right?  This is OK for trunk, once those fixes and
> > prerequisites
> > are taken care of.
> > 
> > Thanks again
> > Dave

Looks good for trunk, once the earlier patch is in.  As before, please
do a test build and run the testsuite before pushing.

Thanks for the updated patch.
Dave