From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E4C53385840D for ; Sat, 20 Nov 2021 18:27:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E4C53385840D Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-237-4DmEHuh7O7aIiXqF79OI0w-1; Sat, 20 Nov 2021 13:27:35 -0500 X-MC-Unique: 4DmEHuh7O7aIiXqF79OI0w-1 Received: by mail-qt1-f198.google.com with SMTP id y25-20020ac87059000000b002a71d24c242so9166334qtm.0 for ; Sat, 20 Nov 2021 10:27:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=/2rUkN+PVN3I2ysmRjm264AXtdZ9Wmjiv7qbXwIDHBk=; b=FZPdDfegeYMk7Fc5CZzrW/vkfGmxjDN6BvLn4W1uRCtdOCwtbLcNl5LX8ntAiJqASm 1WvPMslSOmSmud4OWOZmJJYEcV7l3AUdJy7PrjXTcnKPoxmOehx6arYttD6N/k+J4Pc3 9hmoMuMrbD8xsAUQvVcU2oqKQPUNkLrWouwiXriBXYphGJ4fVZ7LARZC0kIpWFuJEbIA zYZH8oaypgrbA2/JHjbQIGkY1GfpVlezRqF7JwLZ5TDbbA/mssKndHjsw+5oJUsH1O/U ip6tJIPQmSnOixnYTfQdE3TBFjcejBih/0ZYTAhBaW0UrEKwgm41p46UQnFAsbOVtV1j vz/g== X-Gm-Message-State: AOAM532H2K7VPw6BPaGDC+RNQiNmab8PqCxyzc343RplCBnFfNMD4tm1 H7PnUqZrRwLj5koW50ROCIz/rQJPbv/MYojHCxF9gomvCtoQsWhJkKR5SW3JguTSYrLOfhOepAd waIaWNDM= X-Received: by 2002:ad4:40c6:: with SMTP id x6mr84362878qvp.32.1637432854687; Sat, 20 Nov 2021 10:27:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJxuhW8FzgG1imI+4QW0pl0PjVZ/ZP0DtIAH/FBl11UVu1/tDCCG85h2u4+k0ljDS6kibxIK8w== X-Received: by 2002:ad4:40c6:: with SMTP id x6mr84362855qvp.32.1637432854451; Sat, 20 Nov 2021 10:27:34 -0800 (PST) Received: from t14s.localdomain (c-73-69-212-193.hsd1.nh.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id u10sm1817946qtx.3.2021.11.20.10.27.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Nov 2021 10:27:33 -0800 (PST) Message-ID: Subject: Re: [PATCH] libgccjit: Add support for setting the link section of global variables [PR100688] From: David Malcolm To: Antoni Boucher , jit@gcc.gnu.org, gcc-patches@gcc.gnu.org Date: Sat, 20 Nov 2021 13:27:32 -0500 In-Reply-To: References: <7fde146d8c3aecb47f66f34c836e2733eb4d8a6d.camel@zoho.com> <7530c6bca7aab2a29303957512be97cf090e159d.camel@redhat.com> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-14.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=unavailable autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Nov 2021 18:27:38 -0000 On Sat, 2021-11-20 at 11:53 -0500, Antoni Boucher wrote: > Hi. > Here's the updated patch. > See comments below. > Thanks for the review! > > Le samedi 20 novembre 2021 à 11:20 -0500, David Malcolm a écrit : > > On Sat, 2021-11-20 at 00:58 -0500, Antoni Boucher wrote: [...snip...] > > > > > > > > > diff --git a/gcc/testsuite/jit.dg/all-non-failing-tests.h > > > > b/gcc/testsuite/jit.dg/all-non-failing-tests.h > > > > > index 4202eb7798b..7e3b59dee0d 100644 > > > > > --- a/gcc/testsuite/jit.dg/all-non-failing-tests.h > > > > > +++ b/gcc/testsuite/jit.dg/all-non-failing-tests.h > > > > > @@ -181,6 +181,13 @@ > > > > >  #undef create_code > > > > >  #undef verify_code > > > > >   > > > > > +/* test-link-section.c */ > > > > > +#define create_code create_code_link_section > > > > > +#define verify_code verify_code_link_section > > > > > +#include "test-link-section.c" > > > > > +#undef create_code > > > > > +#undef verify_code > > > > The updated version of the testcase doesn't have a verify_code, so it > > can't be in the "testcases" array.  > > Please replace this with something like: > > > > > > /* test-link-section.c: This can't be in the testcases array as it > >    doesn't have a verify_code implementation.  */ > >   > > > > (I'm trying to have all-nonfailing-tests.h refer to each non-failing > > test, either adding it to the testcases array, or documenting why it > > isn't in the array; listing them in alphabetical order) > > Hum, that code seems to refer to the previous patch. > I removed that part and changed the test to test-link-section- > assembler.c which checks that the assembly contains the link section. > As far as I know, it does not need to be listed here to be ran. Right, it's just a comment. It's not to be run here, I'm just trying to document those tests that aren't being as part of the threads/combination tests, since it's so easy to accidentally omit them when adding a new test - ideally all-non-failing-tests.h will mention all of the tests that don't have "error" in their titles, either adding them to the "testcases" array, or documenting why they're not in the array, with a comment like the one I suggested above (feel free to directly use that). [...snip...] > > > > Overall the patch looks good, my comments are all just nit-picks at > > this point, except that obviously you need to finish updating the > > symbol name to "section_name" in gcc_jit_lvalue_set_link_section so > > that it compiles.  Please check it compiles and that the testsuite > > passes before pushing - though I think this is waiting on another > > patch, right?  This is OK for trunk, once those fixes and > > prerequisites > > are taken care of. > > > > Thanks again > > Dave Looks good for trunk, once the earlier patch is in. As before, please do a test build and run the testsuite before pushing. Thanks for the updated patch. Dave