From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sender4-pp-o91.zoho.com (sender4-pp-o91.zoho.com [136.143.188.91]) by sourceware.org (Postfix) with ESMTPS id 15EEC3857439 for ; Thu, 8 Jul 2021 21:28:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 15EEC3857439 ARC-Seal: i=1; a=rsa-sha256; t=1625779724; cv=none; d=zohomail.com; s=zohoarc; b=ZPRPEXVGUjkQ1sVdm/5KJf3SXmOKxjKl7ZZ563JwVbmWLZVtrz9tco8AaU0g+K/wqPo7p1O5r7VB5Za/RlwyR/hC95RXVrF9+aoryPRwNskNP5r3zovj+Y+6eDnZoDgYqWdvNjZKs+5yvK2NokcXn9HSV1coKFHnenG6S2SwHtQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625779724; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=NGCF3q86f04cJNdMe9m8e3ihf7qm49S5Ovrc9TfCqEw=; b=FW6jOcEyyVyW4HwX8bifVPVE8fByCZbbyemVlcCOmWAU4wP2BjLihwKn7l7D94M7pAAArZLhI1jnffcjl7SZHrWDWWoDBtwHTWijNbwILMoqLlvsxLOK7tqOkFMYapeN0l0W6SzGNVBrGgKpv4RzZZV3oGg6LNrhxO0ucyWqNo0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zoho.com; spf=pass smtp.mailfrom=bouanto@zoho.com; dmarc=pass header.from= Received: from [192.168.1.174] (38.87.11.6 [38.87.11.6]) by mx.zohomail.com with SMTPS id 1625779722582990.63195319817; Thu, 8 Jul 2021 14:28:42 -0700 (PDT) Message-ID: Subject: Re: [PATCH] libgccjit: Handle truncation and extension for casts [PR 95498] From: Antoni Boucher To: David Malcolm , Bernhard Reutner-Fischer Cc: jit@gcc.gnu.org Date: Thu, 08 Jul 2021 17:28:40 -0400 In-Reply-To: References: <20200713003002.bs5hwv4gav6ml5rt@bouanto-laptop.localdomain> <874ki6txcc.fsf@tromey.com> <20210220221706.ewfq2b3i2mzx4ice@bouanto-desktop.localdomain> <3ae55b5acc33b38c579ac9c293993c29adc55ae9.camel@redhat.com> <597ecec1c91c1176f740796e20432372377aa554.camel@redhat.com> <0f7f2bf386c29efa1403020cbb02bec815ce25fe.camel@zoho.com> <651ead30f4fa016c233c203bd5d3e749273ab92b.camel@redhat.com> <8d782bf220cc81c727f842b21d835b5b991d3a35.camel@zoho.com> <1f12388082367de4e8d2ea8fe802c22efd50c109.camel@redhat.com> <4834aac911b9fc1f58d0e9cea8773775aad2a23e.camel@zoho.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jul 2021 21:28:49 -0000 Is this the approval for write or are we not there yet? Le jeudi 08 juillet 2021 =C3=A0 16:44 -0400, David Malcolm a =C3=A9crit=C2= =A0: > On Tue, 2021-07-06 at 09:00 -0400, Antoni Boucher wrote: > > I updated the patch to fix this. > > I'm sending the patch once again for review. > > Thanks. >=20 > Looks good to me. >=20 > Dave >=20 > >=20 > > Le samedi 19 juin 2021 =C3=A0 11:08 +0200, Bernhard Reutner-Fischer a > > =C3=A9crit=C2=A0: > > > On 18 June 2021 23:11:58 CEST, Antoni Boucher via Gcc-patches > > > wrote: > > > > Ok. > > > > Here's the patch with the updated subject and with format > > > > fixed. > > >=20 > > > +=C2=A0 if (t_ret) > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return t_ret; > > > +=C2=A0 enum tree_code dst_code =3D TREE_CODE (dst_type); > > > +=C2=A0 switch (dst_code) > > > +=C2=A0=C2=A0=C2=A0 { > > >=20 > > > The enum is redundant. > > > /enum tree_code/s/enum // > > > thanks, > >=20 >=20 >=20