From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sender4-pp-o90.zoho.com (sender4-pp-o90.zoho.com [136.143.188.90]) by sourceware.org (Postfix) with ESMTPS id 038953858D33; Thu, 23 Nov 2023 22:21:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 038953858D33 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=zoho.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=zoho.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 038953858D33 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=136.143.188.90 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700778116; cv=pass; b=u8mfOuRQ0qhneIX8Y9r+EuP3DUvZ4ZGjdBD908LF3o3ErZtpW3bNMIM0t2GRNlK3YeTmuGSCoeKHoHwjrtu2udyY5bQSyVJj2+abcXfWwuvfH63DzTb2mOuGXckb7jq3Ro1H7FyvhtJ3/wgWRHX8Acs+EvfkEbfuBOyGluX+jFc= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700778116; c=relaxed/simple; bh=qqgXNFuZHkRWhfw4+rJgriQbJ/FiUfh1IuLLUyoADo4=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=WKJCR+NvVCZ+PQjo+qZhZ4+SFEliXtr9B8FK/MyUndcdV3MFMXzzqJ30EoM7LlU8vzWK+NEqtFQhTqIPvwhlqiaPmN/WYNQStUGs6AD6LFGuJDfwkNjllSixBzoalhYQiwe9wGgQClHMZm1dSKahVLlOvvcQ+gBFhKSG9KEkyL0= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; t=1700778109; cv=none; d=zohomail.com; s=zohoarc; b=kgAxwZ/wHUZKUSUVBlpxIuuMQY4HaNRHCzB10Bv+aS2ltPd4Y1V6BfIykIYhiFv6oYWNZhsBwkZizzWNEsAeI7JAVEXMW8LUCIw0YJYN2iK3DsHMChWe7zytbPIwFBYOP86FSwxCs8MgEDNcRPUGQpnTcsyyqYtquPUWgHPMS7w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1700778109; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=qqgXNFuZHkRWhfw4+rJgriQbJ/FiUfh1IuLLUyoADo4=; b=SpbDN0UvPuR4Mz7pSYyh6Ut7FZz5n2Bu5jZ3AtHkMv3eurAgn2t7scmY9j6FmrzhkOZoXTkkqLrPVTyk1SGnXOIeTEorWUOiBRwwuuYUSey2+/Q8c/hB6rncl9OU0+t/BwHhKX5ONnnWbUK9r2B+cE/COb7X4/jINuXDX44ijXg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zoho.com; spf=pass smtp.mailfrom=bouanto@zoho.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1700778109; s=zm2022; d=zoho.com; i=bouanto@zoho.com; h=Message-ID:Subject:Subject:From:From:To:To:Cc:Cc:Date:Date:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:MIME-Version:Feedback-ID:Message-Id:Reply-To; bh=qqgXNFuZHkRWhfw4+rJgriQbJ/FiUfh1IuLLUyoADo4=; b=TDY/r76rowacQFYjDVJMdfhCDXsduBSjZFs5ZvGj0fA18tNz818xoSj/5Sz67x5R 5kp5PmfVkzUicQ8wCA/VxLeH6Go1CFN9USGDLC/NnKATv9Rpdv188lvVNIkEiW1nF+0 u7uxD9Dfaarah1FBybNTm7/5p6Yhu/0vX+y3VWaQ= Received: from [192.168.1.172] (38.87.11.6 [38.87.11.6]) by mx.zohomail.com with SMTPS id 1700778107711114.33068871962632; Thu, 23 Nov 2023 14:21:47 -0800 (PST) Message-ID: Subject: Re: [PATCH] libgccjit: Add support for machine-dependent builtins From: Antoni Boucher To: Andrew Pinski Cc: jit@gcc.gnu.org, gcc-patches@gcc.gnu.org, David Malcolm Date: Thu, 23 Nov 2023 17:21:46 -0500 In-Reply-To: <9d88efbf2bda979ff0b7291714c0dd7b02a8e7ff.camel@zoho.com> References: <184790403bd8227db4054b9e672afbfdf879dc0c.camel@zoho.com> <9d88efbf2bda979ff0b7291714c0dd7b02a8e7ff.camel@zoho.com> Autocrypt: addr=bouanto@zoho.com; prefer-encrypt=mutual; keydata=mQENBFOSMLQBCADO5aw6Ys8thMQUNzrwAnfJX2wbgWiz0pQ01DjYj22eeIpChkoZn6LWdt4dieq30u2rFi/yQzJ02foHwI2+aL9rU6xz/x4TwqyRJQGMOqklNc3R+pdXmH4WDQkQDWmLxvc07vu+zb8Tx5A6pMDh4J2ncCEhLEUcH39Yq/yg4eBnFwUX6N7kakvHrnScGNqhnSFCacoJeMJUAR+1G7VBSBd++jmnHLnx3mj7QkRZVECJUw2zqiv1yReCC6GU4SvqLjdqm5ZGeoWOqD/NHjBRoEeOVjzp6M/qOjjWRbkJVqmvgfcD8UytSSqqboR35YFT4L+rZt2ri3T12MJb3i5syCAXABEBAAG0IUFudG9uaSBCb3VjaGVyIDxib3VhbnRvQHpvaG8uY29tPokBVgQTAQgAQAIbIwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAFiEEOELC4Uw1Jeb66YE6RVeGAwR4zcEFAlz4QM4FCRLMEZoACgkQRVeGAwR4zcFBQQf/afttJrA/puADQZhrDfkgr0MFvq6iB+GCy1b8BkXimk1TOXTPt87YLehSeijNu3JkYhl5eRc87BNfU9J87KfI/KIy6hZxqlDXk16FhW9bw/7wYEA0hpb3MUn7xLElXDT0ZHaD+KTe8Oun7qfzgx5RlL6r/WODf3CkSpO085R/rfeBqDEx9mVlhDWgq6Az3CZoD+3CqiCKVqmDuHTWz4kwrd9AM5eVcLvvLKnZIdoIp+G5Ao6BvaGlZyfenN1iOSjLy2NXNt4MnUt0lUYEP5KSIIRhHQ8xkUbj7eWUmaahkxhNb3fH3sAPwGnRZrPpb4rgYzNmSk63wWMh9M2xk+rLb7kBDQRTkjC0AQgAumZzsAV/UFWI+dpzebQfma36kKYZZFuseant5sq/HWP553XQ/U6ttJiKyN5MpCqtxvCAoRplf42YhlHuFqgf73WJxoJ6Y+sdyqoBSwlR+ gzAneAmsa8gmmY0wawH0Z2leazjKuS7mJjVEQZg0ZGsiCVRGeRnDqFGzDEzDc9ngWKSoTq0fKzlGy1X85OrtmUrvEbhSo6HP+FoeunHkIqrxu3w3vDoFEXxVQlKI6V3I4nCz5n6DB8WR3L7nsiiTnOiGirPw1ngvWFLW86kkA4FJpayc8Xl3va3SLY+2y4yuROboX2DVI4AC/Qeug/mDiBicPxkP6YfUartQRMe6obkEQARAQABiQE8BBgBCAAmAhsMFiEEOELC4Uw1Jeb66YE6RVeGAwR4zcEFAlz4QRsFCRLMEecACgkQRVeGAwR4zcE56ggAgTgrJInBKC+7552Dpccuo6Clh3wZfjlNLv9/6r5lKEbaNzaTrfhPiAP4WgnluIUmj8amOFLFJpj+BAVNOXpZ4D2R3o9ch8z7fot+fW4Yw+PKIxH4I2xEys8ndoEB3aiQwHjKcGIhkIU7uyMJFQr2aWjdTY0gmXw0YZueHOSLgo7uX4XKxB8fEO/yto/Tff2YBAAq+AtNwt+Gh5YS9rZw7rwUTWMi84yVOlc+zRE79E9NJkvdTwX7IJYo64VzIRNfgHsn7QNdVzuM1XIFHl+Glk6cIlI8s6BO7nEoCn3hTF104fQTAO3fEs+XXZOKXo2lk8faowEoPq5r58StrV0nyg== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.1 MIME-Version: 1.0 Feedback-ID: rr080112281752f55814e08f6008609517000075f781946a4e7364994c0290b3d1c4f13b65a5b7eb0a76294c81:zu08011226f64ee29b92395e5626046aef00005ae46e5e98a48c3259033d2793c56332489d2f564296f1a7:rf08011232bcdf21391e1834d1b75d5f0f0000d90b75bf85e5b88319044a3978a05ad98e1ff2731cbc529c9628282d5c34fdd91219c6a4:ZohoMail X-ZohoMailClient: External X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I will need to not forget to update the function tree_type_to_jit_type in dummy-frontend.cc to add back the support for bfloat16 when the patch for it is merged. On Thu, 2023-11-23 at 17:17 -0500, Antoni Boucher wrote: > Hi. > I did split the patch and sent one for the bfloat16 support and > another > one for the vector support. >=20 > Here's the updated patch for the machine-dependent builtins. >=20 > Regards. >=20 > On Sat, 2023-02-11 at 17:37 -0800, Andrew Pinski wrote: > > On Sat, Feb 11, 2023 at 4:31 PM Antoni Boucher via Gcc-patches > > wrote: > > >=20 > > > Hi. > > > This patch adds support for machine-dependent builtins in > > > libgccjit > > > (bug 108762). > > >=20 > > > There are two things I don't like in this patch: > > >=20 > > > =C2=A01. There are a few functions copied from the C frontend > > > (common_mark_addressable_vec and a few others). > > >=20 > > > =C2=A02. Getting a target builtin only works from the second > > > compilation > > > since the type information is recorded at the first compilation. > > > I > > > couldn't find a way to get the builtin data without using the > > > langhook. > > > It is necessary to get the type information for type checking and > > > instrospection. > > >=20 > > > Any idea how to fix these issues? > >=20 > > Seems like you should do this patch in a few steps; that is split > > it > > up. > > Definitely split out GCC_JIT_TYPE_BFLOAT16 support. > > I also think the vector support should be in a different patch too. > >=20 > > Splitting out these parts would definitely make it easier for > > review > > and make incremental improvements. > >=20 > > Thanks, > > Andrew Pinski > >=20 > >=20 > >=20 > > >=20 > > > Thanks for the review. >=20