From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sender4-pp-o91.zoho.com (sender4-pp-o91.zoho.com [136.143.188.91]) by sourceware.org (Postfix) with ESMTPS id 964053888816 for ; Tue, 6 Jul 2021 13:01:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 964053888816 ARC-Seal: i=1; a=rsa-sha256; t=1625576459; cv=none; d=zohomail.com; s=zohoarc; b=P5M2jFxFXDAzx9pJlTNDvxz+lHvDzgevh3nAJfujSwC5pshGnABOjhS0qEOvNOpIdHgmk2Yi6AIgVd44LaFdqAcEiF+xGNx2dmzK+d3+JUuSjRHG2iM5mkaJ7RpdaaVht0yM+JwMu3xk+r7qdLPREFoRpRXwgkjY+uzf19ezqhs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625576459; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=sCk7zIERKgRSS6vRaFiyYTouAl3sF7LPWwWHHlINZDo=; b=XtAJvXey3JGCIjVva1PSkUholzl7ZswhWhpkDyWC8p+BmxMZvH+b14/g0XJTfbXd9Hs9tKvEWAS0gwHO5eYQSqsWR4Ourz1q6N00CwRbiKKcEMMaAcvFEp/9ehLB7G4Aih5NOcdM0y9LDE6z6K0gD/WZ735fJCmHz9oOfTjfBFk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zoho.com; spf=pass smtp.mailfrom=bouanto@zoho.com; dmarc=pass header.from= Received: from [192.168.1.174] (38.87.11.6 [38.87.11.6]) by mx.zohomail.com with SMTPS id 1625576455237372.01809097893806; Tue, 6 Jul 2021 06:00:55 -0700 (PDT) Message-ID: Subject: Re: [PATCH] libgccjit: Handle truncation and extension for casts [PR 95498] From: Antoni Boucher To: Bernhard Reutner-Fischer , David Malcolm Cc: jit@gcc.gnu.org Date: Tue, 06 Jul 2021 09:00:53 -0400 In-Reply-To: References: <20200713003002.bs5hwv4gav6ml5rt@bouanto-laptop.localdomain> <874ki6txcc.fsf@tromey.com> <20210220221706.ewfq2b3i2mzx4ice@bouanto-desktop.localdomain> <3ae55b5acc33b38c579ac9c293993c29adc55ae9.camel@redhat.com> <597ecec1c91c1176f740796e20432372377aa554.camel@redhat.com> <0f7f2bf386c29efa1403020cbb02bec815ce25fe.camel@zoho.com> <651ead30f4fa016c233c203bd5d3e749273ab92b.camel@redhat.com> <8d782bf220cc81c727f842b21d835b5b991d3a35.camel@zoho.com> <1f12388082367de4e8d2ea8fe802c22efd50c109.camel@redhat.com> <4834aac911b9fc1f58d0e9cea8773775aad2a23e.camel@zoho.com> Content-Type: multipart/mixed; boundary="=-ERNa8Ur4CUIYyJnwecXl" User-Agent: Evolution 3.40.2 MIME-Version: 1.0 X-Zoho-Virus-Status: 1 X-ZohoMailClient: External X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jul 2021 13:01:13 -0000 --=-ERNa8Ur4CUIYyJnwecXl Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I updated the patch to fix this. I'm sending the patch once again for review. Thanks. Le samedi 19 juin 2021 =C3=A0 11:08 +0200, Bernhard Reutner-Fischer a =C3=A9crit=C2=A0: > On 18 June 2021 23:11:58 CEST, Antoni Boucher via Gcc-patches > wrote: > > Ok. > > Here's the patch with the updated subject and with format fixed. >=20 > +=C2=A0 if (t_ret) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return t_ret; > +=C2=A0 enum tree_code dst_code =3D TREE_CODE (dst_type); > +=C2=A0 switch (dst_code) > +=C2=A0=C2=A0=C2=A0 { >=20 > The enum is redundant. > /enum tree_code/s/enum // > thanks, --=-ERNa8Ur4CUIYyJnwecXl Content-Disposition: attachment; filename*0=0001-libgccjit-Handle-truncation-and-extension-for-casts-.pat; filename*1=ch Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-libgccjit-Handle-truncation-and-extension-for-casts-.patch"; charset="UTF-8" RnJvbSA0NjQ3NDQ3YWVmMzRmNjNhOTQxNDc4OTJiOWUzYWJjMDYxYmFmMTg0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmkgQm91Y2hlciA8Ym91YW50b0B6b2hvLmNvbT4KRGF0 ZTogU3VuLCA1IEp1bCAyMDIwIDE5OjA3OjMwIC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gbGliZ2Nj aml0OiBIYW5kbGUgdHJ1bmNhdGlvbiBhbmQgZXh0ZW5zaW9uIGZvciBjYXN0cwogW1BSOTU0OThd CgoyMDIwLTA3LTEyICBBbnRvbmkgQm91Y2hlciAgPGJvdWFudG9Aem9oby5jb20+CgpnY2Mvaml0 LwoJUFIgdGFyZ2V0Lzk1NDk4CgkqIGppdC1wbGF5YmFjay5jIChjb252ZXJ0KTogQWRkIHN1cHBv cnQgdG8gaGFuZGxlIHRydW5jYXRpb24gYW5kCglleHRlbnNpb24gaW4gdGhlIGNvbnZlcnQgZnVu Y3Rpb24uCgpnY2MvdGVzdHN1aXRlLwoJUFIgdGFyZ2V0Lzk1NDk4CgkqIGppdC5kZy9hbGwtbm9u LWZhaWxpbmctdGVzdHMuaDogTmV3IHRlc3QuCgkqIGppdC5kZy90ZXN0LWNhc3QuYzogTmV3IHRl c3QuCgpTaWduZWQtb2ZmLWJ5OiBBbnRvbmkgQm91Y2hlciA8Ym91YW50b0B6b2hvLmNvbT4KLS0t CiBnY2Mvaml0L2ppdC1wbGF5YmFjay5jICAgICAgICAgICAgICAgICAgICAgICB8IDMyICsrKysr Ky0tLS0KIGdjYy90ZXN0c3VpdGUvaml0LmRnL2FsbC1ub24tZmFpbGluZy10ZXN0cy5oIHwgMTAg KysrCiBnY2MvdGVzdHN1aXRlL2ppdC5kZy90ZXN0LWNhc3QuYyAgICAgICAgICAgICB8IDY2ICsr KysrKysrKysrKysrKysrKysrCiAzIGZpbGVzIGNoYW5nZWQsIDk3IGluc2VydGlvbnMoKyksIDEx IGRlbGV0aW9ucygtKQogY3JlYXRlIG1vZGUgMTAwNjQ0IGdjYy90ZXN0c3VpdGUvaml0LmRnL3Rl c3QtY2FzdC5jCgpkaWZmIC0tZ2l0IGEvZ2NjL2ppdC9qaXQtcGxheWJhY2suYyBiL2djYy9qaXQv aml0LXBsYXliYWNrLmMKaW5kZXggYzYxMzYzMDEyNDMuLjc5YWM1MjVlNWRmIDEwMDY0NAotLS0g YS9nY2Mvaml0L2ppdC1wbGF5YmFjay5jCisrKyBiL2djYy9qaXQvaml0LXBsYXliYWNrLmMKQEAg LTYyLDIyICs2MiwzMiBAQCBhbG9uZyB3aXRoIEdDQzsgc2VlIHRoZSBmaWxlIENPUFlJTkczLiAg SWYgbm90IHNlZQogCiAvKiBnY2M6OmppdDo6cGxheWJhY2s6OmNvbnRleHQ6OmJ1aWxkX2Nhc3Qg dXNlcyB0aGUgY29udmVydC5oIEFQSSwKICAgIHdoaWNoIGluIHR1cm4gcmVxdWlyZXMgdGhlIGZy b250ZW5kIHRvIHByb3ZpZGUgYSAiY29udmVydCIKLSAgIGZ1bmN0aW9uLCBhcHBhcmVudGx5IGFz IGEgZmFsbGJhY2suCi0KLSAgIEhlbmNlIHdlIHByb3ZpZGUgdGhpcyBkdW1teSBvbmUsIHdpdGgg dGhlIHJlcXVpcmVtZW50IHRoYXQgYW55IGNhc3RzCi0gICBhcmUgaGFuZGxlZCBiZWZvcmUgcmVh Y2hpbmcgdGhpcy4gICovCisgICBmdW5jdGlvbiwgYXBwYXJlbnRseSBhcyBhIGZhbGxiYWNrIGZv ciBjYXN0cyB0aGF0IGNhbiBiZSBzaW1wbGlmaWVkCisgICAodHJ1bmNhdGlvbiwgZXh0ZW5zaW9u KS4gKi8KIGV4dGVybiB0cmVlIGNvbnZlcnQgKHRyZWUgdHlwZSwgdHJlZSBleHByKTsKIAogdHJl ZQogY29udmVydCAodHJlZSBkc3RfdHlwZSwgdHJlZSBleHByKQogewotICBnY2NfYXNzZXJ0IChn Y2M6OmppdDo6YWN0aXZlX3BsYXliYWNrX2N0eHQpOwotICBnY2M6OmppdDo6YWN0aXZlX3BsYXli YWNrX2N0eHQtPmFkZF9lcnJvciAoTlVMTCwgInVuaGFuZGxlZCBjb252ZXJzaW9uIik7Ci0gIGZw cmludGYgKHN0ZGVyciwgImlucHV0IGV4cHJlc3Npb246XG4iKTsKLSAgZGVidWdfdHJlZSAoZXhw cik7Ci0gIGZwcmludGYgKHN0ZGVyciwgInJlcXVlc3RlZCB0eXBlOlxuIik7Ci0gIGRlYnVnX3Ry ZWUgKGRzdF90eXBlKTsKLSAgcmV0dXJuIGVycm9yX21hcmtfbm9kZTsKKyAgdHJlZSB0X3JldCA9 IE5VTEw7CisgIHRfcmV0ID0gdGFyZ2V0bS5jb252ZXJ0X3RvX3R5cGUgKGRzdF90eXBlLCBleHBy KTsKKyAgaWYgKHRfcmV0KQorICAgICAgcmV0dXJuIHRfcmV0OworICBzd2l0Y2ggKFRSRUVfQ09E RSAoZHN0X3R5cGUpKQorICAgIHsKKyAgICBjYXNlIElOVEVHRVJfVFlQRToKKyAgICBjYXNlIEVO VU1FUkFMX1RZUEU6CisgICAgICByZXR1cm4gZm9sZCAoY29udmVydF90b19pbnRlZ2VyIChkc3Rf dHlwZSwgZXhwcikpOworCisgICAgZGVmYXVsdDoKKyAgICAgIGdjY19hc3NlcnQgKGdjYzo6aml0 OjphY3RpdmVfcGxheWJhY2tfY3R4dCk7CisgICAgICBnY2M6OmppdDo6YWN0aXZlX3BsYXliYWNr X2N0eHQtPmFkZF9lcnJvciAoTlVMTCwgInVuaGFuZGxlZCBjb252ZXJzaW9uIik7CisgICAgICBm cHJpbnRmIChzdGRlcnIsICJpbnB1dCBleHByZXNzaW9uOlxuIik7CisgICAgICBkZWJ1Z190cmVl IChleHByKTsKKyAgICAgIGZwcmludGYgKHN0ZGVyciwgInJlcXVlc3RlZCB0eXBlOlxuIik7Cisg ICAgICBkZWJ1Z190cmVlIChkc3RfdHlwZSk7CisgICAgICByZXR1cm4gZXJyb3JfbWFya19ub2Rl OworICAgIH0KIH0KIAogbmFtZXNwYWNlIGdjYyB7CmRpZmYgLS1naXQgYS9nY2MvdGVzdHN1aXRl L2ppdC5kZy9hbGwtbm9uLWZhaWxpbmctdGVzdHMuaCBiL2djYy90ZXN0c3VpdGUvaml0LmRnL2Fs bC1ub24tZmFpbGluZy10ZXN0cy5oCmluZGV4IDQyMDJlYjc3OThiLi44NGVmNTRhMDM4NiAxMDA2 NDQKLS0tIGEvZ2NjL3Rlc3RzdWl0ZS9qaXQuZGcvYWxsLW5vbi1mYWlsaW5nLXRlc3RzLmgKKysr IGIvZ2NjL3Rlc3RzdWl0ZS9qaXQuZGcvYWxsLW5vbi1mYWlsaW5nLXRlc3RzLmgKQEAgLTk4LDYg Kzk4LDEzIEBACiAjdW5kZWYgY3JlYXRlX2NvZGUKICN1bmRlZiB2ZXJpZnlfY29kZQogCisvKiB0 ZXN0LWNhc3QuYyAqLworI2RlZmluZSBjcmVhdGVfY29kZSBjcmVhdGVfY29kZV9jYXN0CisjZGVm aW5lIHZlcmlmeV9jb2RlIHZlcmlmeV9jb2RlX2Nhc3QKKyNpbmNsdWRlICJ0ZXN0LWNhc3QuYyIK KyN1bmRlZiBjcmVhdGVfY29kZQorI3VuZGVmIHZlcmlmeV9jb2RlCisKIC8qIHRlc3QtY29tcG91 bmQtYXNzaWdubWVudC5jICovCiAjZGVmaW5lIGNyZWF0ZV9jb2RlIGNyZWF0ZV9jb2RlX2NvbXBv dW5kX2Fzc2lnbm1lbnQKICNkZWZpbmUgdmVyaWZ5X2NvZGUgdmVyaWZ5X2NvZGVfY29tcG91bmRf YXNzaWdubWVudApAQCAtMzYxLDYgKzM2OCw5IEBAIGNvbnN0IHN0cnVjdCB0ZXN0Y2FzZSB0ZXN0 Y2FzZXNbXSA9IHsKICAgeyJjYWxsaW5nX2ludGVybmFsX2Z1bmN0aW9uIiwKICAgIGNyZWF0ZV9j b2RlX2NhbGxpbmdfaW50ZXJuYWxfZnVuY3Rpb24sCiAgICB2ZXJpZnlfY29kZV9jYWxsaW5nX2lu dGVybmFsX2Z1bmN0aW9ufSwKKyAgeyJjYXN0IiwKKyAgIGNyZWF0ZV9jb2RlX2Nhc3QsCisgICB2 ZXJpZnlfY29kZV9jYXN0fSwKICAgeyJjb21wb3VuZF9hc3NpZ25tZW50IiwKICAgIGNyZWF0ZV9j b2RlX2NvbXBvdW5kX2Fzc2lnbm1lbnQsCiAgICB2ZXJpZnlfY29kZV9jb21wb3VuZF9hc3NpZ25t ZW50fSwKZGlmZiAtLWdpdCBhL2djYy90ZXN0c3VpdGUvaml0LmRnL3Rlc3QtY2FzdC5jIGIvZ2Nj L3Rlc3RzdWl0ZS9qaXQuZGcvdGVzdC1jYXN0LmMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMDAwMDAuLjJiMWUzODVhZTQwCi0tLSAvZGV2L251bGwKKysrIGIvZ2NjL3Rlc3RzdWl0 ZS9qaXQuZGcvdGVzdC1jYXN0LmMKQEAgLTAsMCArMSw2NiBAQAorI2luY2x1ZGUgPHN0ZGxpYi5o PgorI2luY2x1ZGUgPHN0ZGlvLmg+CisjaW5jbHVkZSA8c3RyaW5nLmg+CisKKyNpbmNsdWRlICJs aWJnY2NqaXQuaCIKKworI2luY2x1ZGUgImhhcm5lc3MuaCIKKwordm9pZAorY3JlYXRlX2NvZGUg KGdjY19qaXRfY29udGV4dCAqY3R4dCwgdm9pZCAqdXNlcl9kYXRhKQoreworICAvKiBMZXQncyB0 cnkgdG8gaW5qZWN0IHRoZSBlcXVpdmFsZW50IG9mOgorY2hhcgorbXlfY2FzdHMgKGludCB4KQor eworICAgcmV0dXJuIChjaGFyKShsb25nKSB4OworfQorICAgKi8KKyAgZ2NjX2ppdF90eXBlICpp bnRfdHlwZSA9CisgICAgZ2NjX2ppdF9jb250ZXh0X2dldF90eXBlIChjdHh0LCBHQ0NfSklUX1RZ UEVfSU5UKTsKKyAgZ2NjX2ppdF90eXBlICpsb25nX3R5cGUgPQorICAgIGdjY19qaXRfY29udGV4 dF9nZXRfdHlwZSAoY3R4dCwgR0NDX0pJVF9UWVBFX0xPTkcpOworICBnY2Nfaml0X3R5cGUgKnJl dHVybl90eXBlID0KKyAgICBnY2Nfaml0X2NvbnRleHRfZ2V0X3R5cGUgKGN0eHQsIEdDQ19KSVRf VFlQRV9DSEFSKTsKKworICBnY2Nfaml0X3BhcmFtICp4ID0KKyAgICBnY2Nfaml0X2NvbnRleHRf bmV3X3BhcmFtICgKKyAgICAgIGN0eHQsCisgICAgICBOVUxMLAorICAgICAgaW50X3R5cGUsICJ4 Iik7CisgIGdjY19qaXRfcGFyYW0gKnBhcmFtc1sxXSA9IHt4fTsKKyAgZ2NjX2ppdF9mdW5jdGlv biAqZnVuYyA9CisgICAgZ2NjX2ppdF9jb250ZXh0X25ld19mdW5jdGlvbiAoY3R4dCwKKwkJCQkg IE5VTEwsCisJCQkJICBHQ0NfSklUX0ZVTkNUSU9OX0VYUE9SVEVELAorCQkJCSAgcmV0dXJuX3R5 cGUsCisJCQkJICAibXlfY2FzdHMiLAorCQkJCSAgMSwgcGFyYW1zLCAwKTsKKworICBnY2Nfaml0 X2Jsb2NrICppbml0aWFsID0KKyAgICBnY2Nfaml0X2Z1bmN0aW9uX25ld19ibG9jayAoZnVuYywg ImluaXRpYWwiKTsKKworICBnY2Nfaml0X2Jsb2NrX2VuZF93aXRoX3JldHVybihpbml0aWFsLCBO VUxMLAorICAgIGdjY19qaXRfY29udGV4dF9uZXdfY2FzdChjdHh0LAorICAgICAgICBOVUxMLAor ICAgICAgICBnY2Nfaml0X2NvbnRleHRfbmV3X2Nhc3QoY3R4dCwKKyAgICAgICAgICAgIE5VTEws CisgICAgICAgICAgICBnY2Nfaml0X3BhcmFtX2FzX3J2YWx1ZSh4KSwKKyAgICAgICAgICAgIGxv bmdfdHlwZQorICAgICAgICApLAorICAgICAgICByZXR1cm5fdHlwZQorICAgICkpOworfQorCit2 b2lkCit2ZXJpZnlfY29kZSAoZ2NjX2ppdF9jb250ZXh0ICpjdHh0LCBnY2Nfaml0X3Jlc3VsdCAq cmVzdWx0KQoreworICB0eXBlZGVmIGludCAoKm15X2Nhc3RzX2ZuX3R5cGUpIChpbnQpOworICBD SEVDS19OT05fTlVMTCAocmVzdWx0KTsKKyAgbXlfY2FzdHNfZm5fdHlwZSBteV9jYXN0cyA9Cisg ICAgKG15X2Nhc3RzX2ZuX3R5cGUpZ2NjX2ppdF9yZXN1bHRfZ2V0X2NvZGUgKHJlc3VsdCwgIm15 X2Nhc3RzIik7CisgIENIRUNLX05PTl9OVUxMIChteV9jYXN0cyk7CisgIGNoYXIgdmFsID0gbXlf Y2FzdHMgKDEwKTsKKyAgbm90ZSAoIm15X2Nhc3RzIHJldHVybmVkOiAlZCIsIHZhbCk7CisgIENI RUNLX1ZBTFVFICh2YWwsIDEwKTsKK30KLS0gCjIuMzIuMAoK --=-ERNa8Ur4CUIYyJnwecXl--