From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sender4-pp-o90.zoho.com (sender4-pp-o90.zoho.com [136.143.188.90]) by sourceware.org (Postfix) with ESMTPS id E0A2F3854153; Wed, 29 Jun 2022 13:44:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E0A2F3854153 ARC-Seal: i=1; a=rsa-sha256; t=1656510260; cv=none; d=zohomail.com; s=zohoarc; b=gg73GJC0OqQ2ltXZzkPyXwCycsGAZEGASLP1HLl0JGYgKNIOo0FWKdTu8vAO5qNHuVePQx1inWdKUzfV3DRn8cZeGfLb7OF5I4WN6sGCuld727aYhtHLEZAJjMo8xOuwnPR0pNFz8CLWwTiY4jyJ7DILFmJWMJENTjPsIA0jPQU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1656510260; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=sbdp5my88wM3QFx7YAu73pNu+Sa4ASSgvaWZwkAQLAs=; b=gW1jFnpR0cU36pcGcPo8+jkwZjPjOVsUvcYDfMfTR4euB3UV5/R6mqAPd6eLAu0FqWtXhIa4NcXKYh2CMEH1UDfL2Yu55/74nXan+wm1bOM9c4WGKoW3B6Y/4W2o9kYhKbNABwiHhVzFANf5mT2zajg5wo9iS3S9Lu4+87ARZUU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zoho.com; spf=pass smtp.mailfrom=bouanto@zoho.com; dmarc=pass header.from= Received: from [192.168.1.174] (38.87.11.6 [38.87.11.6]) by mx.zohomail.com with SMTPS id 1656510257218789.118903540374; Wed, 29 Jun 2022 06:44:17 -0700 (PDT) Message-ID: Subject: Re: [PATCH] libgccjit: Fix bug where unary_op will return an integer type instead of the correct type From: Antoni Boucher To: David Malcolm , gcc-patches@gcc.gnu.org, jit@gcc.gnu.org Date: Wed, 29 Jun 2022 09:44:15 -0400 In-Reply-To: <7f2ff95927e7dc1b6e48aaf5b1753180eaecfa64.camel@redhat.com> References: <7f2ff95927e7dc1b6e48aaf5b1753180eaecfa64.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.2 MIME-Version: 1.0 X-ZohoMailClient: External X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: jit@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Jit mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2022 13:44:27 -0000 It fails with the following error: gcc/gcc/testsuite/jit.dg/test-asm.cc: In function 'void verify_code_2(gcc_jit_context*, gcc_jit_result*)': gcc/gcc/testsuite/jit.dg/test-asm.cc:160:11: error: ISO C++ forbids declaration of 'uint32_t' with no type [-fpermissive] gcc/gcc/testsuite/jit.dg/test-asm.cc:160:11: error: typedef 'uint32_t' is initialized (use 'decltype' instead) Are you OK with me adding the stdint.h header? On Tue, 2022-06-28 at 18:40 -0400, David Malcolm wrote: > On Wed, 2022-06-01 at 22:45 -0400, Antoni Boucher via Gcc-patches > wrote: > > Also, the test gcc/testsuite/jit.dg/test-asm.cc fails and would > > need > > this line: > >=20 > > #include >=20 > I'm curious; how is it failing? >=20 > >=20 > > Is this okay if I add it in this patch? > >=20 > > On Wed, 2022-06-01 at 22:13 -0400, Antoni Boucher wrote: > > > Hi. > > > The attached patch fix bug 105812: > > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D105812 > > >=20 > > > I'm having an issue where contrib/check_GNU_style.sh doesn't seem > > > to > > > work, i.e. it doesn't seem to do any checking. > > > Is there a new way to do that or am I missing something? > > >=20 > > > Thanks for the review. > >=20 >=20 >=20