From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D34733858D28 for ; Tue, 3 Oct 2023 17:11:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D34733858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696353092; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OnWR4vCLk5W4v9nNzMbB4ooWMzBuOBMVjkQZJnLRPzg=; b=B39kvEfWZf9oyIwALP5BDSRmcDjEQ25+kyb5Z/MMbRy1RkEt2V/kST8OnEefh8iYt2aK8t 8wm9wtCNkClydxyIuJNYeITRcK8UOJXZB4pHpbV3ftZweCW6+ArtpEsvz1X2/BTstds7dd Xd9w9g4R8O747VPY0oMUp7jvj5cXkK8= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-614-0qHQfbmYO8KfcAOkOJsNvA-1; Tue, 03 Oct 2023 13:11:30 -0400 X-MC-Unique: 0qHQfbmYO8KfcAOkOJsNvA-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-77578227e4bso142370185a.2 for ; Tue, 03 Oct 2023 10:11:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696353090; x=1696957890; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ClZUiAtgXsz/9tXCuyvXEA2nJOZh//hax+ArT2IzckY=; b=a/8AbYF6bSB7L09OPbzprXt73L+Ln1F3gZxpe3JKilDxRUyhmD8qWU0/6dVU703qDU iPqDJLMIlbuvx/zdWybG2jg2GIDmAPt6TrDexAXjMFdghyoqf7sNMaTt87aQ/y+D/Jc+ Yh2twkAg5xCYoDKEVuZB5C+3UpVpITI8hZWT51SgLd4yxZ8mADX6sxMxXfOkn1/3Do8X T407Mkgp3Qeb0Vk26+c6vRQmC/kWmWMnKoH0pFJWPKeKEmLjdo6ExmSIfdzeK01ASN4R t6ArMAp7pWko4ozGl2LF6oPz3BFt8S7hC8mza28pmfa6vu8ZolfXG5228jEAw8PVpSQc Ndjw== X-Gm-Message-State: AOJu0YyDl5JTJ1piQH0r4d18WT7DdcjTKWKyw8SzjIbzMaLBa80rM3ux DyvH7sErSIXsiFhFzl0P5YU87czyXHRiXysxop2J9Lrfjb+efZr+l2mDVOlyvESugyAu1kown/Y fE/CHwz4= X-Received: by 2002:a05:620a:4554:b0:767:f49c:1d67 with SMTP id u20-20020a05620a455400b00767f49c1d67mr272050qkp.1.1696353090333; Tue, 03 Oct 2023 10:11:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG39mUk9V2dq5S/JpH/xArVIrICQXLo5WA4xtawLqXPspEf3Nt/9X59mijEWsOS6mT3VRNplg== X-Received: by 2002:a05:620a:4554:b0:767:f49c:1d67 with SMTP id u20-20020a05620a455400b00767f49c1d67mr272029qkp.1.1696353090035; Tue, 03 Oct 2023 10:11:30 -0700 (PDT) Received: from [192.168.0.174] ([104.219.124.252]) by smtp.gmail.com with ESMTPSA id c17-20020a05620a165100b0077412ca0ae1sm607958qko.65.2023.10.03.10.11.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Oct 2023 10:11:29 -0700 (PDT) Message-ID: Date: Tue, 3 Oct 2023 13:11:31 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [COMMITTED] Remove pass counting in VRP. To: David Malcolm , gcc-patches Cc: jit@gcc.gnu.org References: <248800ec-0e0e-6cae-5aaa-a9c69cd5f46a@redhat.com> <32f0b8a98304dcce002b38c94de951b49cc5b8fe.camel@redhat.com> From: Andrew MacLeod In-Reply-To: <32f0b8a98304dcce002b38c94de951b49cc5b8fe.camel@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="------------ovmANuGJQl6ewo3qwZJdG4nY" Content-Language: en-US X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------ovmANuGJQl6ewo3qwZJdG4nY Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/3/23 13:02, David Malcolm wrote: > On Tue, 2023-10-03 at 10:32 -0400, Andrew MacLeod wrote: >> Pass counting in VRP is used to decide when to call early VRP, pass >> the >> flag to enable warnings, and when the final pass is. >> >> If you try to add additional passes, this becomes quite fragile. This >> patch simply chooses the pass based on the data pointer passed in, >> and >> remove the pass counter.   The first FULL VRP pass invokes the >> warning >> code, and the flag passed in now represents the FINAL pass of VRP. >> There is no longer a global flag which, as it turns out, wasn't >> working >> well with the JIT compiler, but when undetected.  (Thanks to dmalcolm >> for helping me sort out what was going on there) >> >> >> Bootstraps  on x86_64-pc-linux-gnu with no regressions.   Pushed. > [CCing jit mailing list] > > I'm worried that this patch may have "papered over" an issue with > libgccjit. Specifically: well, that isnt the patch that was checked in :-P Im not sure how the old version got into the commit note. Attached is the version checked in. --------------ovmANuGJQl6ewo3qwZJdG4nY Content-Type: text/x-patch; charset=UTF-8; name="pass.diff" Content-Disposition: attachment; filename="pass.diff" Content-Transfer-Encoding: base64 Y29tbWl0IDdlYjVjZTdmNThlZDRhNDg2NDFlMTc4NmU0ZmRlYjJmN2ZiOGM1ZmYKQXV0aG9yOiBB bmRyZXcgTWFjTGVvZCA8YW1hY2xlb2RAcmVkaGF0LmNvbT4KRGF0ZTogICBUaHUgU2VwIDI4IDA5 OjE5OjMyIDIwMjMgLTA0MDAKCiAgICBSZW1vdmUgcGFzcyBjb3VudGluZyBpbiBWUlAuCiAgICAK ICAgIFJhdGhlciB0aGFuIHVzaW5nIGEgcGFzcyBjb3VudCB0byBkZWNpZGUgd2hpY2ggcGFyYW1l dGVycyBhcmUgcGFzc2VkIHRvCiAgICBWUlAsIG1ha2VtaXQgZXhwbGljaXQuCiAgICAKICAgICAg ICAgICAgKiBwYXNzZXMuZGVmIChwYXNzX3ZycCk6IFBhc3MgImZpbmFsIHBhc3MiIGZsYWcgYXMg cGFyYW1ldGVyLgogICAgICAgICAgICAqIHRyZWUtdnJwLmNjICh2cnBfcGFzc19udW0pOiBSZW1v dmUuCiAgICAgICAgICAgIChwYXNzX3ZycDo6bXlfcGFzcyk6IFJlbW92ZS4KICAgICAgICAgICAg KHBhc3NfdnJwOjpwYXNzX3ZycCk6IEFkZCB3YXJuX3AgYXMgYSBwYXJhbWV0ZXIuCiAgICAgICAg ICAgIChwYXNzX3ZycDo6ZmluYWxfcCk6IE5ldy4KICAgICAgICAgICAgKHBhc3NfdnJwOjpzZXRf cGFzc19wYXJhbSk6IFNldCBmaW5hbF9wIHBhcmFtLgogICAgICAgICAgICAocGFzc192cnA6OmV4 ZWN1dGUpOiBDYWxsIGV4ZWN1dGVfcmFuZ2VfdnJwIHdpdGggbm8gY29uZGl0aW9ucy4KICAgICAg ICAgICAgKG1ha2VfcGFzc192cnApOiBQYXNzIGFkZGl0aW9uYWwgcGFyYW1ldGVyLgogICAgICAg ICAgICAobWFrZV9wYXNzX2Vhcmx5X3ZycCk6IERpdHRvLgoKZGlmZiAtLWdpdCBhL2djYy9wYXNz ZXMuZGVmIGIvZ2NjL3Bhc3Nlcy5kZWYKaW5kZXggNDExMGE0NzI5MTQuLjJiYWZkNjBiYmZiIDEw MDY0NAotLS0gYS9nY2MvcGFzc2VzLmRlZgorKysgYi9nY2MvcGFzc2VzLmRlZgpAQCAtMjIxLDcg KzIyMSw3IEBAIGFsb25nIHdpdGggR0NDOyBzZWUgdGhlIGZpbGUgQ09QWUlORzMuICBJZiBub3Qg c2VlCiAgICAgICBORVhUX1BBU1MgKHBhc3NfZnJlLCB0cnVlIC8qIG1heV9pdGVyYXRlICovKTsK ICAgICAgIE5FWFRfUEFTUyAocGFzc19tZXJnZV9waGkpOwogICAgICAgTkVYVF9QQVNTIChwYXNz X3RocmVhZF9qdW1wc19mdWxsLCAvKmZpcnN0PSovdHJ1ZSk7Ci0gICAgICBORVhUX1BBU1MgKHBh c3NfdnJwLCB0cnVlIC8qIHdhcm5fYXJyYXlfYm91bmRzX3AgKi8pOworICAgICAgTkVYVF9QQVNT IChwYXNzX3ZycCwgZmFsc2UgLyogZmluYWxfcCovKTsKICAgICAgIE5FWFRfUEFTUyAocGFzc19k c2UpOwogICAgICAgTkVYVF9QQVNTIChwYXNzX2RjZSk7CiAgICAgICAvKiBwYXNzX3N0ZGFyZyBp cyBhbHdheXMgcnVuIGFuZCBhdCB0aGlzIHBvaW50IHdlIGV4ZWN1dGUKQEAgLTM0OCw3ICszNDgs NyBAQCBhbG9uZyB3aXRoIEdDQzsgc2VlIHRoZSBmaWxlIENPUFlJTkczLiAgSWYgbm90IHNlZQog ICAgICAgTkVYVF9QQVNTIChwYXNzX2RvbWluYXRvciwgZmFsc2UgLyogbWF5X3BlZWxfbG9vcF9o ZWFkZXJzX3AgKi8pOwogICAgICAgTkVYVF9QQVNTIChwYXNzX3N0cmxlbik7CiAgICAgICBORVhU X1BBU1MgKHBhc3NfdGhyZWFkX2p1bXBzX2Z1bGwsIC8qZmlyc3Q9Ki9mYWxzZSk7Ci0gICAgICBO RVhUX1BBU1MgKHBhc3NfdnJwLCBmYWxzZSAvKiB3YXJuX2FycmF5X2JvdW5kc19wICovKTsKKyAg ICAgIE5FWFRfUEFTUyAocGFzc192cnAsIHRydWUgLyogZmluYWxfcCAqLyk7CiAgICAgICAvKiBS dW4gQ0NQIHRvIGNvbXB1dGUgYWxpZ25tZW50IGFuZCBub256ZXJvIGJpdHMuICAqLwogICAgICAg TkVYVF9QQVNTIChwYXNzX2NjcCwgdHJ1ZSAvKiBub256ZXJvX3AgKi8pOwogICAgICAgTkVYVF9Q QVNTIChwYXNzX3dhcm5fcmVzdHJpY3QpOwpkaWZmIC0tZ2l0IGEvZ2NjL3RyZWUtdnJwLmNjIGIv Z2NjL3RyZWUtdnJwLmNjCmluZGV4IGQ3YjE5NGY1OTA0Li40ZjhjNzc0NTQ2MSAxMDA2NDQKLS0t IGEvZ2NjL3RyZWUtdnJwLmNjCisrKyBiL2djYy90cmVlLXZycC5jYwpAQCAtMTEyMCwzNiArMTEy MCwzMiBAQCBjb25zdCBwYXNzX2RhdGEgcGFzc19kYXRhX2Vhcmx5X3ZycCA9CiAgICggVE9ET19j bGVhbnVwX2NmZyB8IFRPRE9fdXBkYXRlX3NzYSB8IFRPRE9fdmVyaWZ5X2FsbCApLAogfTsKIAot c3RhdGljIGludCB2cnBfcGFzc19udW0gPSAwOwogY2xhc3MgcGFzc192cnAgOiBwdWJsaWMgZ2lt cGxlX29wdF9wYXNzCiB7CiBwdWJsaWM6Ci0gIHBhc3NfdnJwIChnY2M6OmNvbnRleHQgKmN0eHQs IGNvbnN0IHBhc3NfZGF0YSAmZGF0YV8pCi0gICAgOiBnaW1wbGVfb3B0X3Bhc3MgKGRhdGFfLCBj dHh0KSwgZGF0YSAoZGF0YV8pLCB3YXJuX2FycmF5X2JvdW5kc19wIChmYWxzZSksCi0gICAgICBt eV9wYXNzICh2cnBfcGFzc19udW0rKykKLSAge30KKyAgcGFzc192cnAgKGdjYzo6Y29udGV4dCAq Y3R4dCwgY29uc3QgcGFzc19kYXRhICZkYXRhXywgYm9vbCB3YXJuX3ApCisgICAgOiBnaW1wbGVf b3B0X3Bhc3MgKGRhdGFfLCBjdHh0KSwgZGF0YSAoZGF0YV8pLAorICAgICAgd2Fybl9hcnJheV9i b3VuZHNfcCAod2Fybl9wKSwgZmluYWxfcCAoZmFsc2UpCisgICAgeyB9CiAKICAgLyogb3B0X3Bh c3MgbWV0aG9kczogKi8KLSAgb3B0X3Bhc3MgKiBjbG9uZSAoKSBmaW5hbCBvdmVycmlkZSB7IHJl dHVybiBuZXcgcGFzc192cnAgKG1fY3R4dCwgZGF0YSk7IH0KKyAgb3B0X3Bhc3MgKiBjbG9uZSAo KSBmaW5hbCBvdmVycmlkZQorICAgIHsgcmV0dXJuIG5ldyBwYXNzX3ZycCAobV9jdHh0LCBkYXRh LCBmYWxzZSk7IH0KICAgdm9pZCBzZXRfcGFzc19wYXJhbSAodW5zaWduZWQgaW50IG4sIGJvb2wg cGFyYW0pIGZpbmFsIG92ZXJyaWRlCiAgICAgewogICAgICAgZ2NjX2Fzc2VydCAobiA9PSAwKTsK LSAgICAgIHdhcm5fYXJyYXlfYm91bmRzX3AgPSBwYXJhbTsKKyAgICAgIGZpbmFsX3AgPSBwYXJh bTsKICAgICB9CiAgIGJvb2wgZ2F0ZSAoZnVuY3Rpb24gKikgZmluYWwgb3ZlcnJpZGUgeyByZXR1 cm4gZmxhZ190cmVlX3ZycCAhPSAwOyB9CiAgIHVuc2lnbmVkIGludCBleGVjdXRlIChmdW5jdGlv biAqZnVuKSBmaW5hbCBvdmVycmlkZQogICAgIHsKLSAgICAgIC8vIEVhcmx5IFZSUCBwYXNzLgot ICAgICAgaWYgKG15X3Bhc3MgPT0gMCkKLQlyZXR1cm4gZXhlY3V0ZV9yYW5nZXJfdnJwIChmdW4s IC8qd2Fybl9hcnJheV9ib3VuZHNfcD0qL2ZhbHNlLCBmYWxzZSk7Ci0KLSAgICAgIHJldHVybiBl eGVjdXRlX3Jhbmdlcl92cnAgKGZ1biwgd2Fybl9hcnJheV9ib3VuZHNfcCwgbXlfcGFzcyA9PSAy KTsKKyAgICAgIHJldHVybiBleGVjdXRlX3Jhbmdlcl92cnAgKGZ1biwgd2Fybl9hcnJheV9ib3Vu ZHNfcCwgZmluYWxfcCk7CiAgICAgfQogCiAgcHJpdmF0ZToKICAgY29uc3QgcGFzc19kYXRhICZk YXRhOwogICBib29sIHdhcm5fYXJyYXlfYm91bmRzX3A7Ci0gIGludCBteV9wYXNzOworICBib29s IGZpbmFsX3A7CiB9OyAvLyBjbGFzcyBwYXNzX3ZycAogCiBjb25zdCBwYXNzX2RhdGEgcGFzc19k YXRhX2Fzc3VtcHRpb25zID0KQEAgLTEyMTksMTMgKzEyMTUsMTMgQEAgcHVibGljOgogZ2ltcGxl X29wdF9wYXNzICoKIG1ha2VfcGFzc192cnAgKGdjYzo6Y29udGV4dCAqY3R4dCkKIHsKLSAgcmV0 dXJuIG5ldyBwYXNzX3ZycCAoY3R4dCwgcGFzc19kYXRhX3ZycCk7CisgIHJldHVybiBuZXcgcGFz c192cnAgKGN0eHQsIHBhc3NfZGF0YV92cnAsIHRydWUpOwogfQogCiBnaW1wbGVfb3B0X3Bhc3Mg KgogbWFrZV9wYXNzX2Vhcmx5X3ZycCAoZ2NjOjpjb250ZXh0ICpjdHh0KQogewotICByZXR1cm4g bmV3IHBhc3NfdnJwIChjdHh0LCBwYXNzX2RhdGFfZWFybHlfdnJwKTsKKyAgcmV0dXJuIG5ldyBw YXNzX3ZycCAoY3R4dCwgcGFzc19kYXRhX2Vhcmx5X3ZycCwgZmFsc2UpOwogfQogCiBnaW1wbGVf b3B0X3Bhc3MgKgo= --------------ovmANuGJQl6ewo3qwZJdG4nY--